Skip to content

Commit b5ed178

Browse files
Update PR template for PCI (#13387)
1 parent 9b6353a commit b5ed178

File tree

1 file changed

+19
-7
lines changed

1 file changed

+19
-7
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 19 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,31 @@
1-
**DELETE THIS TEMPLATE BEFORE SUBMITTING**
1+
**DELETE THIS PART BEFORE SUBMITTING**
22

33
In order to have a good experience with our community, we recommend that you
44
read the contributing guidelines for making a PR, and understand the lifecycle
5-
of a Packer PR:
6-
7-
https://github.com/hashicorp/packer/blob/master/.github/CONTRIBUTING.md#opening-an-pull-request
8-
9-
Describe the change you are making here!
5+
of a Packer Plugin PR:
6+
- https://github.com/hashicorp/$REPO_NAME/blob/main/.github/CONTRIBUTING.md#opening-an-pull-request
107

118
Please include tests. Check out these examples:
129

1310
- https://github.com/hashicorp/packer/blob/master/builder/parallels/common/ssh_config_test.go#L34
1411
- https://github.com/hashicorp/packer/blob/master/post-processor/compress/post-processor_test.go#L153-L182
1512

16-
If your PR resolves any open issue(s), please indicate them like this so they will be closed when your PR is merged:
13+
----
14+
15+
### Description
16+
What code changed, and why?
1717

18+
### Resolved Issues
19+
If your PR resolves any open issue(s), please indicate them like this so they
20+
will be closed when your PR is merged:
1821
Closes #xxx
1922
Closes #xxx
23+
24+
<!-- heimdall_github_prtemplate:grc-pci_dss-2024-01-05 -->
25+
### Rollback Plan
26+
If a change needs to be reverted, we will roll out an update to the code within
27+
7 days.
28+
29+
### Changes to Security Controls
30+
Are there any changes to security controls (access controls, encryption, logging)
31+
in this pull request? If so, explain.

0 commit comments

Comments
 (0)