-
-
Notifications
You must be signed in to change notification settings - Fork 851
Open
Labels
Complexity: LargeP-Feature: Toolkithttps://www.hackforla.org/toolkit/https://www.hackforla.org/toolkit/ready for merge teamneeds a senior review either to do some re writing or to approve it for ready for prioritizationneeds a senior review either to do some re writing or to approve it for ready for prioritizationrole: back end/devOpsTasks for back-end developersTasks for back-end developerssize: 2ptCan be done in 7-12 hoursCan be done in 7-12 hours
Description
Prerequisite
- Be a member of Hack for LA. (There are no fees to join.) If you have not joined yet, please follow the steps on our Getting Started page and attend an onboarding session.
- Before you claim or start working on an issue, please make sure you have read our How to Contribute to Hack for LA Guide.
Overview
We need to add filtering functionality to the Toolkit page so that selected filters are applied to the External Resources cards in addition to the Guide Pages cards.
Details
Currently, the Toolkit page includes two types of cards:
- Guide Pages cards, e.g. 2FA Guide, Building a Survey Reporting Dashboard
- External Resources cards, e.g. Figma, GitHub
The filters on the Toolkit page work correctly on the Guide Pages cards, and this functionality should not be changed. The purpose of this issue is to add filtering to the External Resources cards.
Action Items
- In
/assets/js/toolkit.js, examine theapplyFiltersandretrieveFilterCategoriesfunctions to understand how filters are currently generated and applied to the Guide Page cards. The following files will also be helpful to view to understand how the External Resource cards are created:includes/current-guides.htmldata/internal/toolkitresources.ymlincludes/guide-card.html
- In
current-guides.html, make the following changes:- External Resource card div elements should have an attribute
data-project-Toolsalongside thedata-article-typeattribute.data-project-Toolsshould be populated from thetoolslisted intoolkitresources.yml. - Each External Resource card div should have the class
resource-card.
- External Resource card div elements should have an attribute
- In
toolkit.js, edit theretrieveFilterCategoriesfunction to add Practice Area and Tools categories from External Resource cards to the filters list, using the attributes you added in the previous steps. - Edit the
applyFiltersfunction to filter the External Resources cards when a Practice Area or Tools filter is selected. The other filter categories Status, Source, and Contributors will not apply to External Resources, so if one of them is selected, all External Resource cards should be hidden. - Test that the filters work as expected to filter both Guide Cards and External Resource cards.
- Verify that the URL parameters are still updated when filters are selected and deselected.
- If it was necessary to make changes to other functions or files in the course of this issue, make note of these additional changes in your PR.
Resources/Instructions
- Toolkit Page: https://www.hackforla.org/toolkit/
- JS file containing filtering function: assets/js/toolkit.js
- HTML file template for toolkit cards: includes/current-guides.html
- YAML file with External Resource card data: data/internal/toolkitresources.yml
- HTML template for Guide Page cards: /includes/guide-card.html
- This issue initiated by: ER: Add filtering to External Resources on Toolkit page #8509
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Complexity: LargeP-Feature: Toolkithttps://www.hackforla.org/toolkit/https://www.hackforla.org/toolkit/ready for merge teamneeds a senior review either to do some re writing or to approve it for ready for prioritizationneeds a senior review either to do some re writing or to approve it for ready for prioritizationrole: back end/devOpsTasks for back-end developersTasks for back-end developerssize: 2ptCan be done in 7-12 hoursCan be done in 7-12 hours
Type
Projects
Status
New Issue Approval