Make addedToNewType consistent across changes

Author: jdolle

packages/core/__tests__/diff/enum.test.ts

@@ -46,7 +46,7 @@ describe('enum', () => {
       expect(change.meta).toMatchObject({
         addedEnumValueName: 'A',
         enumName: 'enumA',
-        enumIsOld: false,
+        addedToNewType: true,
       });
     }
   });

packages/core/src/diff/changes/change.ts

@@ -254,7 +254,7 @@ export type EnumValueAddedChange = {
   meta: {
     enumName: string;
     addedEnumValueName: string;
-    enumIsOld: boolean;
+    addedToNewType: boolean;
   };
 };
 
@@ -517,7 +517,7 @@ export type ObjectTypeInterfaceAddedChange = {
   meta: {
     objectTypeName: string;
     addedInterfaceName: string;
-    isSafeChange: boolean;
+    addedToNewType: boolean;
   };
 };
 
@@ -635,7 +635,7 @@ export type UnionMemberAddedChange = {
   meta: {
     unionName: string;
     addedUnionMemberTypeName: string;
-    isSafeChange: boolean;
+    addedToNewType: boolean;
   };
 };
 

packages/core/src/diff/changes/enum.ts

@@ -55,12 +55,12 @@ const enumValueAddedCriticalityDangerousReason = `Adding an enum value may break
 
 export function enumValueAddedFromMeta(args: EnumValueAddedChange) {
   /** Dangerous is there was a previous enum value */
-  const isDangerous = args.meta.enumIsOld === true;
+  const isSafe = args.meta.addedToNewType;
   return {
     type: ChangeType.EnumValueAdded,
     criticality: {
-      level: isDangerous ? CriticalityLevel.Dangerous : CriticalityLevel.NonBreaking,
-      reason: isDangerous ? enumValueAddedCriticalityDangerousReason : undefined,
+      level: isSafe ? CriticalityLevel.NonBreaking : CriticalityLevel.Dangerous,
+      reason: isSafe ? undefined : enumValueAddedCriticalityDangerousReason,
     },
     message: buildEnumValueAddedMessage(args),
     meta: args.meta,
@@ -71,14 +71,14 @@ export function enumValueAddedFromMeta(args: EnumValueAddedChange) {
 export function enumValueAdded(
   type: GraphQLEnumType,
   value: GraphQLEnumValue,
-  enumIsOld: boolean,
+  addedToNewType: boolean,
 ): Change<typeof ChangeType.EnumValueAdded> {
   return enumValueAddedFromMeta({
     type: ChangeType.EnumValueAdded,
     meta: {
       enumName: type.name,
       addedEnumValueName: value.name,
-      enumIsOld,
+      addedToNewType,
     },
   });
 }

packages/core/src/diff/changes/object.ts

@@ -15,7 +15,7 @@ export function objectTypeInterfaceAddedFromMeta(args: ObjectTypeInterfaceAddedC
   return {
     type: ChangeType.ObjectTypeInterfaceAdded,
     criticality: {
-      level: args.meta.isSafeChange ? CriticalityLevel.NonBreaking : CriticalityLevel.Dangerous,
+      level: args.meta.addedToNewType ? CriticalityLevel.NonBreaking : CriticalityLevel.Dangerous,
       reason:
         'Adding an interface to an object type may break existing clients that were not programming defensively against a new possible type.',
     },
@@ -28,14 +28,14 @@ export function objectTypeInterfaceAddedFromMeta(args: ObjectTypeInterfaceAddedC
 export function objectTypeInterfaceAdded(
   iface: GraphQLInterfaceType,
   type: GraphQLObjectType | GraphQLInterfaceType,
-  isSafeChange: boolean,
+  addedToNewType: boolean,
 ): Change<typeof ChangeType.ObjectTypeInterfaceAdded> {
   return objectTypeInterfaceAddedFromMeta({
     type: ChangeType.ObjectTypeInterfaceAdded,
     meta: {
       objectTypeName: type.name,
       addedInterfaceName: iface.name,
-      isSafeChange,
+      addedToNewType,
     },
   });
 }

packages/core/src/diff/changes/union.ts

@@ -45,7 +45,7 @@ function buildUnionMemberAddedMessage(args: UnionMemberAddedChange['meta']) {
 export function buildUnionMemberAddedMessageFromMeta(args: UnionMemberAddedChange) {
   return {
     criticality: {
-      level: args.meta.isSafeChange ? CriticalityLevel.NonBreaking : CriticalityLevel.Dangerous,
+      level: args.meta.addedToNewType ? CriticalityLevel.NonBreaking : CriticalityLevel.Dangerous,
       reason:
         'Adding a possible type to Unions may break existing clients that were not programming defensively against a new possible type.',
     },
@@ -59,14 +59,14 @@ export function buildUnionMemberAddedMessageFromMeta(args: UnionMemberAddedChang
 export function unionMemberAdded(
   union: GraphQLUnionType,
   type: GraphQLObjectType,
-  isSafeChange: boolean,
+  addedToNewType: boolean,
 ): Change<typeof ChangeType.UnionMemberAdded> {
   return buildUnionMemberAddedMessageFromMeta({
     type: ChangeType.UnionMemberAdded,
     meta: {
       unionName: union.name,
       addedUnionMemberTypeName: type.name,
-      isSafeChange,
+      addedToNewType,
     },
   });
 }

packages/core/src/diff/enum.ts

@@ -18,7 +18,7 @@ export function changesInEnum(
 ) {
   compareLists(oldEnum?.getValues() ?? [], newEnum.getValues(), {
     onAdded(value) {
-      addChange(enumValueAdded(newEnum, value, !!oldEnum));
+      addChange(enumValueAdded(newEnum, value, oldEnum === null));
       changesInEnumValue({ newVersion: value, oldVersion: null }, newEnum, addChange);
     },
     onRemoved(value) {