Skip to content

Commit 8f6f731

Browse files
committed
PR-comment automation works now. Fix nits
1 parent 279abe9 commit 8f6f731

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

.github/workflows/pr-comment.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,9 @@ jobs:
4040
comment-author: 'github-actions[bot]'
4141
body-includes: "<!-- pr-comment -->"
4242

43-
# If 'requested'
43+
# If 'pr' workflow run was 'requested'...
4444
- if: github.event.action == 'requested'
45-
name: If 'requested' - Update Comment
45+
name: PR workflow started - Update Comment
4646
uses: peter-evans/create-or-update-comment@v5
4747
with:
4848
issue-number: ${{ steps.pr-context.outputs.number }}
@@ -52,9 +52,9 @@ jobs:
5252
<!-- pr-comment -->
5353
Waiting for [build job](https://github.com/${{github.repository}}/actions/runs/${{github.event.workflow_run.id}}) (at ${{ github.event.workflow_run.head_sha }})...
5454
55-
# If 'completed'
55+
# If 'pr' workflow run was 'completed'...
5656
- if: github.event.action == 'completed'
57-
name: If 'completed' - Download pr-comment-body.txt
57+
name: PR workflow completed - Download pr-comment-body.txt
5858
uses: actions/download-artifact@v4
5959
continue-on-error: true
6060
with:
@@ -63,7 +63,7 @@ jobs:
6363
run-id: ${{ github.event.workflow_run.id }}
6464
name: pr-comment-body.txt
6565
- if: github.event.action == 'completed'
66-
name: If 'completed' - Create pr-comment.txt
66+
name: PR workflow completed - Create pr-comment.txt
6767
env:
6868
REPO: ${{github.repository}}
6969
RUN_ID: ${{github.event.workflow_run.id}}
@@ -85,7 +85,7 @@ jobs:
8585
fi
8686
) > pr-comment.txt
8787
- if: github.event.action == 'completed'
88-
name: If 'completed' - Update Comment
88+
name: PR workflow completed - Update Comment
8989
uses: peter-evans/create-or-update-comment@v5
9090
with:
9191
issue-number: ${{ steps.pr-context.outputs.number }}

.github/workflows/pr.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,10 +39,10 @@ jobs:
3939
tools/validate --print-case-count-report src/webgpu > case-count-report-after.txt
4040
- name: checkout before PR
4141
env:
42-
PR_REF: ${{ github.event.pull_request.base.ref }}
42+
PR_BASE_REF: ${{ github.event.pull_request.base.ref }}
4343
run: |
44-
git fetch origin "${PR_REF}"
45-
git checkout "${PR_REF}"
44+
git fetch origin "${PR_BASE_REF}"
45+
git checkout "${PR_BASE_REF}"
4646
- name: compute case count before PR and diff
4747
id: case_count_diff
4848
run: |

0 commit comments

Comments
 (0)