Skip to content

Commit 8ceeaae

Browse files
authored
chore(logging): standardize logging in _shared_macros (#2277)
1 parent 4cb1fa2 commit 8ceeaae

File tree

6 files changed

+388
-295
lines changed
  • gapic/templates/%namespace/%name_%version/%sub/services/%service
  • tests/integration/goldens
    • asset/google/cloud/asset_v1/services/asset_service/transports
    • credentials/google/iam/credentials_v1/services/iam_credentials/transports
    • eventarc/google/cloud/eventarc_v1/services/eventarc/transports
    • redis/google/cloud/redis_v1/services/cloud_redis/transports

6 files changed

+388
-295
lines changed

gapic/templates/%namespace/%name_%version/%sub/services/%service/_shared_macros.j2

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -218,17 +218,19 @@ def _get_http_options():
218218
request_url = "{host}{uri}".format(host=self._host, uri=transcoded_request['uri'])
219219
method = transcoded_request['method']
220220
http_request = {
221-
"payload": type(request).to_json(request),
221+
"payload": type(request).to_json(request),
222222
"requestMethod": method,
223223
"requestUrl": request_url,
224+
"headers": dict(metadata),
224225
}
225226
_LOGGER.debug(
226-
f"Sending request for {{ service.meta.address.proto_package_versioned }}.{{ service.client_name }}.{{ method_name }}",
227+
f"Sending request for {{ service.meta.address.proto_package_versioned }}.{{ service.client_name }}.{{ method_name }}",
227228
extra = {
228229
"serviceName": "{{ service.meta.address.proto }}",
229230
"rpcName": "{{ method_name }}",
230-
"metadata": str(dict(metadata)),
231231
"httpRequest": http_request,
232+
{# TODO(https://github.com/googleapis/gapic-generator-python/issues/2275): logging `metadata` seems repetitive and may need to be cleaned up #}
233+
"metadata": http_request["headers"],
232234
},
233235
)
234236

@@ -478,9 +480,9 @@ class _{{ name }}(_Base{{ service.name }}RestTransport._Base{{name}}, {{ async_m
478480
extra = {
479481
"serviceName": "{{ service.meta.address.proto }}",
480482
"rpcName": "{{ name }}",
483+
"httpResponse": http_response,
481484
{# TODO(https://github.com/googleapis/gapic-generator-python/issues/2275): logging `metadata` seems repetitive and may need to be cleaned up #}
482485
"metadata": http_response["headers"],
483-
"httpResponse": http_response,
484486
},
485487
)
486488
return resp

0 commit comments

Comments
 (0)