Skip to content

Commit 9158d8b

Browse files
authored
spring-security: fix broken build (#14537)
Minor changes are needed in `oauth2-jose/NimbusJwtEncoderFuzzer.java` and a few updates in the `.patch` file. Signed-off-by: Adam Korczynski <[email protected]>
1 parent 0cfb57e commit 9158d8b

File tree

2 files changed

+69
-50
lines changed

2 files changed

+69
-50
lines changed

projects/spring-security/diff.patch

Lines changed: 62 additions & 50 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,3 @@
1-
diff --git a/oauth2/oauth2-client/spring-security-oauth2-client.gradle b/oauth2/oauth2-client/spring-security-oauth2-client.gradle
2-
index 0666a90..94c14cd 100644
3-
--- a/oauth2/oauth2-client/spring-security-oauth2-client.gradle
4-
+++ b/oauth2/oauth2-client/spring-security-oauth2-client.gradle
5-
@@ -1,3 +1,4 @@
6-
+apply plugin: "com.github.johnrengelman.shadow"
7-
apply plugin: 'io.spring.convention.spring-module'
8-
9-
dependencies {
10-
diff --git a/oauth2/oauth2-jose/spring-security-oauth2-jose.gradle b/oauth2/oauth2-jose/spring-security-oauth2-jose.gradle
11-
index 8290b85..c177be4 100644
12-
--- a/oauth2/oauth2-jose/spring-security-oauth2-jose.gradle
13-
+++ b/oauth2/oauth2-jose/spring-security-oauth2-jose.gradle
14-
@@ -1,3 +1,4 @@
15-
+apply plugin: "com.github.johnrengelman.shadow"
16-
apply plugin: 'io.spring.convention.spring-module'
17-
18-
dependencies {
191
diff --git a/acl/spring-security-acl.gradle b/acl/spring-security-acl.gradle
202
index 976d8d4..f01b423 100644
213
--- a/acl/spring-security-acl.gradle
@@ -26,53 +8,56 @@ index 976d8d4..f01b423 100644
268

279
dependencies {
2810
diff --git a/build.gradle b/build.gradle
29-
diff --git a/build.gradle b/build.gradle
3011
index 21893a7..faf7dff 100644
3112
--- a/build.gradle
3213
+++ b/build.gradle
33-
@@ -2,6 +2,7 @@ import io.spring.gradle.IncludeRepoTask
34-
14+
@@ -4,6 +4,7 @@ import trang.RncToXsd
3515
buildscript {
3616
dependencies {
17+
classpath libs.io.spring.javaformat.spring.javaformat.gradle.plugin
3718
+ classpath "gradle.plugin.com.github.johnrengelman:shadow:7.1.2"
38-
classpath "io.spring.javaformat:spring-javaformat-gradle-plugin:$springJavaformatVersion"
39-
classpath 'io.spring.nohttp:nohttp-gradle:0.0.10'
40-
classpath "io.freefair.gradle:aspectj-plugin:6.5.1"
41-
@@ -14,6 +15,7 @@ buildscript {
42-
}
19+
classpath libs.io.spring.nohttp.nohttp.gradle
20+
classpath libs.io.freefair.gradle.aspectj.plugin
21+
classpath libs.org.jetbrains.kotlin.kotlin.gradle.plugin
22+
@@ -18,6 +19,7 @@ plugins {
23+
alias(libs.plugins.org.gradle.wrapper.upgrade)
4324
}
4425

4526
+apply plugin: 'com.github.johnrengelman.shadow'
4627
apply plugin: 'io.spring.nohttp'
4728
apply plugin: 'locks'
48-
apply plugin: 's101'
29+
apply plugin: 'io.spring.convention.root'
4930
diff --git a/config/spring-security-config.gradle b/config/spring-security-config.gradle
5031
index 7818f34..4ef9150 100644
5132
--- a/config/spring-security-config.gradle
5233
+++ b/config/spring-security-config.gradle
5334
@@ -1,5 +1,6 @@
54-
import org.jetbrains.kotlin.gradle.tasks.KotlinCompile
35+
import org.springframework.gradle.xsd.CreateVersionlessXsdTask
36+
import trang.RncToXsd
5537

5638
+apply plugin: 'com.github.johnrengelman.shadow'
5739
apply plugin: 'io.spring.convention.spring-module'
5840
apply plugin: 'trang'
59-
apply plugin: 'kotlin'
6041
diff --git a/core/spring-security-core.gradle b/core/spring-security-core.gradle
6142
index 2968d3d..9a1be67 100644
6243
--- a/core/spring-security-core.gradle
6344
+++ b/core/spring-security-core.gradle
64-
@@ -1,5 +1,6 @@
65-
import java.util.concurrent.Callable
66-
45+
@@ -3,6 +3,7 @@ import java.util.concurrent.Callable
46+
plugins {
47+
id 'security-nullability'
48+
}
6749
+apply plugin: 'com.github.johnrengelman.shadow'
68-
apply plugin: 'io.spring.convention.spring-module'
6950

70-
dependencies {
51+
apply plugin: 'io.spring.convention.spring-module'
52+
apply plugin: 'security-kotlin'
7153
diff --git a/data/spring-security-data.gradle b/data/spring-security-data.gradle
7254
index 3e915ef..1b4d55b 100644
7355
--- a/data/spring-security-data.gradle
7456
+++ b/data/spring-security-data.gradle
75-
@@ -1,3 +1,4 @@
57+
@@ -2,6 +2,7 @@ plugins {
58+
id 'security-nullability'
59+
}
60+
7661
+apply plugin: 'com.github.johnrengelman.shadow'
7762
apply plugin: 'io.spring.convention.spring-module'
7863

@@ -81,15 +66,15 @@ diff --git a/dependencies/spring-security-dependencies.gradle b/dependencies/spr
8166
index fb306f6..b27cd44 100644
8267
--- a/dependencies/spring-security-dependencies.gradle
8368
+++ b/dependencies/spring-security-dependencies.gradle
84-
@@ -6,6 +6,8 @@ javaPlatform {
69+
@@ -4,6 +4,8 @@ plugins {
70+
javaPlatform {
8571
allowDependencies()
8672
}
87-
88-
+apply plugin: "com.github.johnrengelman.shadow"
8973
+
74+
+apply plugin: "com.github.johnrengelman.shadow"
75+
9076
dependencies {
91-
api platform("org.springframework:spring-framework-bom:$springFrameworkVersion")
92-
api platform("io.projectreactor:reactor-bom:$reactorVersion")
77+
if (project.hasProperty("isOverrideVersionCatalog")) {
9378
diff --git a/ldap/spring-security-ldap.gradle b/ldap/spring-security-ldap.gradle
9479
index c4f6c08..39023ed 100644
9580
--- a/ldap/spring-security-ldap.gradle
@@ -105,17 +90,29 @@ index c4f6c08..39023ed 100644
10590
optional 'ldapsdk:ldapsdk'
10691
- optional "com.unboundid:unboundid-ldapsdk"
10792
+ api "com.unboundid:unboundid-ldapsdk"
108-
optional "org.apache.directory.server:apacheds-core"
109-
optional "org.apache.directory.server:apacheds-core-entry"
110-
optional "org.apache.directory.server:apacheds-protocol-shared"
93+
optional 'tools.jackson.core:jackson-databind'
94+
api ('org.springframework.ldap:spring-ldap-core') {
95+
exclude(group: 'commons-logging', module: 'commons-logging')
11196
diff --git a/messaging/spring-security-messaging.gradle b/messaging/spring-security-messaging.gradle
11297
index 64435e6..9f8526f 100644
11398
--- a/messaging/spring-security-messaging.gradle
11499
+++ b/messaging/spring-security-messaging.gradle
115-
@@ -1,3 +1,4 @@
100+
@@ -2,6 +2,7 @@ plugins {
101+
id 'security-nullability'
102+
}
103+
116104
+apply plugin: 'com.github.johnrengelman.shadow'
117105
apply plugin: 'io.spring.convention.spring-module'
118106

107+
dependencies {
108+
diff --git a/oauth2/oauth2-client/spring-security-oauth2-client.gradle b/oauth2/oauth2-client/spring-security-oauth2-client.gradle
109+
index 0666a90..94c14cd 100644
110+
--- a/oauth2/oauth2-client/spring-security-oauth2-client.gradle
111+
+++ b/oauth2/oauth2-client/spring-security-oauth2-client.gradle
112+
@@ -1,3 +1,4 @@
113+
+apply plugin: "com.github.johnrengelman.shadow"
114+
apply plugin: 'io.spring.convention.spring-module'
115+
119116
dependencies {
120117
diff --git a/oauth2/oauth2-core/spring-security-oauth2-core.gradle b/oauth2/oauth2-core/spring-security-oauth2-core.gradle
121118
index 9fb4449..101532c 100644
@@ -125,12 +122,24 @@ index 9fb4449..101532c 100644
125122
+apply plugin: 'com.github.johnrengelman.shadow'
126123
apply plugin: 'io.spring.convention.spring-module'
127124

125+
dependencies {
126+
diff --git a/oauth2/oauth2-jose/spring-security-oauth2-jose.gradle b/oauth2/oauth2-jose/spring-security-oauth2-jose.gradle
127+
index 8290b85..c177be4 100644
128+
--- a/oauth2/oauth2-jose/spring-security-oauth2-jose.gradle
129+
+++ b/oauth2/oauth2-jose/spring-security-oauth2-jose.gradle
130+
@@ -1,3 +1,4 @@
131+
+apply plugin: "com.github.johnrengelman.shadow"
132+
apply plugin: 'io.spring.convention.spring-module'
133+
128134
dependencies {
129135
diff --git a/test/spring-security-test.gradle b/test/spring-security-test.gradle
130136
index 92b3868..b24d835 100644
131137
--- a/test/spring-security-test.gradle
132138
+++ b/test/spring-security-test.gradle
133-
@@ -1,3 +1,4 @@
139+
@@ -2,6 +2,7 @@ plugins {
140+
id 'security-nullability'
141+
}
142+
134143
+apply plugin: "com.github.johnrengelman.shadow"
135144
apply plugin: 'io.spring.convention.spring-module'
136145

@@ -139,14 +148,17 @@ diff --git a/web/spring-security-web.gradle b/web/spring-security-web.gradle
139148
index ca63924..45aea6f 100644
140149
--- a/web/spring-security-web.gradle
141150
+++ b/web/spring-security-web.gradle
142-
@@ -1,3 +1,4 @@
151+
@@ -2,6 +2,7 @@ plugins {
152+
id 'security-nullability'
153+
}
154+
143155
+apply plugin: 'com.github.johnrengelman.shadow'
144156
apply plugin: 'io.spring.convention.spring-module'
145157

146-
dependencies {
147-
@@ -17,7 +18,7 @@ dependencies {
148-
optional 'org.springframework:spring-webflux'
149-
optional 'org.springframework:spring-webmvc'
158+
configurations {
159+
@@ -50,7 +51,7 @@ dependencies {
160+
optional 'tools.jackson.core:jackson-databind'
161+
optional libs.webauthn4j.core
150162

151163
- provided 'jakarta.servlet:jakarta.servlet-api'
152164
+ api 'jakarta.servlet:jakarta.servlet-api'

projects/spring-security/oauth2-jose/NimbusJwtEncoderFuzzer.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626

2727
import com.nimbusds.jose.jwk.JWK;
2828
import com.nimbusds.jose.jwk.KeyType;
29+
import com.nimbusds.jose.jwk.KeyRevocation;
2930
import com.nimbusds.jose.jwk.JWKSet;
3031
import com.nimbusds.jose.proc.SecurityContext;
3132
import com.nimbusds.jose.jwk.source.JWKSource;
@@ -115,6 +116,12 @@ public int size() {
115116
// TODO Auto-generated method stub
116117
return 0;
117118
}
119+
120+
@Override
121+
public JWK toRevokedJWK(KeyRevocation keyRevocation) {
122+
// TODO Auto-generated method stub
123+
return null;
124+
}
118125
}
119126

120127
}

0 commit comments

Comments
 (0)