Skip to content

Commit f1a838c

Browse files
apronchenkovcopybara-github
authored andcommitted
Precompute aux-policy name and options in ExprOperatorSignature
Motivation: Simplify lookups based on the aux-policy name. PiperOrigin-RevId: 856376927 Change-Id: Ia83036749c1ed85364e9f6041dc9f3b21a08766c
1 parent ee365a3 commit f1a838c

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

py/koladata/operators/py_unified_binding_policy.cc

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -89,14 +89,13 @@ using ::arolla::python::UnsafeUnwrapPyQValue;
8989
bool ExtractUnifiedPolicyOpts(const ExprOperatorSignature& signature,
9090
absl::string_view& result_binding_options,
9191
absl::string_view& result_boxing_options) {
92-
absl::string_view string = signature.aux_policy;
93-
if (!absl::ConsumePrefix(&string, kUnifiedPolicy) ||
94-
!absl::ConsumePrefix(&string, ":")) {
92+
if (signature.aux_policy_name != kUnifiedPolicy) {
9593
return PyErr_Format(
9694
PyExc_RuntimeError,
9795
"UnifiedBindingPolicy: unexpected binding policy name: %s",
98-
absl::Utf8SafeCHexEscape(signature.aux_policy).c_str());
96+
absl::Utf8SafeCHexEscape(signature.aux_policy_name).c_str());
9997
}
98+
absl::string_view string = signature.aux_policy_options;
10099
const auto idx = string.find(':');
101100
if (idx != absl::string_view::npos) {
102101
result_binding_options = string.substr(0, idx);

0 commit comments

Comments
 (0)