Skip to content

Commit 9da4389

Browse files
cpovirkCaliper Team
authored andcommitted
Rip out maven-release-plugin configuration.
As best I can tell, this configuration has never offered anything over what we get by default from `maven-deploy-plugin` (or its modern replacement, `central-publishing-maven-plugin`). I wouldn't rule out that we've never actually used `maven-release-plugin` at all for our releases: We may have been running `mvn deploy` instead of `mvn release:prepare` + `mvn release:perform`. (Certainly the script that we use for most of our projects uses `mvn deploy` directly.) I looked into the `-DenableCiProfile` bit, and as best I can tell, we've never defined a property by that name, nor is it a standard part of Maven. I do see one defined in [the `pom.xml` for `maven-surefire-plugin`](https://central.sonatype.com/artifact/org.apache.maven.plugins/maven-surefire-plugin/3.1.0), but our setting the flag would have no effect on our _usage_ of Surefire; the setting there would matter only when _building_ Surefire. Anyway, this configuration dates back to cl/30835352 (Caliper) and cl/51674256 (Compile-Testing). I can't fully rule out that it's doing _something_ for _some_ process that _someone_ uses, but I'm highly comfortable removing it. We can always roll back if we somehow see trouble, and I don't expect any trouble in the first place. RELNOTES=n/a PiperOrigin-RevId: 831002527
1 parent 9bb2a56 commit 9da4389

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

pom.xml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -237,13 +237,6 @@
237237
<workspace>../eclipse-ws/</workspace>
238238
</configuration>
239239
</plugin>
240-
<plugin>
241-
<artifactId>maven-release-plugin</artifactId>
242-
<version>3.2.0</version>
243-
<configuration>
244-
<arguments>-DenableCiProfile=true</arguments>
245-
</configuration>
246-
</plugin>
247240
<plugin>
248241
<artifactId>maven-source-plugin</artifactId>
249242
<version>${maven-source-plugin.version}</version>

0 commit comments

Comments
 (0)