Skip to content

Commit af39998

Browse files
committed
Add more description to GetClientInfo
1 parent c864da0 commit af39998

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

ctx.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,8 +104,9 @@ type TLSHandler struct {
104104
clientHelloInfo *tls.ClientHelloInfo
105105
}
106106

107-
// GetClientInfo Callback function to set CHI
108-
// TODO: Why is this a getter which sets stuff?
107+
// GetClientInfo Callback function to set ClientHelloInfo
108+
// Must comply with the method structure of https://cs.opensource.google/go/go/+/refs/tags/go1.20:src/crypto/tls/common.go;l=554-563
109+
// Since we overlay the method of the tls config in the listener method
109110
func (t *TLSHandler) GetClientInfo(info *tls.ClientHelloInfo) (*tls.Certificate, error) {
110111
t.clientHelloInfo = info
111112
return nil, nil //nolint:nilnil // Not returning anything useful here is probably fine

0 commit comments

Comments
 (0)