[rust-guard] Rust Guard: Remove stale `#[allow(dead_code)]` in backend.rs and eliminate superseded `is_forked_pull_request_with_callback`

[github-actions]

🦀 Rust Guard Improvement Report

Improvement 1: Remove Two Stale #[allow(dead_code)] Annotations in backend.rs

Category: Dead Code
File(s): guards/github-guard/rust-guard/src/labels/backend.rs
Effort: Small (< 5 min)
Risk: Low

Problem

Two #[allow(dead_code)] annotations in backend.rs suppress compiler warnings for functions that are actually called in production. The annotations are stale — likely left over from an earlier time when these functions were not yet wired up.

• is_repo_private (line 56): Called by tool_rules.rs (×2), response_items.rs (×3), helpers.rs (×2), and response_paths.rs (×3) — 10 production call sites.
• get_issue_author_association (line 405): Called by helpers.rs:1119 to enrich issue integrity when author_association is absent from list responses.

These stale #[allow(dead_code)] attributes are misleading — they suggest the functions are unused, making a reviewer question whether they should be removed.

Suggested Change

Remove the two #[allow(dead_code)] lines only.

Before

/// Check whether a repository is private using the backend MCP server.
// ...
#[allow(dead_code)]           // ← stale: called in 10 places
pub fn is_repo_private(owner: &str, repo: &str) -> Option(bool) {
    is_repo_private_with_callback(crate::invoke_backend, owner, repo)
}

// ...

#[allow(dead_code)]           // ← stale: called in helpers.rs:1119
pub fn get_issue_author_association(owner: &str, repo: &str, issue_number: &str) -> Option(String) {
    get_issue_author_association_with_callback(crate::invoke_backend, owner, repo, issue_number)
}

After

/// Check whether a repository is private using the backend MCP server.
// ...
pub fn is_repo_private(owner: &str, repo: &str) -> Option(bool) {
    is_repo_private_with_callback(crate::invoke_backend, owner, repo)
}

// ...

pub fn get_issue_author_association(owner: &str, repo: &str, issue_number: &str) -> Option(String) {
    get_issue_author_association_with_callback(crate::invoke_backend, owner, repo, issue_number)
}

Why This Matters

Stale #[allow(dead_code)] annotations create noise that desensitises reviewers to real dead code warnings. They make it harder to identify functions that are genuinely unused (like is_owner or is_forked_pull_request_with_callback below). Removing them lets the compiler enforce correctness and makes code reviews easier.

---

Improvement 2: Remove is_forked_pull_request_with_callback (Superseded by get_pull_request_facts_with_callback)

Category: Dead Code
File(s): guards/github-guard/rust-guard/src/labels/backend.rs
Effort: Medium (15–20 min)
Risk: Low

Problem

is_forked_pull_request_with_callback (lines 215–282) is a standalone function that checks whether a PR is from a fork by calling pull_request_read. It:

1. Has #[allow(dead_code)] — it has zero production call sites.
2. Is only called from 3 unit tests within the same file (lines 727–744).
3. Duplicates a subset of the logic already inside get_pull_request_facts_with_callback (lines 285–357), which also extracts is_forked (stored as PullRequestFacts.is_forked) alongside author_association, author_login, and is_merged.

The _with_callback pattern exists to allow injection of a mock backend in tests. get_pull_request_facts_with_callback already follows this same pattern and its result includes is_forked. There is no production wrapper (is_forked_pull_request) that calls it — making it a dead-end function.

Suggested Change

1. Delete is_forked_pull_request_with_callback (lines 215–282).
2. Convert the 3 tests that call it into tests on get_pull_request_facts_with_callback, verifying facts.is_forked — this preserves the test coverage.

Before

/// Determine whether a pull request is from a fork.
// ...
#[allow(dead_code)]
pub fn is_forked_pull_request_with_callback(
    callback: GithubMcpCallback,
    owner: &str,
    repo: &str,
    pull_number: &str,
) -> Option(bool) {
    // ... ~60 lines fetching PR and extracting base/head full_name ...
}

// In tests:
#[test]
fn test_is_forked_pull_request_direct() {
    let result =
        is_forked_pull_request_with_callback(direct_pr_callback, "owner", "repo", "123");
    assert_eq!(result, Some(false));
}

#[test]
fn test_is_forked_pull_request_forked() {
    let result = is_forked_pull_request_with_callback(fork_pr_callback, "owner", "repo", "123");
    assert_eq!(result, Some(true));
}

#[test]
fn test_is_forked_pull_request_wrapped_response() {
    let result =
        is_forked_pull_request_with_callback(wrapped_fork_pr_callback, "owner", "repo", "123");
    assert_eq!(result, Some(true));
}

After

// is_forked_pull_request_with_callback deleted entirely.

// Tests migrated to get_pull_request_facts_with_callback:
#[test]
fn test_pull_request_facts_direct_pr_not_forked() {
    let facts = get_pull_request_facts_with_callback(direct_pr_callback, "owner", "repo", "123");
    assert_eq!(facts.map(|f| f.is_forked), Some(Some(false)));
}

#[test]
fn test_pull_request_facts_forked_pr() {
    let facts = get_pull_request_facts_with_callback(fork_pr_callback, "owner", "repo", "123");
    assert_eq!(facts.map(|f| f.is_forked), Some(Some(true)));
}

#[test]
fn test_pull_request_facts_wrapped_response_forked() {
    let facts =
        get_pull_request_facts_with_callback(wrapped_fork_pr_callback, "owner", "repo", "123");
    assert_eq!(facts.map(|f| f.is_forked), Some(Some(true)));
}

Why This Matters

• Removes ~70 lines of dead code (function + tests), reducing maintenance surface.
• Migrating the fork-detection tests to get_pull_request_facts_with_callback gives that function — the one that's actually used in production — its first direct unit tests, which is a net coverage gain.
• Follows the single-function principle: the PR lookup is done once (get_pull_request_facts), not via two independent functions that make the same network call.

---

Codebase Health Summary

• Total Rust files: 10
• Total lines: 8,510
• Areas analyzed: backend.rs, helpers.rs, tool_rules.rs, response_items.rs, response_paths.rs, mod.rs, constants.rs, lib.rs, permissions.rs, tools.rs
• Areas with no further improvements: constants.rs, response_items.rs, response_paths.rs

---

Generated by Rust Guard Improver • Run: §23430373144

Generated by Rust Guard Improver · ◷

• expires on Mar 30, 2026, 9:38 AM UTC

[github-actions]

🤖 This is an automated response from Repo Assist.

Both improvements in this issue are accurate and well-scoped:

Improvement 1 (Remove stale #[allow(dead_code)] on is_repo_private and get_issue_author_association)
This is a straightforward cleanup. Both functions are actively used in production code — the annotations are indeed misleading. Removing them lets the compiler enforce correctness going forward and makes it easier to spot genuinely unused functions (like is_owner or is_forked_pull_request_with_callback below them).

Improvement 2 (Delete is_forked_pull_request_with_callback)
This is the more impactful change. The function has zero production call sites and its functionality is already covered by get_pull_request_facts_with_callback (which also extracts is_forked). The proposed test migration preserves coverage while giving get_pull_request_facts_with_callback its first direct unit tests — a net gain.

Note: PR #2334 already addressed the double extract_repo_info call and removed stale dead_code attributes in backend.rs. You may want to check whether that PR already covers Improvement 1 before creating a new PR for this issue.

Generated by Repo Assist · ◷

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/repo-assist.md@851905c06e905bf362a9f6cc54f912e3df747d55

Warning

⚠️ Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

• proxy.golang.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "proxy.golang.org"

See Network Configuration for more information.

[github-actions]

🤖 This is an automated response from Repo Assist.

I've created a fix PR for Improvement 1 (branch repo-assist/fix-issue-2369-remove-stale-dead-code-backend) that removes the three stale #[allow(dead_code)] annotations from backend.rs:

• is_repo_private — actively called at 10 production sites
• get_issue_author_association_with_callback — called by get_issue_author_association
• get_issue_author_association — called at helpers.rs:1172

The remaining #[allow(dead_code)] on is_forked_pull_request_with_callback is intentionally kept since that function has zero production call sites and is only exercised by tests (Improvement 2 from this issue is a separate, larger refactoring).

cargo check runs clean with the changes applied. The PR will appear linked here once processed.

Generated by Repo Assist

Generated by Repo Assist · ◷

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/repo-assist.md@851905c06e905bf362a9f6cc54f912e3df747d55