Skip to content

copilot --acp responses return incorrect tool IDs when requesting permissions #989

@richardpark-msft

Description

@richardpark-msft

Describe the bug

Copilot, in --acp mode, sends "tool permission requests", to the client, with a tool call ID set to something more akin to a title (ie: shell-permission) instead of something like the ID (ex: 'call_GN0nGMSBTdQOrviuem2vgxtg').

This doesn't happen with other tool call updates or even the initial tool call, only when requesting permissions.

Affected version

0.0.382 Commit: 18bf0ae

Steps to reproduce the behavior

  1. Run copilot --acp
  2. Connect, and send a request that will cause a shell execution to occur.
  3. Observe that the ToolCall updates all pass a properly formatted ToolCallId but the "request permission" request uses a non-unique friendly ID (ie: 'shell-permission')

Expected behavior

The same tool call ID used to report the initial 'Pending' ToolCall should be used in all subsequent messages pertaining to that tool call.

Additional context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions