kudos email QA - 2018/10/15

[owocki]

1. kudos emails need to have a png of the specific kudos that was sent in it per https://github.com/mbeacom/kudos/pull/41 , thety still have the ? kudos in there.. they need to have the actual kudos that was sent in there.
2. new_kudos() email is not actually wired up to send from anywhere
3. kudos_mint() email is not actualy wired up anywhere.. ideally i'd like to be able to send this from an admin form (for now), manually, to whomever requested a kudos. inputs for the form: kudos id, to_email address
4. kudos_mkt email is not wired up anywhere.. but thats okay bc i think were gonna market this in the roundup email

[jasonrhaas]

A new kudos is is sent via the render_kudos_email function in the last step fo the kudos send. That particular new_kudos() function just exists to be able to preview the email.

Adding to this ticket, I still need to add a little of logic for this ticket -- #78

 KUDOS SENT EMAIL
 KUDOS ACCEPTED EMAIL

I know you said not to worry about the KUDOS ACCEPTED EMAIL right now, but I think we should have the KUDOS SENT email. Basically its the same template just need an if statement in there to tell if its the sender or receiver.

[owocki]

@jasonrhaas

A new kudos is is sent via the render_kudos_email function in the last step fo the kudos send. That particular new_kudos() function just exists to be able to preview the email.

render_kudos_email doesnt send the email, it just returns the HTML which could send the email if it was passed into the send_mail function

also, i dont see render_kudos_email even called in the last step of the send function

but I think we should have the KUDOS SENT email

i strongly agree