From eecaf1d53ced235587c88b825bb1c35ec6ef5324 Mon Sep 17 00:00:00 2001 From: ghiscoding Date: Sat, 10 Jan 2026 17:14:13 -0500 Subject: [PATCH 1/3] fix: double-clicking a checkmark icon should keep current cell selection --- packages/common/src/styles/slickgrid-icons.scss | 2 +- packages/common/src/styles/svg-utilities.scss | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/common/src/styles/slickgrid-icons.scss b/packages/common/src/styles/slickgrid-icons.scss index ef25b7d9c..348be291b 100644 --- a/packages/common/src/styles/slickgrid-icons.scss +++ b/packages/common/src/styles/slickgrid-icons.scss @@ -953,7 +953,7 @@ ); .mdi { - display: inline-block; + display: inline-flex; align-items: center; background-color: currentColor; font-size: v.$slick-icon-font-size; diff --git a/packages/common/src/styles/svg-utilities.scss b/packages/common/src/styles/svg-utilities.scss index c51f8f3c3..2a7e5df15 100644 --- a/packages/common/src/styles/svg-utilities.scss +++ b/packages/common/src/styles/svg-utilities.scss @@ -20,7 +20,7 @@ $svg-icon-vertical-align: bottom !default; // we will also use the name to create a CSS variable so that user could override any of the icon // by providing the full url string without needing else since it was already created @mixin generateSvgStyle($cssVarName, $svgPath) { - --#{$cssVarName}: url('data:image/svg+xml;utf8,%3Csvg viewBox="0 0 24 24" display="inline-block" height="1em" width="1em" vertical-align="text-bottom" xmlns="http://www.w3.org/2000/svg" %3E%3Cpath fill="currentColor" d="#{$svgPath}"/%3E%3C/svg%3E'); + --#{$cssVarName}: url('data:image/svg+xml;utf8,%3Csvg viewBox="0 0 24 24" height="1em" width="1em" vertical-align="text-bottom" xmlns="http://www.w3.org/2000/svg" %3E%3Cpath fill="currentColor" d="#{$svgPath}"/%3E%3C/svg%3E'); -webkit-mask: var(--#{$cssVarName}) no-repeat; mask: var(--#{$cssVarName}) no-repeat; mask-size: 100% 100%; From d32afb789ab9c684820850860c1d02ce95a29eb9 Mon Sep 17 00:00:00 2001 From: "Ghislain B." Date: Mon, 12 Jan 2026 09:46:19 -0500 Subject: [PATCH 2/3] chore: use `user-select: none` instead --- packages/common/src/styles/slickgrid-icons.scss | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/common/src/styles/slickgrid-icons.scss b/packages/common/src/styles/slickgrid-icons.scss index 348be291b..ee9d6ad3c 100644 --- a/packages/common/src/styles/slickgrid-icons.scss +++ b/packages/common/src/styles/slickgrid-icons.scss @@ -953,10 +953,11 @@ ); .mdi { - display: inline-flex; + display: inline-block; align-items: center; background-color: currentColor; font-size: v.$slick-icon-font-size; + user-select: none; width: 1em; height: 1em; From bbc6691a845390b8a8f68c75f29dbf37091a32fd Mon Sep 17 00:00:00 2001 From: "Ghislain B." Date: Mon, 12 Jan 2026 11:12:07 -0500 Subject: [PATCH 3/3] chore: revert to inline-flex --- packages/common/src/styles/slickgrid-icons.scss | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/common/src/styles/slickgrid-icons.scss b/packages/common/src/styles/slickgrid-icons.scss index ee9d6ad3c..348be291b 100644 --- a/packages/common/src/styles/slickgrid-icons.scss +++ b/packages/common/src/styles/slickgrid-icons.scss @@ -953,11 +953,10 @@ ); .mdi { - display: inline-block; + display: inline-flex; align-items: center; background-color: currentColor; font-size: v.$slick-icon-font-size; - user-select: none; width: 1em; height: 1em;