Cloudflare Secrets Store and wrangler bindings, withSentry callback is syncronous

[vv-z84]

Is there an existing issue for this?

• I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues
• I have reviewed the documentation https://docs.sentry.io/
• I am using the latest SDK release https://github.com/getsentry/sentry-javascript/releases

How do you use Sentry?

Sentry Saas (sentry.io)

Which SDK are you using?

@sentry/cloudflare

SDK Version

10.45.0

Framework Version

wrangler 4.75.0

Link to Sentry event

No response

Reproduction Example/SDK Setup

export default Sentry.withSentry(
  (env: Env) => ({
    dsn: env.SENTRY_DSN.get(), // SENTRY_DSN is a SecretsStoreSecret, .get() returns a Promise<string>
    tracesSampleRate: 1.0,
    enableLogs: true,
    sendDefaultPii: true,
  }),
  {
    fetch: app.fetch
  } satisfies ExportedHandler<Env>,
);

Sentry.withSentry() doesn't handle promises. link

export function withSentry<
  Env = typeof env,
  QueueHandlerMessage = unknown,
  CfHostMetadata = unknown,
  T extends ExportedHandler<Env, QueueHandlerMessage, CfHostMetadata> = ExportedHandler<
    Env,
    QueueHandlerMessage,
    CfHostMetadata
  >,
>(optionsCallback: (env: Env) => CloudflareOptions | undefined, handler: T): T {
  setAsyncLocalStorageAsyncContextStrategy();

  try {
    instrumentExportedHandlerFetch(handler, optionsCallback);
    instrumentHonoErrorHandler(handler);
    instrumentExportedHandlerScheduled(handler, optionsCallback);
    instrumentExportedHandlerEmail(handler, optionsCallback);
    instrumentExportedHandlerQueue(handler, optionsCallback);
    instrumentExportedHandlerTail(handler, optionsCallback);
    // This is here because Miniflare sometimes cannot get instrumented
  } catch {
    // Do not console anything here, we don't want to spam the console with errors
  }

  return handler;
}

Steps to Reproduce

Use Sentry in a Cloudflare Worker, in my case with Hono, where you need to use @sentry/cloudflare and export Sentry.withSentry() returned handler, but you need to use Cloudflare Secret Store bindings.

Expected Result

Get the SENTRY_DSN string value from the secret store.

Actual Result

Additional Context

No response

Priority

_{React with 👍 to help prioritize this issue. Please use comments to provide useful context, avoiding +1 or me too, to help us triage it.}

[linear-code]

JS-1971

[vv-z84]

I forgot to add in the issue, but for convenience this is the link of Cloudflare Secrets Store: https://developers.cloudflare.com/secrets-store/integrations/workers/

[Lms24]

Hey, thanks for writing in! I'm curious, why do you need to store the DSN as a secret? We don't classify the DSN as a secret value. Can you set it as an environment variable?

Not fully opposed to allowing an async callback on first glance but I wonder if it is necessary.

[vv-z84]

hi @Lms24 ! I'm new to cloudflare stuff and I noticed some time after creating the issue that I didn't pay attention on environment variables (doc)!

so the DSN is better stored as worker env var (text or secret) and not account-wide secret as it would be in secret store!

my problem is solved! But maybe having the callback as async can be useful for someone? not sure.

thank you for checking my issue!

[Lms24]

Thanks for getting back to me! I'll close this for the time being. If anyone has another use case where they need the callback to be async, we can think about adding this. Though I cannot promise we would do it, because SDK initialization and async don't work well together.

Anyone reading and still wanting this change, please ping me so that I can reopen the issue.