Skip to content

Commit 4fa118f

Browse files
authored
Fix/m5stack core s3 dependencies (#10)
* switch to noglib version * fix serial monitor for m5stack * add target specification to board definition * update SDL depdendency * add m5stack back to tests * fail test in case of reboot
1 parent 0e92abb commit 4fa118f

File tree

8 files changed

+31
-34
lines changed

8 files changed

+31
-34
lines changed

.github/workflows/test.yml

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,7 @@ jobs:
1313
runs-on: ubuntu-latest
1414
strategy:
1515
matrix:
16-
board: [esp-box-3, esp-box, esp32_p4_function_ev_board]
17-
# M5 Stack CoreS3 - test disabled, because mapping of UART is not working in Wokwi
18-
#board: [esp-box-3, esp-box, m5stack_core_s3, esp32_p4_function_ev_board]
16+
board: [esp-box-3, esp-box, m5stack_core_s3, esp32_p4_function_ev_board]
1917
fail-fast: false
2018

2119
steps:
@@ -36,9 +34,9 @@ jobs:
3634
token: ${{ secrets.WOKWI_CLI_TOKEN }}
3735
path: boards/${{ matrix.board }}
3836
elf: build.${{ matrix.board }}/${{ github.event.inputs.prefix }}-${{ matrix.board }}.bin
39-
timeout: 30000
37+
timeout: 20000
4038
expect_text: 'Entering main loop...'
41-
fail_text: 'Error'
39+
fail_text: 'Rebooting...'
4240
serial_log_file: 'wokwi-logs-${{ matrix.board }}.txt'
4341

4442
- name: Upload Wokwi Logs

README.md

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,34 +26,33 @@ Working parts:
2626

2727
## Build
2828

29-
```
29+
```shell
3030
git clone [email protected]:georgik/esp32-sdl3-test.git
3131
cd esp32-sdl3-test
3232

33-
idf.py @boards/esp-box-3.cfg set-target esp32-s3
3433
idf.py @boards/esp-box-3.cfg build
3534
```
3635

3736
### Other boards
3837

3938
- ESP32-S3-BOX-3
4039
```shell
41-
idf.py @boards/esp-box-3.cfg reconfigure
40+
idf.py @boards/esp-box-3.cfg build
4241
```
4342

4443
- ESP32-S3-BOX (prior Dec. 2023)
4544
```shell
46-
idf.py @boards/esp-box.cfg reconfigure
45+
idf.py @boards/esp-box.cfg build
4746
```
4847

4948
- ESP32-P4
5049
```shell
51-
idf.py @boards/esp32_p4_function_ev_board.cfg reconfigure
50+
idf.py @boards/esp32_p4_function_ev_board.cfg build
5251
```
5352

5453
- M5Stack-CoreS3
5554
```shell
56-
idf.py @boards/m5stack_core_s3.cfg reconfigure
55+
idf.py @boards/m5stack_core_s3.cfg build
5756
```
5857

5958
## Notes

boards/esp-box-3.cfg

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
-DSDKCONFIG_DEFAULTS="sdkconfig.defaults.esp-box-3;sdkconfig.defaults" -DBUILD_BOARD="esp-box-3" -B build.esp-box-3
1+
-DSDKCONFIG_DEFAULTS="sdkconfig.defaults.esp-box-3;sdkconfig.defaults" -DBUILD_BOARD="esp-box-3" -DIDF_TARGET=esp32s3 -B build.esp-box-3

boards/esp-box.cfg

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
-DSDKCONFIG_DEFAULTS="sdkconfig.defaults.esp-box;sdkconfig.defaults" -DBUILD_BOARD="esp-box" -B build.esp-box
1+
-DSDKCONFIG_DEFAULTS="sdkconfig.defaults.esp-box;sdkconfig.defaults" -DBUILD_BOARD="esp-box" -DIDF_TARGET=esp32s3 -B build.esp-box
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
-DSDKCONFIG_DEFAULTS="sdkconfig.defaults.esp32_p4_function_ev_board;sdkconfig.defaults" -DBUILD_BOARD="esp32_p4_function_ev_board_noglib" -B build.esp32_p4_function_ev_board
1+
-DSDKCONFIG_DEFAULTS="sdkconfig.defaults.esp32_p4_function_ev_board;sdkconfig.defaults" -DBUILD_BOARD="esp32_p4_function_ev_board_noglib" -DIDF_TARGET=esp32p4 -B build.esp32_p4_function_ev_board

boards/m5stack_core_s3.cfg

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
-DSDKCONFIG_DEFAULTS="sdkconfig.defaults.m5stack_core_s3;sdkconfig.defaults" -DBUILD_BOARD="m5stack_core_s3" -B build.m5stack_core_s3
1+
-DSDKCONFIG_DEFAULTS="sdkconfig.defaults.m5stack_core_s3;sdkconfig.defaults" -DBUILD_BOARD="m5stack_core_s3_noglib" -DIDF_TARGET=esp32s3 -B build.m5stack_core_s3

boards/m5stack_core_s3/diagram.json

Lines changed: 6 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -3,21 +3,12 @@
33
"author": "Uri Shaked",
44
"editor": "wokwi",
55
"parts": [
6-
{
7-
"type": "board-m5stack-core-s3",
8-
"id": "esp"
9-
}
6+
{ "type": "board-m5stack-core-s3", "id": "esp", "top": 0, "left": 0, "attrs": {} }
107
],
118
"connections": [
12-
[
13-
"esp:TX",
14-
"$serialMonitor:RX",
15-
""
16-
],
17-
[
18-
"esp:RX",
19-
"$serialMonitor:TX",
20-
""
21-
]
22-
]
9+
[ "esp:G43", "$serialMonitor:RX", "", [] ],
10+
[ "esp:G44", "$serialMonitor:TX", "", [] ]
11+
12+
],
13+
"dependencies": {}
2314
}

main/idf_component.yml

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ dependencies:
44
# espressif/freetype: "^2.13.0~3"
55
# espressif/esp-box: "^3.1.0~1"
66
joltwallet/littlefs: "==1.14.8"
7-
georgik/sdl: "^3.1.2~2"
7+
georgik/sdl: "^3.1.2~3"
88
# git: https://github.com/georgik/esp-idf-component-SDL.git
99
georgik/sdl_image: "^3.0.0~1"
1010
# git: https://github.com/georgik/esp-idf-component-SDL_image.git
@@ -20,14 +20,23 @@ dependencies:
2020
version: "^1.2.0"
2121
rules:
2222
- if: "${BUILD_BOARD} == esp-box-3"
23+
2324
espressif/esp-box:
2425
version: "3.1.0"
2526
rules:
2627
- if: "${BUILD_BOARD} == esp-box"
27-
espressif/m5stack_core_s3:
28-
version: "1.1.1"
28+
29+
espressif/m5stack_core_s3_noglib:
30+
version: "==1.1.1~1"
2931
rules:
30-
- if: "${BUILD_BOARD} == m5stack_core_s3"
32+
- if: "${BUILD_BOARD} == m5stack_core_s3_noglib"
33+
# Workaround for the conflict of I2C drivers in ESP-IDF 5.3+
34+
esp_codec_dev:
35+
public: true
36+
version: "==1.1.0"
37+
rules:
38+
- if: "${BUILD_BOARD} == m5stack_core_s3_noglib"
39+
3140
espressif/esp32_p4_function_ev_board_noglib:
3241
version: "3.0.1"
3342
rules:

0 commit comments

Comments
 (0)