test improvements

Author: gallayl

common/src/models/identity/roles.spec.ts

@@ -1,6 +1,5 @@
 import { describe, expect, it } from 'vitest'
 import { AVAILABLE_ROLES, getAllRoleDefinitions, getRoleDefinition } from './roles.js'
-import type { Roles } from './user.js'
 
 describe('roles', () => {
   describe('AVAILABLE_ROLES', () => {
@@ -30,86 +29,25 @@ describe('roles', () => {
       }
     })
 
-    it('should have correct metadata for admin role', () => {
-      expect(AVAILABLE_ROLES.admin).toEqual({
-        displayName: 'Application Admin',
-        description: 'Full system access including user management and all settings',
-      })
-    })
-
-    it('should have correct metadata for media-manager role', () => {
-      expect(AVAILABLE_ROLES['media-manager']).toEqual({
-        displayName: 'Media Manager',
-        description: 'Can manage movies, series, and encoding tasks',
-      })
-    })
-
-    it('should have correct metadata for viewer role', () => {
-      expect(AVAILABLE_ROLES.viewer).toEqual({
-        displayName: 'Viewer',
-        description: 'Can browse and watch media content',
-      })
-    })
-
-    it('should have correct metadata for iot-manager role', () => {
-      expect(AVAILABLE_ROLES['iot-manager']).toEqual({
-        displayName: 'IoT Manager',
-        description: 'Can manage IoT devices and their settings',
-      })
+    it.each([
+      ['admin', 'Application Admin', 'Full system access including user management and all settings'],
+      ['media-manager', 'Media Manager', 'Can manage movies, series, and encoding tasks'],
+      ['viewer', 'Viewer', 'Can browse and watch media content'],
+      ['iot-manager', 'IoT Manager', 'Can manage IoT devices and their settings'],
+    ] as const)('should have correct metadata for %s role', (role, displayName, description) => {
+      expect(AVAILABLE_ROLES[role]).toEqual({ displayName, description })
     })
   })
 
   describe('getRoleDefinition', () => {
-    it('should return correct definition for admin role', () => {
-      const definition = getRoleDefinition('admin')
-
-      expect(definition).toEqual({
-        name: 'admin',
-        displayName: 'Application Admin',
-        description: 'Full system access including user management and all settings',
-      })
-    })
-
-    it('should return correct definition for media-manager role', () => {
-      const definition = getRoleDefinition('media-manager')
-
-      expect(definition).toEqual({
-        name: 'media-manager',
-        displayName: 'Media Manager',
-        description: 'Can manage movies, series, and encoding tasks',
-      })
-    })
-
-    it('should return correct definition for viewer role', () => {
-      const definition = getRoleDefinition('viewer')
-
-      expect(definition).toEqual({
-        name: 'viewer',
-        displayName: 'Viewer',
-        description: 'Can browse and watch media content',
-      })
-    })
-
-    it('should return correct definition for iot-manager role', () => {
-      const definition = getRoleDefinition('iot-manager')
-
-      expect(definition).toEqual({
-        name: 'iot-manager',
-        displayName: 'IoT Manager',
-        description: 'Can manage IoT devices and their settings',
-      })
-    })
-
-    it('should include name, displayName, and description for each role', () => {
-      const roles: Array<Roles[number]> = ['admin', 'media-manager', 'viewer', 'iot-manager']
-
-      for (const roleName of roles) {
-        const definition = getRoleDefinition(roleName)
-
-        expect(definition.name).toBe(roleName)
-        expect(definition.displayName).toBeDefined()
-        expect(definition.description).toBeDefined()
-      }
+    it.each([
+      ['admin', 'Application Admin', 'Full system access including user management and all settings'],
+      ['media-manager', 'Media Manager', 'Can manage movies, series, and encoding tasks'],
+      ['viewer', 'Viewer', 'Can browse and watch media content'],
+      ['iot-manager', 'IoT Manager', 'Can manage IoT devices and their settings'],
+    ] as const)('should return correct definition for %s role', (name, displayName, description) => {
+      const definition = getRoleDefinition(name)
+      expect(definition).toEqual({ name, displayName, description })
     })
   })
 

e2e/user-management.spec.ts

@@ -198,7 +198,7 @@ test.describe('Role Editing', () => {
     const secondOption = await options.nth(1).getAttribute('value')
     expect(secondOption, 'Expected option to have a value').toBeTruthy()
 
-    await roleSelect.selectOption(secondOption!)
+    await roleSelect.selectOption(secondOption)
 
     // Verify a new role tag appears
     const roleTags = detailsPage.locator('role-tag')
@@ -222,7 +222,7 @@ test.describe('Role Editing', () => {
     const secondOption = await options.nth(1).getAttribute('value')
     expect(secondOption, 'Expected option to have a value').toBeTruthy()
 
-    await roleSelect.selectOption(secondOption!)
+    await roleSelect.selectOption(secondOption)
 
     // Save button should now be enabled
     await expect(saveButton).toBeEnabled()
@@ -266,7 +266,7 @@ test.describe('Role Editing', () => {
     const secondOption = await options.nth(1).getAttribute('value')
     expect(secondOption, 'Expected option to have a value').toBeTruthy()
 
-    await roleSelect.selectOption(secondOption!)
+    await roleSelect.selectOption(secondOption)
 
     // Verify Save is now enabled
     await expect(saveButton).toBeEnabled()
@@ -306,7 +306,7 @@ test.describe('Save Role Changes', () => {
     const secondOption = await options.nth(1).getAttribute('value')
     expect(secondOption, 'Expected option to have a value').toBeTruthy()
 
-    await roleSelect.selectOption(secondOption!)
+    await roleSelect.selectOption(secondOption)
 
     // Save changes
     await saveButton.click()