Skip to content

Commit 936a274

Browse files
authored
Merge pull request #32 from eksrvb/bugfix/pr-number-lenght
fixing branchname lenght + docs
2 parents 1a1ebc0 + 5b51d1a commit 936a274

File tree

4 files changed

+35
-11
lines changed

4 files changed

+35
-11
lines changed

docs/commands/getBuildInfos.md

Lines changed: 21 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,8 @@ Possible infos are: `patchLevel`, `pr`, `version`, `nextVersion`
3939

4040
```bash
4141
awesome-ci getBuildInfos -patchLevel feature -version 1.0.0
42-
# Output:
42+
43+
#### Info output:
4344
Pull Request: 17
4445
Current release version: 1.0.0
4546
Patch level: feature
@@ -49,4 +50,23 @@ Possible new release version: 1.1.0
4950
awesome-ci getBuildInfos -patchLevel feature -version 1.0.0 -format "pr,next_version"
5051
# Output:
5152
17,1.1.0
53+
```
54+
55+
### Special to github actions
56+
57+
With a github action, all available information is always set as environment variables.
58+
59+
```bash
60+
#### Setting Env variables:
61+
PR=17
62+
ORGA=eksrvb
63+
REPO=playground
64+
VERSION=0.4.4
65+
NEXT_VERSION=0.4.5
66+
67+
#### Info output:
68+
Pull Request: 17
69+
Current release version: 0.4.4
70+
Patch level: bugfix
71+
Possible new release version: 0.4.5
5272
```

docs/examples/github_actions.md

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -74,13 +74,12 @@ jobs:
7474
run: |
7575
wget https://github.com/eksrvb/awesome-ci/releases/latest/download/awesome-ci
7676
chmod +x awesome-ci
77-
- name: get next Version for project build
78-
id: version_step
79-
run: echo "::set-output name=new_version::$(./awesome-ci getBuildInfos -format version)"
77+
- name: set environment variables
78+
run: awesome-ci getBuildInfos
8079
env:
8180
GITHUB_TOKEN: $\{\{ secrets.GITHUB_TOKEN \}\}
8281
- name: Build and write version to binary
83-
run: go build -v -ldflags "-X main.version=${{ steps.version_step.outputs.new_version }}"
82+
run: go build -v -ldflags "-X main.version=$NEXT_VERSION"
8483
- name: Create Release and upload
8584
run: ./awesome-ci createRelease -uploadArtifacts file=my-compiled-binary
8685
env:

gitOnlineController/github.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import (
1515
)
1616

1717
func github_getPrNumberForBranch(branch string) int {
18-
url := fmt.Sprintf("%srepos/%s/pulls?state=open&head=%s", CiEnvironment.GitInfos.ApiUrl, CiEnvironment.GitInfos.FullRepo, branch[:len(branch)-1])
18+
url := fmt.Sprintf("%srepos/%s/pulls?state=open&head=%s", CiEnvironment.GitInfos.ApiUrl, CiEnvironment.GitInfos.FullRepo, branch)
1919
respBytes := newGitHubGetRequestUnmapped(url)
2020
var result []models.GithubReposRepoPull
2121

service/getBuildInfos.go

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,12 @@ import (
1212
func GetBuildInfos(cienv string, overrideVersion *string, getVersionIncrease *string, format *string) {
1313

1414
var infosMergeMessage infosMergeMessage
15+
var branchName = getCurrentBranchName()
1516
//if cienv == "Github" {
1617
// var err error
1718
infosMergeMessage, err := getLatestCommitMessage()
1819
if err != nil {
19-
infosMergeMessage.PRNumber = fmt.Sprint(gitOnlineController.GetPrNumberForBranch(getCurrentBranchName()))
20+
infosMergeMessage.PRNumber = fmt.Sprint(gitOnlineController.GetPrNumberForBranch(branchName))
2021
}
2122
//}
2223

@@ -25,18 +26,21 @@ func GetBuildInfos(cienv string, overrideVersion *string, getVersionIncrease *st
2526
patchLevel = *getVersionIncrease
2627
} else {
2728
patchLevel = infosMergeMessage.PatchLevel
29+
if patchLevel == "" {
30+
i := strings.Index(branchName, "/")
31+
patchLevel = branchName[:i]
32+
}
2833
}
2934

3035
var gitVersion string
31-
var nextVersion string
3236
if strings.Contains(*format, "version") || *format == "" {
3337
if *overrideVersion != "" {
3438
gitVersion = *overrideVersion
3539
} else {
3640
gitVersion = gitOnlineController.GetLatestReleaseVersion()
3741
}
38-
nextVersion = increaseSemVer(patchLevel, gitVersion)
3942
}
43+
nextVersion := increaseSemVer(patchLevel, gitVersion)
4044

4145
var envs []string
4246
envs = append(envs, fmt.Sprintf("PR=%s", infosMergeMessage.PRNumber))
@@ -71,7 +75,7 @@ func GetBuildInfos(cienv string, overrideVersion *string, getVersionIncrease *st
7175

7276
func getLatestCommitMessage() (infos infosMergeMessage, err error) {
7377
// Output: []string {FullString, PR, FullBranch, Orga, branch, branchBegin, restOfBranch}
74-
regex := `[a-zA-z ]+#([0-9]+) from (([0-9a-zA-Z-]+)/(([0-9a-z\-]+)/(.+)))`
78+
regex := `[a-zA-z ]+#([0-9]+) from (([0-9a-zA-Z\-]+)/(([0-9a-z\-]+)/(.+)))`
7579
r := regexp.MustCompile(regex)
7680

7781
// mergeMessage := r.FindStringSubmatch(`Merge pull request #3 from test-orga/feature/test-1`)
@@ -92,5 +96,6 @@ func getDefaultBranch() string {
9296
}
9397

9498
func getCurrentBranchName() string {
95-
return runcmd(`git branch --show-current`, true)
99+
branchName := runcmd(`git branch --show-current`, true)
100+
return strings.ReplaceAll(branchName, "\n", "")
96101
}

0 commit comments

Comments
 (0)