Skip to content

Possibility of reorgnizing the functions and fixing something seriously wrong? #7

@lvgeng

Description

@lvgeng

Sorry if I complaint too much, but I do think there are a lot of things need to be fixed.
Some obvious ones:

  1. The usage of the examples.
    For instance, the disparity sample. The documents says we should run
    python3 disparity_sample.py ~/path_to_file.xml -dmin 0 -dmax 10 -err False -scene 'real' -format tiff
    However, at least the "-err" is a problem cause the code requires "--err", and after that, the script would try to find a png file ~/path_to_file.png, which may not be generated if no adjustment is made to the code.
    To be honest, I have a strong feeling that some parts of the instrcution and testing samples are out of date because of the updating of the trunk part, would you mind to do some testing and fixing?

  2. missing functions
    For instance a function in disparity_methods.py, augment_costs_coarse() cannot be found defined.

  3. The structure of the code.
    It is just ... it feels different from a lib, it is more like a huge project for some specific things.
    For instance, the function rtxmain.estimate_disp(), it takes a lot of parameters (packed by a defined class) and returns a lot of thing (), while there is no comments to describe what they are exactly. (And... sorry for that but I am confused about the naming format you are using, a lot of variables begin with captical letters, which is kind of misleading while I try to understand the script)

Just saying, it is a good toolbox getting a lot of things done, but I really wish it is a little bit easier to use, like using a solid naming format, simple and specific functions dealing with different things respectively, and a function that using these functions to do the complex thing mentioned before rather than a giant function that does a lot of things at the same time (I am sure there is a good reason like that is the final goal or the same group of paremeters are used repeatly, but it is just so hard to understand what is going on or make any modification)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions