Build fixes

Mikael Wills · Mikael Wills · commit cb7b89da7843 · 2025-02-17T10:35:23.000Z
diff --git a/.github/workflows/dart.yml b/.github/workflows/dart.yml
@@ -22,7 +22,7 @@ jobs:
           java-version: '12.x'
       - uses: subosito/flutter-action@v1
         with:
-          channel: 'stable'
+          flutter-version: '3.27.1'
       - name: Install project dependencies
         run: flutter pub get
       - name: Dart Format Check
diff --git a/.github/workflows/pushMaster.yaml b/.github/workflows/pushMaster.yaml
@@ -14,13 +14,13 @@ jobs:
       - name: Install Flutter
         uses: subosito/flutter-action@v2
         with:
-          channel: "stable"
+          flutter-version: "3.27.1"
       - name: Install project dependencies
         run: flutter pub get
       - name: Dart Format Check
         run: dart format lib/ test/ --set-exit-if-changed
       - name: Import Sorter Check
-        run: dart run import_sorter:main
+        run: dart run import_sorter:main --exit-if-changed
       - name: Dart Analyze Check
         run: flutter analyze
       - name: Dart Test Check
diff --git a/lib/src/config.dart b/lib/src/config.dart
@@ -1,4 +1,3 @@
-// Project imports:
 import '../sip_ua.dart';
 import 'constants.dart' as DartSIP_C;
 import 'constants.dart';
diff --git a/lib/src/data.dart b/lib/src/data.dart
@@ -1,7 +1,5 @@
-// Dart imports:
 import 'dart:core';
 
-// Project imports:
 import 'constants.dart';
 import 'uri.dart';
 
diff --git a/lib/src/dialog.dart b/lib/src/dialog.dart
@@ -1,4 +1,3 @@
-// Project imports:
 import 'constants.dart';
 import 'dialog/request_sender.dart';
 import 'event_manager/event_manager.dart';
diff --git a/lib/src/dialog/request_sender.dart b/lib/src/dialog/request_sender.dart
@@ -1,7 +1,5 @@
-// Dart imports:
 import 'dart:async';
 
-// Project imports:
 import '../constants.dart';
 import '../dialog.dart';
 import '../event_manager/event_manager.dart';
diff --git a/lib/src/digest_authentication.dart b/lib/src/digest_authentication.dart
@@ -1,4 +1,3 @@
-// Project imports:
 import 'constants.dart';
 import 'logger.dart';
 import 'utils.dart' as utils;
diff --git a/lib/src/event_manager/call_events.dart b/lib/src/event_manager/call_events.dart
@@ -1,7 +1,5 @@
-// Package imports:
 import 'package:flutter_webrtc/flutter_webrtc.dart';
 
-// Project imports:
 import '../enums.dart';
 import '../rtc_session.dart';
 import '../sip_message.dart';
diff --git a/lib/src/event_manager/event_manager.dart b/lib/src/event_manager/event_manager.dart
@@ -1,4 +1,3 @@
-// Project imports:
 import '../logger.dart';
 import 'events.dart';
 
diff --git a/lib/src/event_manager/internal_events.dart b/lib/src/event_manager/internal_events.dart
@@ -1,7 +1,5 @@
-// Package imports:
 import 'package:flutter_webrtc/flutter_webrtc.dart';
 
-// Project imports:
 import '../enums.dart';
 import '../rtc_session.dart' show RTCSession;
 import '../rtc_session/dtmf.dart';
diff --git a/lib/src/event_manager/message_events.dart b/lib/src/event_manager/message_events.dart
@@ -1,4 +1,3 @@
-// Project imports:
 import '../enums.dart';
 import '../message.dart';
 import 'events.dart';
diff --git a/lib/src/event_manager/notifier_events.dart b/lib/src/event_manager/notifier_events.dart
@@ -1,4 +1,3 @@
-// Project imports:
 import '../sip_message.dart';
 import 'events.dart';
 
diff --git a/lib/src/event_manager/options_events.dart b/lib/src/event_manager/options_events.dart
@@ -1,4 +1,3 @@
-// Project imports:
 import '../enums.dart';
 import '../options.dart';
 import 'events.dart';
diff --git a/lib/src/event_manager/refer_events.dart b/lib/src/event_manager/refer_events.dart
@@ -1,4 +1,3 @@
-// Project imports:
 import 'events.dart';
 
 class EventReferTrying extends EventType {
diff --git a/lib/src/event_manager/register_events.dart b/lib/src/event_manager/register_events.dart
@@ -1,4 +1,3 @@
-// Project imports:
 import 'events.dart';
 
 class EventRegistrationExpiring extends EventType {
diff --git a/lib/src/event_manager/subscriber_events.dart b/lib/src/event_manager/subscriber_events.dart
@@ -1,4 +1,3 @@
-// Project imports:
 import '../sip_message.dart';
 import 'events.dart';
 
diff --git a/lib/src/event_manager/transport_events.dart b/lib/src/event_manager/transport_events.dart
@@ -1,4 +1,3 @@
-// Project imports:
 import '../transports/socket_interface.dart';
 import '../transports/web_socket.dart';
 import 'events.dart';
diff --git a/lib/src/exceptions.dart b/lib/src/exceptions.dart
@@ -1,4 +1,3 @@
-// Project imports:
 import 'utils.dart';
 
 class ErrorImpl extends Error {
diff --git a/lib/src/grammar.dart b/lib/src/grammar.dart
@@ -1,4 +1,3 @@
-// Project imports:
 import 'grammar_parser.dart';
 import 'parser_error.dart';
 
diff --git a/lib/src/grammar_parser.dart b/lib/src/grammar_parser.dart
@@ -1,11 +1,9 @@
 // This code was generated by a tool.
 // Processing tool available at https://github.com/mezoni/peg
 
-// Dart imports:
 import 'dart:convert';
 import 'dart:core';
 
-// Project imports:
 import 'data.dart';
 import 'name_addr_header.dart';
 import 'uri.dart';
diff --git a/lib/src/logger.dart b/lib/src/logger.dart
@@ -1,8 +1,6 @@
-// Package imports:
 import 'package:intl/intl.dart';
 import 'package:logger/logger.dart';
 
-// Project imports:
 import 'stack_trace_nj.dart';
 
 Logger logger = Log();
diff --git a/lib/src/message.dart b/lib/src/message.dart
@@ -1,4 +1,3 @@
-// Project imports:
 import 'constants.dart' as DartSIP_C;
 import 'constants.dart';
 import 'enums.dart';
diff --git a/lib/src/name_addr_header.dart b/lib/src/name_addr_header.dart
@@ -1,4 +1,3 @@
-// Project imports:
 import 'grammar.dart';
 import 'uri.dart';
 import 'utils.dart';
diff --git a/lib/src/options.dart b/lib/src/options.dart
@@ -1,4 +1,3 @@
-// Project imports:
 import 'package:sip_ua/src/enums.dart';
 import 'package:sip_ua/src/name_addr_header.dart';
 import 'constants.dart' as DartSIP_C;
diff --git a/lib/src/parser.dart b/lib/src/parser.dart
@@ -1,7 +1,5 @@
-// Dart imports:
 import 'dart:convert' show utf8;
 
-// Project imports:
 import 'grammar.dart';
 import 'logger.dart';
 import 'sip_message.dart';
diff --git a/lib/src/parser_error.dart b/lib/src/parser_error.dart
@@ -1,4 +1,3 @@
-// Package imports:
 import 'package:text/text.dart';
 
 class ParserErrorMessage {
diff --git a/lib/src/registrator.dart b/lib/src/registrator.dart
@@ -1,7 +1,5 @@
-// Dart imports:
 import 'dart:async';
 
-// Project imports:
 import 'constants.dart' as DartSIP_C;
 import 'constants.dart';
 import 'event_manager/event_manager.dart';
diff --git a/lib/src/request_sender.dart b/lib/src/request_sender.dart
@@ -1,4 +1,3 @@
-// Project imports:
 import 'constants.dart';
 import 'data.dart';
 import 'digest_authentication.dart';
diff --git a/lib/src/rtc_session.dart b/lib/src/rtc_session.dart
@@ -1,11 +1,8 @@
-// Dart imports:
 import 'dart:async';
 
-// Package imports:
 import 'package:flutter_webrtc/flutter_webrtc.dart';
 import 'package:sdp_transform/sdp_transform.dart' as sdp_transform;
 
-// Project imports:
 import '../sip_ua.dart';
 import 'constants.dart' as DartSIP_C;
 import 'constants.dart';
diff --git a/lib/src/rtc_session/dtmf.dart b/lib/src/rtc_session/dtmf.dart
@@ -1,7 +1,5 @@
-// Package imports:
 import 'package:flutter_webrtc/flutter_webrtc.dart';
 
-// Project imports:
 import '../../sip_ua.dart';
 import '../constants.dart';
 import '../event_manager/event_manager.dart';
diff --git a/lib/src/rtc_session/info.dart b/lib/src/rtc_session/info.dart
@@ -1,4 +1,3 @@
-// Project imports:
 import '../constants.dart';
 import '../enums.dart';
 import '../event_manager/event_manager.dart';
diff --git a/lib/src/rtc_session/refer_notifier.dart b/lib/src/rtc_session/refer_notifier.dart
@@ -1,4 +1,3 @@
-// Project imports:
 import '../constants.dart' as DartSIP_C;
 import '../constants.dart';
 import '../event_manager/event_manager.dart';
diff --git a/lib/src/rtc_session/refer_subscriber.dart b/lib/src/rtc_session/refer_subscriber.dart
@@ -1,4 +1,3 @@
-// Project imports:
 import '../constants.dart' as DartSIP_C;
 import '../constants.dart';
 import '../event_manager/event_manager.dart';
diff --git a/lib/src/sanity_check.dart b/lib/src/sanity_check.dart
@@ -1,4 +1,3 @@
-// Project imports:
 import 'constants.dart' as DartSIP_C;
 import 'constants.dart';
 import 'logger.dart';
diff --git a/lib/src/sip_message.dart b/lib/src/sip_message.dart
@@ -1,10 +1,7 @@
-// Dart imports:
 import 'dart:convert' show utf8;
 
-// Package imports:
 import 'package:sdp_transform/sdp_transform.dart' as sdp_transform;
 
-// Project imports:
 import 'constants.dart' as DartSIP_C;
 import 'constants.dart';
 import 'data.dart';
diff --git a/lib/src/sip_ua_helper.dart b/lib/src/sip_ua_helper.dart
@@ -1,12 +1,9 @@
-// Dart imports:
 import 'dart:async';
 
-// Package imports:
 import 'package:flutter_webrtc/flutter_webrtc.dart';
 import 'package:logger/logger.dart';
 import 'package:sdp_transform/sdp_transform.dart' as sdp_transform;
 
-// Project imports:
 import 'package:sip_ua/src/uri.dart';
 import 'config.dart';
 import 'constants.dart' as DartSIP_C;
diff --git a/lib/src/socket_transport.dart b/lib/src/socket_transport.dart
@@ -1,8 +1,6 @@
-// Dart imports:
 import 'dart:async';
 import 'dart:math';
 
-// Project imports:
 import './event_manager/events.dart';
 import './transports/socket_interface.dart';
 import 'exceptions.dart' as Exceptions;
diff --git a/lib/src/stack_trace_nj.dart b/lib/src/stack_trace_nj.dart
@@ -1,9 +1,7 @@
-// Dart imports:
 import 'dart:core' as core show StackTrace;
 import 'dart:core';
 import 'dart:io';
 
-// Package imports:
 import 'package:path/path.dart';
 
 class StackTraceNJ implements core.StackTrace {
diff --git a/lib/src/subscriber.dart b/lib/src/subscriber.dart
@@ -1,10 +1,7 @@
-// Dart imports:
 import 'dart:async';
 
-// Package imports:
 import 'package:collection/collection.dart';
 
-// Project imports:
 import './exceptions.dart' as exceptions;
 import 'constants.dart';
 import 'dialog.dart';
diff --git a/lib/src/timers.dart b/lib/src/timers.dart
@@ -1,4 +1,3 @@
-// Dart imports:
 import 'dart:async';
 
 class Timers {
diff --git a/lib/src/transactions/ack_client.dart b/lib/src/transactions/ack_client.dart
@@ -1,4 +1,3 @@
-// Project imports:
 import '../event_manager/event_manager.dart';
 import '../event_manager/internal_events.dart';
 import '../logger.dart';
diff --git a/lib/src/transactions/invite_client.dart b/lib/src/transactions/invite_client.dart
@@ -1,7 +1,5 @@
-// Dart imports:
 import 'dart:async';
 
-// Project imports:
 import '../constants.dart';
 import '../event_manager/event_manager.dart';
 import '../event_manager/internal_events.dart';
diff --git a/lib/src/transactions/invite_server.dart b/lib/src/transactions/invite_server.dart
@@ -1,7 +1,5 @@
-// Dart imports:
 import 'dart:async';
 
-// Project imports:
 import '../event_manager/internal_events.dart';
 import '../logger.dart';
 import '../sip_message.dart';
diff --git a/lib/src/transactions/non_invite_client.dart b/lib/src/transactions/non_invite_client.dart
@@ -1,7 +1,5 @@
-// Dart imports:
 import 'dart:async';
 
-// Project imports:
 import '../event_manager/event_manager.dart';
 import '../event_manager/internal_events.dart';
 import '../logger.dart';
diff --git a/lib/src/transactions/non_invite_server.dart b/lib/src/transactions/non_invite_server.dart
@@ -1,7 +1,5 @@
-// Dart imports:
 import 'dart:async';
 
-// Project imports:
 import 'package:sip_ua/src/sip_message.dart';
 import '../event_manager/internal_events.dart';
 import '../logger.dart';
diff --git a/lib/src/transactions/transaction_base.dart b/lib/src/transactions/transaction_base.dart
@@ -1,4 +1,3 @@
-// Project imports:
 import '../event_manager/event_manager.dart';
 import '../sip_message.dart';
 import '../socket_transport.dart';
diff --git a/lib/src/transactions/transactions.dart b/lib/src/transactions/transactions.dart
@@ -1,4 +1,3 @@
-// Project imports:
 import '../constants.dart';
 import '../sip_message.dart';
 import '../timers.dart';
diff --git a/lib/src/transports/tcp_socket.dart b/lib/src/transports/tcp_socket.dart
@@ -1,4 +1,3 @@
-// Project imports:
 import '../../sip_ua.dart';
 import '../logger.dart';
 import 'socket_interface.dart';
diff --git a/lib/src/transports/tcp_socket_impl.dart b/lib/src/transports/tcp_socket_impl.dart
@@ -1,10 +1,8 @@
-// Dart imports:
 import 'dart:async';
 import 'dart:convert';
 import 'dart:io';
 import 'dart:math';
 
-// Project imports:
 import '../logger.dart';
 import '../sip_ua_helper.dart';
 
diff --git a/lib/src/transports/web_socket.dart b/lib/src/transports/web_socket.dart
@@ -1,4 +1,3 @@
-// Project imports:
 import '../../sip_ua.dart';
 import '../grammar.dart';
 import '../logger.dart';
diff --git a/lib/src/transports/websocket_dart_impl.dart b/lib/src/transports/websocket_dart_impl.dart
@@ -1,10 +1,8 @@
-// Dart imports:
 import 'dart:async';
 import 'dart:convert';
 import 'dart:io';
 import 'dart:math';
 
-// Project imports:
 import 'package:sip_ua/src/sip_ua_helper.dart';
 import '../logger.dart';
 
diff --git a/lib/src/transports/websocket_web_impl.dart b/lib/src/transports/websocket_web_impl.dart
@@ -1,8 +1,6 @@
-// Dart imports:
 import 'dart:html';
 import 'dart:js_util' as JSUtils;
 
-// Project imports:
 import 'package:sip_ua/src/sip_ua_helper.dart';
 import '../logger.dart';
 
diff --git a/lib/src/ua.dart b/lib/src/ua.dart
@@ -1,7 +1,5 @@
-// Dart imports:
 import 'dart:async';
 
-// Project imports:
 import 'config.dart' as config;
 import 'config.dart';
 import 'constants.dart' as DartSIP_C;
@@ -319,7 +317,7 @@ class UA extends EventManager {
     int num_sessions = _sessions.length;
 
     // Run  _terminate_ on every Session.
-    _sessions.keys.toList().forEach((String? key, _) {
+    _sessions.keys.toList().forEach((String? key) {
       if (_sessions.containsKey(key)) {
         logger.d('closing session $key');
         try {
diff --git a/lib/src/uri.dart b/lib/src/uri.dart
@@ -1,4 +1,3 @@
-// Project imports:
 import 'constants.dart' as DartSIP_C;
 import 'grammar.dart';
 import 'utils.dart' as utils;
diff --git a/lib/src/utils.dart b/lib/src/utils.dart
diff --git a/test/all_test.dart b/test/all_test.dart
diff --git a/test/test2_websocket.dart b/test/test2_websocket.dart
diff --git a/test/test_classes.dart b/test/test_classes.dart
diff --git a/test/test_digest_authentication.dart b/test/test_digest_authentication.dart
diff --git a/test/test_normalize_target.dart b/test/test_normalize_target.dart
diff --git a/test/test_parser.dart b/test/test_parser.dart
diff --git a/test/test_sip_message_parser.dart b/test/test_sip_message_parser.dart
diff --git a/test/test_sip_ua.dart b/test/test_sip_ua.dart
diff --git a/test/test_uri_parse.dart b/test/test_uri_parse.dart
diff --git a/test/test_websocket.dart b/test/test_websocket.dart

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,3 @@`
`1`		`-// Project imports:`
`2`	`1`	`import '../sip_ua.dart';`
`3`	`2`	`import 'constants.dart' as DartSIP_C;`
`4`	`3`	`import 'constants.dart';`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,3 @@`
`1`		`-// Project imports:`
`2`	`1`	`import '../logger.dart';`
`3`	`2`	`import 'events.dart';`
`4`	`3`