Skip to content

Commit b1f4716

Browse files
committed
Remove the unneeded special handling for matching chrome payloads for end markers
1 parent ae84914 commit b1f4716

File tree

1 file changed

+0
-35
lines changed

1 file changed

+0
-35
lines changed

src/profile-logic/import/chrome.ts

Lines changed: 0 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -967,11 +967,6 @@ function extractMarkers(
967967
},
968968
];
969969

970-
// Map to store begin event detail field for pairing with end events.
971-
// For async events (b/e), key is "pid:tid:id:name"
972-
// For duration events (B/E), key is "pid:tid:name"
973-
const beginEventDetail: Map<string, string> = new Map();
974-
975970
// Track whether we've added the EventWithDetail schema
976971
let hasEventWithDetailSchema = false;
977972

@@ -1038,20 +1033,6 @@ function extractMarkers(
10381033
}
10391034
}
10401035

1041-
// For end events (E/e), try to use the detail from the corresponding begin event
1042-
if ((event.ph === 'E' || event.ph === 'e') && !argData) {
1043-
// Generate key for looking up the begin event detail
1044-
// For async events (b/e), use id; for duration events (B/E), use name only
1045-
const key =
1046-
event.ph === 'e' && 'id' in event
1047-
? `${event.pid}:${event.tid}:${event.id}:${name}`
1048-
: `${event.pid}:${event.tid}:${name}`;
1049-
const detail = beginEventDetail.get(key);
1050-
if (detail) {
1051-
argData = { detail };
1052-
}
1053-
}
1054-
10551036
markers.name.push(stringTable.indexForString(name));
10561037

10571038
if (argData && 'type' in argData) {
@@ -1114,29 +1095,13 @@ function extractMarkers(
11141095
markers.startTime.push(time);
11151096
markers.endTime.push(null);
11161097
markers.phase.push(INTERVAL_START);
1117-
1118-
// Store the detail field from begin event so it can be used for the corresponding end event
1119-
if (argData?.detail) {
1120-
const key =
1121-
event.ph === 'b' && 'id' in event
1122-
? `${event.pid}:${event.tid}:${event.id}:${name}`
1123-
: `${event.pid}:${event.tid}:${name}`;
1124-
beginEventDetail.set(key, argData.detail);
1125-
}
11261098
} else if (event.ph === 'E' || event.ph === 'e') {
11271099
// Duration or Async Event End
11281100
// https://docs.google.com/document/d/1CvAClvFfyA5R-PhYUmn5OOQtYMH4h6I0nSsKchNAySU/preview#heading=h.nso4gcezn7n1
11291101
// The 'E' and 'e' phase stand for "end", and is the Chrome equivalent of IntervalEnd.
11301102
markers.startTime.push(null);
11311103
markers.endTime.push(time);
11321104
markers.phase.push(INTERVAL_END);
1133-
1134-
// Clean up the stored begin event detail
1135-
const key =
1136-
event.ph === 'e' && 'id' in event
1137-
? `${event.pid}:${event.tid}:${event.id}:${name}`
1138-
: `${event.pid}:${event.tid}:${name}`;
1139-
beginEventDetail.delete(key);
11401105
} else {
11411106
// Instant Event
11421107
// https://docs.google.com/document/d/1CvAClvFfyA5R-PhYUmn5OOQtYMH4h6I0nSsKchNAySU/preview#heading=h.lenwiilchoxp

0 commit comments

Comments
 (0)