fix: set loop for services where missing (#441)

* fix: set loop for services where missing

* chore: linting

Author: dada-engineer

extra/tools/verify_doc_defaults.py

@@ -15,36 +15,36 @@
 from yarl import URL
 
 
-SETTINGS: Path = Path('docs/userguide/settings.rst')
+SETTINGS: Path = Path("docs/userguide/settings.rst")
 
-app = faust.App('verify_defaults')
+app = faust.App("verify_defaults")
 
 ignore_settings: Set[str] = {
-    'id',
-    'tabledir',
-    'reply_to',
-    'broker_consumer',
-    'broker_producer',
+    "id",
+    "tabledir",
+    "reply_to",
+    "broker_consumer",
+    "broker_producer",
 }
 
 builtin_locals: Dict[str, Any] = {
-    'aiohttp': aiohttp,
-    'app': app,
-    'datetime': datetime,
-    'datadir': app.conf.datadir,
-    'faust': faust,
-    'logging': logging,
-    'mode': mode,
-    'socket': socket,
-    'timedelta': timedelta,
-    'web_host': socket.gethostname(),
-    'web_port': 6066,
-    'VERSION': faust.__version__,
-    'uuid': uuid,
-    'URL': URL,
+    "aiohttp": aiohttp,
+    "app": app,
+    "datetime": datetime,
+    "datadir": app.conf.datadir,
+    "faust": faust,
+    "logging": logging,
+    "mode": mode,
+    "socket": socket,
+    "timedelta": timedelta,
+    "web_host": socket.gethostname(),
+    "web_port": 6066,
+    "VERSION": faust.__version__,
+    "uuid": uuid,
+    "URL": URL,
 }
 
-RE_REF = re.compile(r'^:(\w+):`')
+RE_REF = re.compile(r"^:(\w+):`")
 
 
 class Error(NamedTuple):
@@ -63,7 +63,7 @@ def verify_settings(rst_path: Path) -> Iterator[Error]:
             actual = actual.value
         if actual != default:
             yield Error(
-                reason='mismatch',
+                reason="mismatch",
                 setting=setting_name,
                 default=default,
                 actual=actual,
@@ -74,53 +74,54 @@ def report_errors(errors: Iterator[Error]) -> int:
     num_errors: int = 0
     for num_errors, e in enumerate(errors, start=1):
         if num_errors == 1:
-            carp(f'{sys.argv[0]}: Errors in docs/userguide/settings.rst:')
-        carp(f'  + Setting {e.reason} {e.setting}:')
-        carp(f'       documentation: {e.default!r}')
-        carp(f'              actual: {e.actual!r}')
+            carp(f"{sys.argv[0]}: Errors in docs/userguide/settings.rst:")
+        carp(f"  + Setting {e.reason} {e.setting}:")
+        carp(f"       documentation: {e.default!r}")
+        carp(f"              actual: {e.actual!r}")
     if num_errors:
-        carp(f'Found {num_errors} error(s).', file=sys.stderr)
+        carp(f"Found {num_errors} error(s).", file=sys.stderr)
     else:
-        print(f'{sys.argv[0]}: All OK :-)', file=sys.stdout)
+        print(f"{sys.argv[0]}: All OK :-)", file=sys.stdout)
     return num_errors
 
 
 def carp(msg, *, file: IO = sys.stderr, **kwargs: Any) -> None:
     print(msg, file=file, **kwargs)
 
 
-def find_settings_in_rst(rst_path: Path,
-                         locals: Dict[str, Any] = None,
-                         builtin_locals: Dict[str, Any] = builtin_locals,
-                         ignore_settings: Set[str] = ignore_settings):
+def find_settings_in_rst(
+    rst_path: Path,
+    locals: Dict[str, Any] = None,
+    builtin_locals: Dict[str, Any] = builtin_locals,
+    ignore_settings: Set[str] = ignore_settings,
+):
     setting: str = None
     default: Any = None
-    app = faust.App('_verify_doc_defaults')
+    app = faust.App("_verify_doc_defaults")
     _globals = dict(globals())
     # Add setting default to globals
     # so that defaults referencing another setting work.
     # E.g.:
     #   :default: :setting:`broker_api_version`
-    _globals.update({
-        name: getattr(app.conf, name)
-        for name in app.conf.setting_names()
-    })
+    _globals.update(
+        {name: getattr(app.conf, name) for name in app.conf.setting_names()}
+    )
     local_ns: Dict[str, Any] = {**builtin_locals, **(locals or {})}
     for line in rst_path.read_text().splitlines():
-        if line.startswith('.. setting::'):
+        if line.startswith(".. setting::"):
             if setting and not default and setting not in ignore_settings:
-                raise Exception(f'No default value for {setting}')
-            setting = line.split('::')[-1].strip()
-        elif ':default:' in line:
-            if '``' in line:
-                line, sep, rest = line.rpartition('``')
-            default = line.split(':default:')[-1].strip()
-            default = default.strip('`')
-            default = RE_REF.sub('', default)
+                raise Exception(f"No default value for {setting}")
+            setting = line.split("::")[-1].strip()
+        elif ":default:" in line:
+            if "``" in line:
+                line, sep, rest = line.rpartition("``")
+            default = line.split(":default:")[-1].strip()
+            default = default.strip("`")
+            default = RE_REF.sub("", default)
             default_value = eval(default, _globals, local_ns)
             if setting not in ignore_settings:
                 yield setting, default_value
 
 
-if __name__ == '__main__':
+if __name__ == "__main__":
     sys.exit(report_errors(verify_settings(SETTINGS)))

faust/agents/agent.py

@@ -226,7 +226,7 @@ def __init__(
                 "Agent concurrency must be 1 when using isolated partitions"
             )
         self.use_reply_headers = use_reply_headers
-        Service.__init__(self)
+        Service.__init__(self, loop=app.loop)
 
     def on_init_dependencies(self) -> Iterable[ServiceT]:
         """Return list of services dependencies required to start agent."""
@@ -1090,7 +1090,6 @@ def shortlabel(self) -> str:
 
 
 class AgentTestWrapper(Agent, AgentTestWrapperT):  # pragma: no cover
-
     _stream: StreamT
 
     def __init__(

faust/cli/base.py

@@ -527,6 +527,7 @@ class Command(abc.ABC):  # noqa: B024
     @classmethod
     def as_click_command(cls) -> Callable:  # pragma: no cover
         """Convert command into :pypi:`click` command."""
+
         # This is what actually registers the commands into the
         # :pypi:`click` command-line interface (the ``def cli`` main above).
         # __init_subclass__ calls this for the side effect of being

faust/livecheck/case.py

@@ -176,7 +176,7 @@ def __init__(
         # signal attributes have the correct signal instance.
         self.__dict__.update(self.signals)
 
-        Service.__init__(self, **kwargs)
+        Service.__init__(self, loop=app.loop, **kwargs)
 
     @Service.timer(10.0)
     async def _sampler(self) -> None:

faust/models/fields.py

@@ -331,7 +331,6 @@ def prepare_value(
 
 
 class NumberField(FieldDescriptor[T]):
-
     max_value: Optional[int]
     min_value: Optional[int]
 
@@ -439,7 +438,6 @@ def validate(self, value: Decimal) -> Iterable[ValidationError]:
 
 
 class CharField(FieldDescriptor[CharacterType]):
-
     max_length: Optional[int]
     min_length: Optional[int]
     trim_whitespace: bool

faust/models/tags.py

@@ -79,7 +79,6 @@ def __format__(self, format_spec: str) -> str:
 
 
 class _FrameLocal(UserString, Generic[T]):
-
     _field_name: str
     _tag_type: str
     _frame: str

faust/streams.py

@@ -866,7 +866,6 @@ def get_key(withdrawal):
         if topic is not None:
             channel = topic
         else:
-
             prefix = ""
             if self.prefix and not cast(TopicT, self.channel).has_prefix:
                 prefix = self.prefix + "-"

faust/tables/base.py

@@ -125,7 +125,7 @@ def __init__(
         synchronize_all_active_partitions: bool = False,
         **kwargs: Any,
     ) -> None:
-        Service.__init__(self, **kwargs)
+        Service.__init__(self, loop=app.loop, **kwargs)
         self.app = app
         self.name = cast(str, name)  # set lazily so CAN BE NONE!
         self.default = default

faust/tables/objects.py

@@ -72,7 +72,7 @@ def __init__(self, table: Table, **kwargs: Any) -> None:
         self.table_name = self.table.name
         self.data = {}
         self._dirty = set()
-        Service.__init__(self, **kwargs)
+        Service.__init__(self, loop=table.loop, **kwargs)
 
     def send_changelog_event(self, key: Any, operation: int, value: Any) -> None:
         """Send changelog event to the tables changelog topic."""

faust/transport/consumer.py

@@ -1363,7 +1363,6 @@ def verify_recovery_event_path(self, now: float, tp: TP) -> None:
 
 
 class ThreadDelegateConsumer(Consumer):
-
     _thread: ConsumerThread
 
     #: Main thread method queue.