Update StatusReporter class

This class used to return the Console message but now it does not have
that responsibility and will only return an empty string until we get
the GPA Score on Skunk, we will print it as RubyCritic does

Author: JuanVqz

bin/console

@@ -13,5 +13,5 @@ puts ARGV.inspect
 require "skunk/cli/application"
 require "skunk/config"
 
-Skunk::Config.formats = %i[json html]
+Skunk::Config.formats = %i[json console html]
 Skunk::Cli::Application.new(ARGV).execute

lib/skunk/commands/default.rb

@@ -37,9 +37,6 @@ def execute
       # @param [RubyCritic::AnalysedModulesCollection] A collection of analysed modules
       def report(analysed_modules)
         Reporter.generate_report(analysed_modules)
-
-        status_reporter.analysed_modules = analysed_modules
-        status_reporter.score = analysed_modules.score
       end
     end
   end

lib/skunk/commands/status_reporter.rb

@@ -4,17 +4,14 @@
 
 module Skunk
   module Command
-    # Knows how to report status for stinky files
+    # Extends RubyCritic::Command::StatusReporter to silence the status message
     class StatusReporter < RubyCritic::Command::StatusReporter
-      attr_accessor :analysed_modules
-
       def initialize(options = {})
         super(options)
       end
 
-      # Returns a simple status message indicating the analysis is complete
       def update_status_message
-        @status_message = "Skunk Report Completed"
+        @status_message = ""
       end
     end
   end

lib/skunk/generators/html_report.rb

@@ -18,7 +18,7 @@ def initialize(analysed_modules)
 
       def generate_report
         create_directories_and_files
-        puts "Skunk report generated at #{report_location}"
+        puts "#{report_name} generated at #{report_location}"
         browser.open unless RubyCritic::Config.no_browser
       end
 
@@ -40,6 +40,13 @@ def generators
       def overview_generator
         @overview_generator ||= Skunk::Generator::Html::Overview.new(@analysed_modules)
       end
+
+      def report_name
+        self.class.name.split("::").last
+            .gsub(/([a-z])([A-Z])/, '\1 \2')
+            .downcase
+            .capitalize
+      end
     end
   end
 end

lib/skunk/generators/json_report.rb

@@ -1,23 +1,33 @@
 # frozen_string_literal: true
 
-require "rubycritic/generators/json_report"
-
 require "skunk/generators/json/simple"
 
 module Skunk
   module Generator
     # Generates a JSON report for the analysed modules.
-    class JsonReport < RubyCritic::Generator::JsonReport
+    class JsonReport
       def initialize(analysed_modules)
-        super
         @analysed_modules = analysed_modules
       end
 
+      def generate_report
+        FileUtils.mkdir_p(generator.file_directory)
+        puts "#{report_name} generated at #{generator.file_pathname}"
+        File.write(generator.file_pathname, generator.render)
+      end
+
       private
 
       def generator
         Skunk::Generator::Json::Simple.new(@analysed_modules)
       end
+
+      def report_name
+        self.class.name.split("::").last
+            .gsub(/([a-z])([A-Z])/, '\1 \2')
+            .downcase
+            .capitalize
+      end
     end
   end
 end

lib/skunk/reporter.rb

@@ -13,10 +13,13 @@ def self.generate_report(analysed_modules)
     end
 
     def self.report_generator_class(config_format)
-      return unless Config.supported_format?(config_format)
-
-      require "skunk/generators/#{config_format}_report"
-      Generator.const_get("#{config_format.capitalize}Report")
+      if Config.supported_format?(config_format)
+        require "skunk/generators/#{config_format}_report"
+        Generator.const_get("#{config_format.capitalize}Report")
+      else
+        require "skunk/generators/console_report"
+        Generator::ConsoleReport
+      end
     end
   end
 end

test/lib/skunk/commands/status_reporter_test.rb

@@ -2,52 +2,14 @@
 
 require "test_helper"
 
-require "rubycritic/analysers_runner"
-require "skunk/rubycritic/analysed_modules_collection"
 require "skunk/commands/status_reporter"
 
 describe Skunk::Command::StatusReporter do
-  let(:paths) { "samples/rubycritic" }
-
   describe "#update_status_message" do
-    let(:output) { File.read("test/samples/console_output.txt") }
     let(:reporter) { Skunk::Command::StatusReporter.new({}) }
 
-    around do |example|
-      RubyCritic::Config.source_control_system = MockGit.new
-      runner = RubyCritic::AnalysersRunner.new(paths)
-      analysed_modules = runner.run
-      analysed_modules.each do |analysed_module|
-        def analysed_module.coverage
-          100.0
-        end
-
-        def analysed_module.churn
-          1
-        end
-      end
-
-      reporter.analysed_modules = analysed_modules
-      reporter.score = analysed_modules.score
-      example.call
-    end
-
     it "reports a simple status message" do
-      _(reporter.update_status_message).must_equal "Skunk analysis complete. Use --format console to see detailed output."
+      _(reporter.update_status_message).must_equal ""
     end
-
-    context "When there's nested spec files" do
-      let(:paths) { "samples" }
-      it "reports a simple status message" do
-        _(reporter.update_status_message).must_equal "Skunk analysis complete. Use --format console to see detailed output."
-      end
-    end
-  end
-end
-
-# A Mock Git class that returns always 1 for revisions_count
-class MockGit < RubyCritic::SourceControlSystem::Git
-  def revisions_count(_)
-    1
   end
 end