Allow sqlx runtime tls to be configurable - [opened]

[famedly-bot]

In GitLab by @jgrund on Mar 8, 2022, 22:55

Merges make-runtime-tls-configurable -> main

sqlx runtime tls is currently hardcoded to runtime-tokio-rustls.

However, there may be cases where runtime-tokio-native-tls is preferable.

Introduce two new features use-rustls, and use-native-tls to control this.

use-rustls is enabled by default so the default tls config remans the same, but can now be changed.

Signed-off-by: Joe Grund jgrund@whamcloud.io

[famedly-bot]

In GitLab by @famedly-bot on Mar 8, 2022, 22:55

Thank you for your merge request and welcome to Famedly. We require contributors to sign our Contributor License Agreement, and we don't seem to have the user Joe Grund on file.
In order for us to review and merge your code, please sign our Contributer License Agreement.

Please visit Link to CLA to sign.

Once you've signed, we will start with the review process.

[famedly-bot]

In GitLab by @agraven on Mar 9, 2022, 08:16

This needs a feature guard for a compile_error!() invocation in src/lib.rs so the build fails if none or both of the tls implementations have been enabled.

[famedly-bot]

In GitLab by @nikzen on Mar 9, 2022, 10:35

@famedly-bot check

[famedly-bot]

In GitLab by @f.dommes on Mar 9, 2022, 13:44

mentioned in issue famedly/company/backend/issue-inbox#297

[famedly-bot]

In GitLab by @jgrund on Mar 9, 2022, 16:28

added 1 commit

• 7d98fd7 - Add compile_error macro invocation

Compare with previous version

[famedly-bot]

In GitLab by @jgrund on Mar 9, 2022, 16:28

Done

[famedly-bot]

In GitLab by @f.dommes on Mar 9, 2022, 17:53

Commented on sqlx-database-tester-macros/Cargo.toml line 17

To keep it in line with sqlx, I would suggest a feature name to be without use:

default = ["rustls"]
runtime-actix = []
runtime-tokio = []
rustls = ["sqlx/runtime-tokio-rustls"]
native-tls = ["sqlx/runtime-tokio-native-tls"]

[famedly-bot]

In GitLab by @f.dommes on Mar 9, 2022, 17:53

Commented on src/lib.rs line 23

This does only check if none is present, but I assume that is fine, as the downstream crates will error if that is wrong.

[famedly-bot]

In GitLab by @f.dommes on Mar 9, 2022, 17:53

Commented on Cargo.toml line 14

The feature needs to be passed down to the macros crate:

default = ["rustls"]
runtime-actix = ["sqlx-database-tester-macros/runtime-actix"]
runtime-tokio = ["sqlx-database-tester-macros/runtime-tokio"]
rustls = ["sqlx/runtime-tokio-rustls", "sqlx-database-tester-macros/rustls"]
native-tls = ["sqlx/runtime-tokio-native-tls", "sqlx-database-tester-macros/native-tls"]

[famedly-bot]

In GitLab by @nikzen on Oct 21, 2022, 19:27

mentioned in issue famedly/chapter-backend/tasks#6

[famedly-bot]

In GitLab by @jgrund on Apr 19, 2023, 20:18

added 1 commit

• d5ff95f - Bump deps

Compare with previous version