Add knownLength to HTTPBinaryCodec parameter

Summary: We need to allow callers who instantiate this class to set the knownLength parameter to construct chunked requests.

Differential Revision: D68312239

fbshipit-source-id: d14aae172f1eca8af133a23ef04176206b65c363

Author: Shiv Kushwah

proxygen/lib/http/codec/HTTPBinaryCodec.cpp

@@ -35,11 +35,15 @@ void encodeString(folly::StringPiece str, folly::io::QueueAppender& appender) {
 }
 } // namespace
 
-HTTPBinaryCodec::HTTPBinaryCodec(TransportDirection direction) {
-  transportDirection_ = direction;
-  state_ = ParseState::FRAMING_INDICATOR;
-  parseError_ = folly::none;
-  parserPaused_ = false;
+HTTPBinaryCodec::HTTPBinaryCodec(TransportDirection direction)
+    : HTTPBinaryCodec(direction, true) {
+}
+HTTPBinaryCodec::HTTPBinaryCodec(TransportDirection direction, bool knownLength)
+    : knownLength_(knownLength),
+      state_(ParseState::FRAMING_INDICATOR),
+      parserPaused_(false),
+      parseError_(folly::none),
+      transportDirection_(direction) {
 }
 
 HTTPBinaryCodec::~HTTPBinaryCodec() {

proxygen/lib/http/codec/HTTPBinaryCodec.h

@@ -54,6 +54,7 @@ class HTTPBinaryCodec : public HTTPCodec {
  public:
   // Default strictValidation to false for now to match existing behavior
   explicit HTTPBinaryCodec(TransportDirection direction);
+  HTTPBinaryCodec(TransportDirection direction, bool knownLength);
   ~HTTPBinaryCodec() override;
 
   HTTPBinaryCodec(HTTPBinaryCodec&&) = default;

proxygen/lib/http/codec/test/HTTPBinaryCodecTest.cpp

@@ -22,8 +22,7 @@ class HTTPBinaryCodecForTest : public HTTPBinaryCodec {
   }
   explicit HTTPBinaryCodecForTest(TransportDirection direction,
                                   bool knownLength)
-      : HTTPBinaryCodec{direction} {
-    knownLength_ = knownLength;
+      : HTTPBinaryCodec{direction, knownLength} {
   }
   ParseResult parseFramingIndicator(folly::io::Cursor& cursor,
                                     bool& request,