Use the read_bool helper instead of custom implementation

Summary:
The `read_bool` utility function handles the custom written functionality (which predates the helper being moved to prelude).

Additionally, the helper guards against typos.

1. use the helper
2. set a default of `None`, and remove setting of the default in call sites
3. rename `_maybe_read_bool` to `_read_bool`

Reviewed By: watwars

Differential Revision: D90029218

fbshipit-source-id: 6f91d823925acfd42dd72979b0abe2d383f0d368

Author: chatura-atapattu

prelude/apple/apple_bundle_config.bzl

@@ -6,22 +6,20 @@
 # of this source tree. You may select, at your option, one of the
 # above-listed licenses.
 
+load("@prelude//utils:buckconfig.bzl", "read_bool")
 load(":apple_code_signing_types.bzl", "CodeSignConfiguration")
 
-def _maybe_get_bool(config: str, default: [None, bool]) -> [None, bool]:
-    result = read_root_config("apple", config, None)
-    if result == None:
-        return default
-    return result.lower() == "true"
+def _read_bool(config: str, default: [None, bool] = None) -> [None, bool]:
+    return read_bool("apple", config, default = default, required = False, root_cell = True)
 
 def _get_code_signing_configuration() -> str:
-    is_dry_run = _maybe_get_bool("dry_run_code_signing", False)
+    is_dry_run = _read_bool("dry_run_code_signing", False)
 
     # This is a kill switch for the feature, it can also be disabled by setting
     # `apple.fast_adhoc_signing_enabled=false` in a global buckconfig file.
-    is_fast_adhoc_signing_enabled = _maybe_get_bool("fast_adhoc_signing_enabled", True)
+    is_fast_adhoc_signing_enabled = _read_bool("fast_adhoc_signing_enabled", True)
 
-    is_codesign_execution_bypass_enabled = _maybe_get_bool("codesign_execution_bypass", False)
+    is_codesign_execution_bypass_enabled = _read_bool("codesign_execution_bypass", False)
     if is_dry_run and is_codesign_execution_bypass_enabled:
         fail("Dry run and execution bypass are mutually exclusive, pick one")
 
@@ -39,18 +37,18 @@ def _get_code_signing_configuration() -> str:
 def apple_bundle_config() -> dict[str, typing.Any]:
     return {
         "_bundling_cache_buster": read_root_config("apple", "bundling_cache_buster", None),
-        "_bundling_log_file_enabled": _maybe_get_bool("bundling_log_file_enabled", True),
+        "_bundling_log_file_enabled": _read_bool("bundling_log_file_enabled", True),
         "_bundling_log_file_level": read_root_config("apple", "bundling_log_file_level", None),
         "_code_signing_configuration": _get_code_signing_configuration(),
         "_codesign_command_override": read_root_config("apple", "codesign_command_override", None),
         "_codesign_identities_command_override": read_root_config("apple", "codesign_identities_command_override", None),
         "_codesign_type": read_root_config("apple", "codesign_type_override", None),
-        "_compile_resources_locally_override": _maybe_get_bool("compile_resources_locally_override", None),
-        "_embed_provisioning_profile_when_adhoc_code_signing": _maybe_get_bool("embed_provisioning_profile_when_adhoc_code_signing", None),
-        "_fast_provisioning_profile_parsing_enabled": _maybe_get_bool("fast_provisioning_profile_parsing_enabled", False),
-        "_incremental_bundling_enabled": _maybe_get_bool("incremental_bundling_enabled", True),
-        "_info_plist_identify_build_system_default": _maybe_get_bool("info_plist_identify_build_system", True),
-        "_profile_bundling_enabled": _maybe_get_bool("profile_bundling_enabled", False),
-        "_skip_adhoc_resigning_scrubbed_frameworks_override": _maybe_get_bool("skip_adhoc_resigning_scrubbed_frameworks_override", None),
-        "_use_entitlements_when_adhoc_code_signing": _maybe_get_bool("use_entitlements_when_adhoc_code_signing", None),
+        "_compile_resources_locally_override": _read_bool("compile_resources_locally_override"),
+        "_embed_provisioning_profile_when_adhoc_code_signing": _read_bool("embed_provisioning_profile_when_adhoc_code_signing"),
+        "_fast_provisioning_profile_parsing_enabled": _read_bool("fast_provisioning_profile_parsing_enabled", False),
+        "_incremental_bundling_enabled": _read_bool("incremental_bundling_enabled", True),
+        "_info_plist_identify_build_system_default": _read_bool("info_plist_identify_build_system", True),
+        "_profile_bundling_enabled": _read_bool("profile_bundling_enabled", False),
+        "_skip_adhoc_resigning_scrubbed_frameworks_override": _read_bool("skip_adhoc_resigning_scrubbed_frameworks_override"),
+        "_use_entitlements_when_adhoc_code_signing": _read_bool("use_entitlements_when_adhoc_code_signing"),
     }