comments

Author: tac0turtle

crates/ev-revm/src/deploy.rs

@@ -13,7 +13,9 @@ pub struct DeployAllowlistSettings {
 impl DeployAllowlistSettings {
     /// Creates a new deploy allowlist configuration.
     pub fn new(allowlist: Vec<Address>, activation_height: u64) -> Self {
+        let mut allowlist = allowlist;
         debug_assert!(!allowlist.is_empty(), "deploy allowlist must not be empty");
+        allowlist.sort_unstable();
         Self {
             allowlist: Arc::from(allowlist),
             activation_height,
@@ -37,6 +39,6 @@ impl DeployAllowlistSettings {
 
     /// Returns true if the caller is in the allowlist.
     pub fn is_allowed(&self, caller: Address) -> bool {
-        self.allowlist.contains(&caller)
+        self.allowlist.binary_search(&caller).is_ok()
     }
 }

crates/node/src/config.rs

@@ -1,6 +1,7 @@
 use alloy_primitives::Address;
 use reth_chainspec::ChainSpec;
 use serde::{Deserialize, Serialize};
+use std::collections::HashSet;
 
 /// Default contract size limit in bytes (24KB per EIP-170).
 pub const DEFAULT_CONTRACT_SIZE_LIMIT: usize = 24 * 1024;
@@ -167,19 +168,17 @@ impl EvolvePayloadBuilderConfig {
             )));
         }
 
-        for i in 0..allowlist_len {
-            let addr = self.deploy_allowlist[i];
+        let mut seen = HashSet::with_capacity(allowlist_len);
+        for addr in &self.deploy_allowlist {
             if addr.is_zero() {
                 return Err(ConfigError::InvalidDeployAllowlist(
                     "deployAllowlist contains zero address".to_string(),
                 ));
             }
-            for j in (i + 1)..allowlist_len {
-                if addr == self.deploy_allowlist[j] {
-                    return Err(ConfigError::InvalidDeployAllowlist(
-                        "deployAllowlist contains duplicate entries".to_string(),
-                    ));
-                }
+            if !seen.insert(*addr) {
+                return Err(ConfigError::InvalidDeployAllowlist(
+                    "deployAllowlist contains duplicate entries".to_string(),
+                ));
             }
         }