Skip to content

Commit a8eb269

Browse files
authored
refactor: use strings.Builder to improve performance (#465)
Signed-off-by: mickychang9 <[email protected]>
1 parent a30fb8c commit a8eb269

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

cmd/priv-dashboard/main.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,7 @@ func (d *dashboard) outputSummaryHtml(contract string, nodes map[string]*record,
251251
var (
252252
dstr = time.Now().Format("2006-01-02")
253253
dataRang = "(24h)"
254-
content = ""
254+
content strings.Builder
255255
contentFormat = "<tr>\n\t<td>%s</td>\n\t<td>%s</td>\n\t<td>%d</td>\n\t<td>%d</td>\n\t<td>%d</td>\n\t<td>%d</td>\n\t" +
256256
"<td>%d</td>\n\t<td>%s</td>\n\t<td>%d</td>\n\t<td>%d</td>\n\t<td>%s</td>\n\t<td>%s</td>\n\t</tr>\n"
257257
subject = fmt.Sprintf("Subject: Daily Network Statistics Report | %s | %s\r\n"+
@@ -284,8 +284,8 @@ func (d *dashboard) outputSummaryHtml(contract string, nodes map[string]*record,
284284
mismatchedCount = strconv.Itoa(n.state.ScanStats.MismatchedCount)
285285
unfixedCount = strconv.Itoa(n.state.ScanStats.UnfixedCount)
286286
}
287-
content += fmt.Sprintf(contentFormat, n.state.Address, shard.Miner, n.state.SavedBlobs, downloadedBlobs,
288-
shard.ShardId, shard.SyncState.PeerCount, submitted, submittedTime, dropped, failed, mismatchedCount, unfixedCount)
287+
content.WriteString(fmt.Sprintf(contentFormat, n.state.Address, shard.Miner, n.state.SavedBlobs, downloadedBlobs,
288+
shard.ShardId, shard.SyncState.PeerCount, submitted, submittedTime, dropped, failed, mismatchedCount, unfixedCount))
289289
}
290290
}
291291

@@ -311,7 +311,7 @@ func (d *dashboard) outputSummaryHtml(contract string, nodes map[string]*record,
311311
%s
312312
</table>
313313
</body>
314-
</html>`, contract, dstr, dataRang, content)
314+
</html>`, contract, dstr, dataRang, content.String())
315315

316316
msg := []byte(subject + body)
317317
auth := smtp.PlainAuth("", d.emailCfg.Username, d.emailCfg.Password, d.emailCfg.Host)

0 commit comments

Comments
 (0)