fix(esp_commands): Incorporate review comments

Author: SoucheSouche

esp_commands/.build-test-rules.yml

@@ -1,6 +1,3 @@
 esp_commands/test_apps:
   enable:
-    - if: (IDF_TARGET == "linux") and (IDF_VERSION_MAJOR == 5 and IDF_VERSION_MINOR >= 3)
-      reason: "Test the main logic of the component (not target dependent)"
-    - if: IDF_TARGET == "esp32"
-      reason: "Test the placement of statically registered commands in dedicated flash section"
+    - if: (IDF_TARGET in ["esp32", "linux"]) and (IDF_VERSION_MAJOR == 5 and IDF_VERSION_MINOR >= 3)

esp_commands/README.md

@@ -60,15 +60,15 @@ typedef struct esp_command {
 Use the `ESP_COMMAND_REGISTER` macro to register a command at compile time:
 
 ```c
-static int my_cmd(void *ctx, int argc, char **argv) {
+static int my_cmd(void *context, esp_commands_exec_arg_t *cmd_arg, int argc, char **argv) {
     printf("Hello from my_cmd!\n");
     return 0;
 }
 
 ESP_COMMAND_REGISTER(my_cmd, tools, "Prints hello", my_cmd, NULL, NULL, NULL);
 ```
 
-This places the command into the `.esp_commands` section.
+This places the command into the `.esp_commands` section in flash.
 
 ### Dynamic Registration
 

esp_commands/include/esp_commands.h

@@ -30,7 +30,7 @@ typedef ssize_t (*esp_commands_write_t)(int fd, const void *buf, size_t count);
  * command callback to execute properly
  */
 typedef struct esp_commands_exec_arg {
-    int out_fd; /*!< file descriptor that the command function has to use to output data */
+    int out_fd; /*!< file descriptor that the command function has to use to print data in the environment it was called from */
     esp_commands_write_t write_func; /*!< write function the command function has to use to output datga */
     void *dynamic_ctx; /*!< dynamic context passed to the command function */
 } esp_commands_exec_arg_t;

esp_commands/test_apps/pytest_esp_commands.py

@@ -10,6 +10,6 @@
     not bool(glob.glob(f'{Path(__file__).parent.absolute()}/build*/')),
     reason="Skip the idf version that did not build"
 )
-@idf_parametrize('target', ['linux'], indirect=['target'])
+@idf_parametrize('target', ['linux', 'esp32'], indirect=['target'])
 def test_esp_commands(dut) -> None:
     dut.run_all_single_board_cases()