Skip to content

LVGL dependency is not properly removed from noglib BSP variants (BSP-740) #677

@qsaramo

Description

@qsaramo

Board

esp32_p4_function_ev_board_noglib & esp32_p4_eye_noglib affected currently, but I expect every new noglib BSP release having this issue from now on.

Hardware Description

IDE Name

Operating System

Description

BSP noglib variants created in Espressif's CI have still LVGL dependency because component's manifest is not properly written back after removing dependencies from manifest_tree.

I have not investigated this thoroughly, but if I read the code correctly this is what happens when generating noglib variant of a BSP:

  • remove_esp_lvgl_port() gets manifest_tree
  • ManifestManager's manifest_tree property returns a dump generated from underlying model
  • LVGL dependencies are removed
  • when manager.dump() is called, it gets another manifest_tree dump from the underlying model and writes it onto disk.
    --> changes get lost

Sketch

  espressif/esp_lvgl_port:
    public: true
    version: ^2
  ...
  lvgl/lvgl: '>=8,<10'

Other Steps to Reproduce

No response

I have checked existing issues, README.md and ESP32 Forum

  • I confirm I have checked existing issues, online documentation and Troubleshooting guide.

Metadata

Metadata

Assignees

Labels

Type: BugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions