PHP 8 compatibility

Author: erikrause

RSCIExportPlugin.inc.php

@@ -89,8 +89,6 @@ function manage($args, $request) {
         return parent::manage($args, $request);
     }
 
-    private $_context;
-
     /**
      * Get the zip with XML for an issue.
      * @param $issueId int
@@ -115,7 +113,6 @@ function exportIssue($issueId, $context)
         $rsciExportFilters = $filterDao->getObjectsByGroup('issue=>rsci-xml');
         assert(count($rsciExportFilters) == 1); // Assert only a single serialization filter
         $exportFilter = array_shift($rsciExportFilters);
-        $context = Application::getRequest()->getContext();
         $exportSettings = array ('isExportArtTypeFromSectionAbbrev' => $this->getSetting($context->getId(), 'exportArtTypeFromSectionAbbrev'),
                                     'isExportSections' => $this->getSetting($context->getId(), 'exportSections'),
                                     'journalRSCITitleId' => $this->getSetting($context->getId(), 'journalRSCITitleId'));
@@ -213,7 +210,7 @@ function getExportPath()
         if ($this->_generatedTempPath === '')
         {
             $exportPath = parent::getExportPath();
-            $journal = Application::getRequest()->getJournal();
+            $journal = Registry::get('request', false)->getJournal();
             $this->_generatedTempPath =  $exportPath . $this->getPluginSettingsPrefix() . 'Temp-' . date('Ymd-His'). $journal->getId() . '/';
         }
         return $this->_generatedTempPath;

classes/form/RSCIExportSettingsForm.inc.php

@@ -83,12 +83,13 @@ function readInputData() {
     /**
      * Execute the form.
      */
-    function execute() {
+    function execute(...$functionArgs) {
         $plugin = $this->_getPlugin();
         $contextId = $this->_getContextId();
         foreach($this->getFormFields() as $fieldName => $fieldType) {
             $plugin->updateSetting($contextId, $fieldName, $this->getData($fieldName), $fieldType);
         }
+        parent::execute(...$functionArgs);
     }
 
 

filter/ArticleRSCIXmlFilter.inc.php

@@ -573,7 +573,7 @@ protected function _convertLocaleToISO639($locale)
 
         if ($lang3chars == '')
         {
-            $user = Application::getRequest()->getUser();
+            $user = Registry::get('request', false)->getUser();
             $notificationManager = new NotificationManager();
             $notificationManager->createTrivialNotification($user->getId(),
                 NOTIFICATION_TYPE_WARNING,
@@ -606,7 +606,7 @@ protected function _convertISO639ToLocale($lang3chars)
         }
 
         // If can't convert ISO639 to UNIX locale:
-        $user = Application::getRequest()->getUser();
+        $user = Registry::get('request', false)->getUser();
         $notificationManager = new NotificationManager();
         $notificationManager->createTrivialNotification($user->getId(),
                                             NOTIFICATION_TYPE_WARNING,
@@ -625,7 +625,7 @@ protected function _convertISO639ToLocale($lang3chars)
      */
     protected function _getISO639()
     {
-        if (!is_a($this->_iso, $this))
+        if (!isset($this->_iso))
         {
             require_once($_SERVER['DOCUMENT_ROOT'] . '/plugins/importexport/rsciexport/php-iso-639/src/ISO639.php'); // TODO: import without $_SERVER.
             $this->_iso = new ISO639();

version.xml

@@ -9,6 +9,6 @@
 <version>
     <application>rsciexport</application>
     <type>plugins.importexport</type>
-    <release>0.1.1.0</release>
+    <release>0.1.2.0</release>
     <date>2021-11-30</date>
 </version>