bug in model.Ising

failed to set calc_observables data member, which led to problems for systems with N>9, without Ising eqn files

Author: eltrompetero

RELEASE_NOTES

@@ -23,8 +23,10 @@ OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 SOFTWARE.
 
 
-v2.4.2 (To be released 2021/02)
+v2.4.2 (Released 2021/04)
 ----------------------------------------------------
+- Fixed instantiation bug in model.Ising (thanks to saynbabul for pointing this
+  out).
 
 v2.4.1 (Released 2021/01)
 ----------------------------------------------------

coniii/models.py

@@ -172,15 +172,14 @@ def __init__(self, multipliers, rng=None, n_cpus=None, verbose=False):
         else:
             raise Exception("Unrecognized format for multipliers.")
 
-        self.calc_e, _, _ = define_ising_helper_functions()
+        self.calc_e, self.calc_observables, _ = define_ising_helper_functions()
         try:
             ising = import_module('coniii.ising_eqn.ising_eqn_%d_sym'%self.n)
             self._calc_observables = ising.calc_observables
             self._calc_p = ising.p
         except ModuleNotFoundError:
             self._calc_observables = None
             self._calc_p = None
-            self.calc_observables = None
             self.calc_p = None
         self.set_multipliers(multipliers)