Fix/client disconnect (#493)

* added elixir tools to .gitiignore

* fix: Connection crash on disconnect

* Update grpc_client/lib/grpc/client/connection.ex

Co-authored-by: Paulo Valente <16843419+polvalente@users.noreply.github.com>

* Update grpc_client/lib/grpc/client/connection.ex

Co-authored-by: Paulo Valente <16843419+polvalente@users.noreply.github.com>

* check format

---------

Co-authored-by: Adriano Santos <adriano.santos@v3.com.br>
Co-authored-by: Paulo Valente <16843419+polvalente@users.noreply.github.com>

Author: 3 people

grpc_client/lib/grpc/client/connection.ex

@@ -234,8 +234,12 @@ defmodule GRPC.Client.Connection do
     resp = {:ok, %Channel{channel | adapter_payload: %{conn_pid: nil}}}
 
     if Map.has_key?(state, :real_channels) do
-      Enum.map(state.real_channels, fn {_key, {:ok, ch}} ->
-        adapter.disconnect(ch)
+      Enum.map(state.real_channels, fn
+        {_key, {:ok, ch}} ->
+          do_disconnect(adapter, ch)
+
+        _ ->
+          :ok
       end)
 
       keys_to_delete = [:real_channels, :virtual_channel]
@@ -303,6 +307,16 @@ defmodule GRPC.Client.Connection do
     {:global, {__MODULE__, ref}}
   end
 
+  defp do_disconnect(adapter, channel) do
+    adapter.disconnect(channel)
+  rescue
+    _ ->
+      :ok
+  catch
+    _type, _value ->
+      :ok
+  end
+
   defp build_initial_state(target, opts) do
     opts =
       Keyword.validate!(opts,

grpc_client/test/grpc/integration/connection_test.exs

@@ -45,4 +45,19 @@ defmodule GRPC.Integration.ConnectionTest do
       :ok = GRPC.Server.stop(server)
     end
   end
+
+  test "disconnecting a channel works" do
+    server = FeatureServer
+    {:ok, _, port} = GRPC.Server.start(server, 0)
+    {:ok, channel} = GRPC.Stub.connect("localhost:#{port}")
+
+    assert {:ok, _} =
+             Routeguide.RouteGuide.Stub.get_feature(channel, %Routeguide.Point{
+               latitude: 409_146_138,
+               longitude: -746_188_906
+             })
+
+    assert {:ok, _} = GRPC.Stub.disconnect(channel)
+    :ok = GRPC.Server.stop(server)
+  end
 end

grpc_server/lib/grpc/server/adapters/cowboy/handler.ex

@@ -628,9 +628,7 @@ defmodule GRPC.Server.Adapters.Cowboy.Handler do
 
   defp check_sent_resp(req, status \\ 200)
 
-  defp check_sent_resp(%{has_sent_resp: _} = req, status) do
-    req
-  end
+  defp check_sent_resp(%{has_sent_resp: _} = req, _status), do: req
 
   defp check_sent_resp(req, status) do
     :cowboy_req.stream_reply(status, req)