Address rabbitai review

Author: ekiefl

pooltool/physics/resolve/ball_ball/core.py

@@ -204,7 +204,6 @@ def resolve_continually_touching(
 
             # Chased ball steals fraction of chaser's line of centers momentum
             # FIXME: We assume equal mass, so transfer velocity directly
-            theft_fraction = theft_fraction
             stolen_loc_velocity = chaser_loc_vel * theft_fraction
 
             if ball1_is_chaser:

pooltool/physics/resolve/transition/__init__.py

@@ -15,7 +15,7 @@
 from pooltool.objects.ball.datatypes import Ball
 from pooltool.physics.resolve.models import BallTransitionModel
 
-TOLERANCE = 1e-12
+_TOLERANCE = 1e-12
 
 
 class BallTransitionStrategy(Protocol):
@@ -49,8 +49,8 @@ def resolve(self, ball: Ball, transition: EventType, inplace: bool = False) -> B
             # angular velocity components are nearly 0. Then set them to exactly 0.
             v = ball.state.rvw[1]
             w = ball.state.rvw[2]
-            assert (np.abs(v) < TOLERANCE).all()
-            assert (np.abs(w[:2]) < TOLERANCE).all()
+            assert (np.abs(v) < _TOLERANCE).all()
+            assert (np.abs(w[:2]) < _TOLERANCE).all()
 
             ball.state.rvw[1, :] = [0.0, 0.0, 0.0]
             ball.state.rvw[2, :2] = [0.0, 0.0]
@@ -60,8 +60,8 @@ def resolve(self, ball: Ball, transition: EventType, inplace: bool = False) -> B
             # set them to exactly 0.
             v = ball.state.rvw[1]
             w = ball.state.rvw[2]
-            assert (np.abs(v) < TOLERANCE).all()
-            assert (np.abs(w) < TOLERANCE).all()
+            assert (np.abs(v) < _TOLERANCE).all()
+            assert (np.abs(w) < _TOLERANCE).all()
 
             ball.state.rvw[1, :] = [0.0, 0.0, 0.0]
             ball.state.rvw[2, :] = [0.0, 0.0, 0.0]

tests/evolution/event_based/test_simulate.py

@@ -407,7 +407,7 @@ def true_time_to_collision(eps, V0, mu_r, g):
 
 
 def test_ball_ball_collision_for_intersecting_balls():
-    """Two already intersecting balls don't collide.
+    """Two already intersecting balls collide.
 
     Previously, intersecting balls were prevented from colliding to avoid perpetual
     internal collisions. Now, with the improved make_kiss implementation, intersecting