JDT Clean-up Use String.replace() instead of String.replaceAll() when

possible

In eclipse-platform/eclipse.platform.ui#3517
we discuss which automatic clean-ups we should add. This is the result
of a manual run in eclipse-platform to see if this clean-up has
issues. Also by running it manually before enabling the clean-ups we
avoid creating PR per bundle.

Author: vogella

ant/org.eclipse.ant.ui/Ant Tools Support/org/eclipse/ant/internal/ui/views/actions/SearchForBuildFilesDialog.java

@@ -387,11 +387,11 @@ class ResourceProxyVisitor implements IResourceProxyVisitor {
 			// The character "." must be escaped in regex
 			String input = getInput();
 			// replace "." with "\\."
-			input = input.replaceAll("\\.", "\\\\."); //$NON-NLS-1$ //$NON-NLS-2$
+			input = input.replace(".", "\\."); //$NON-NLS-1$ //$NON-NLS-2$
 			// replace "*" with ".*"
-			input = input.replaceAll("\\*", "\\.\\*"); //$NON-NLS-1$ //$NON-NLS-2$
+			input = input.replace("*", ".*"); //$NON-NLS-1$ //$NON-NLS-2$
 			// replace "?" with ".?"
-			input = input.replaceAll("\\?", "\\.\\?"); //$NON-NLS-1$ //$NON-NLS-2$
+			input = input.replace("?", ".?"); //$NON-NLS-1$ //$NON-NLS-2$
 			pattern = Pattern.compile(input);
 		}
 

debug/org.eclipse.ui.externaltools/External Tools Base/org/eclipse/ui/externaltools/internal/variables/BuildFilesResolver.java

@@ -123,7 +123,7 @@ public String resolveValue(IDynamicVariable variable, String argument) throws Co
 						// the filename so they don't conflict with these
 						// special quotes.
 						//
-						osPath = osPath.replaceAll("\"", "\\\\\""); //$NON-NLS-1$ //$NON-NLS-2$
+						osPath = osPath.replace("\"", "\\\""); //$NON-NLS-1$ //$NON-NLS-2$
 						fileList.append("\"" + osPath + "\""); //$NON-NLS-1$ //$NON-NLS-2$
 					}
 				}

team/bundles/org.eclipse.team.core/src/org/eclipse/team/core/ScmUrlImportDescription.java

@@ -59,7 +59,7 @@ public String getUrl() {
 	}
 
 	public URI getUri() {
-		return URI.create(url.replaceAll("\"", "")); //$NON-NLS-1$//$NON-NLS-2$
+		return URI.create(url.replace("\"", "")); //$NON-NLS-1$//$NON-NLS-2$
 	}
 
 	public void setUrl(String url) {

ua/org.eclipse.help.ui/src/org/eclipse/help/ui/internal/ContextHelpDialog.java

@@ -227,8 +227,8 @@ private Control createInfoArea(Composite parent) {
 		}
 		if (styledText == null && context.getText() != null) {
 			styledText = context.getText();
-			styledText= styledText.replaceAll("<b>","<@#\\$b>"); //$NON-NLS-1$ //$NON-NLS-2$
-			styledText= styledText.replaceAll("</b>", "</@#\\$b>"); //$NON-NLS-1$ //$NON-NLS-2$
+			styledText= styledText.replace("<b>","<@#$b>"); //$NON-NLS-1$ //$NON-NLS-2$
+			styledText= styledText.replace("</b>", "</@#$b>"); //$NON-NLS-1$ //$NON-NLS-2$
 		}
 		if (styledText == null) { // no description found in context objects.
 			styledText = Messages.ContextHelpPart_noDescription;

ua/org.eclipse.help.ui/src/org/eclipse/help/ui/internal/browser/embedded/EmbeddedBrowser.java

@@ -326,7 +326,7 @@ private void initializeStatusBar(Browser browser) {
 
 		// Text
 		browser.addStatusTextListener(event -> {
-			event.text = event.text.replaceAll("&", "&&"); //$NON-NLS-1$ //$NON-NLS-2$
+			event.text = event.text.replace("&", "&&"); //$NON-NLS-1$ //$NON-NLS-2$
 			if (!event.text.equals(statusText)) {
 				statusText = event.text;
 				statusBarText.setText(statusText);

ua/org.eclipse.help.ui/src/org/eclipse/help/ui/internal/util/EscapeUtils.java

@@ -43,7 +43,7 @@ public static String escapeSpecialCharsLeavinggBold(String value) {
 	}
 
 	public static String escapeAmpersand(String value) {
-		return value.replaceAll("&", "&"); //$NON-NLS-1$ //$NON-NLS-2$
+		return value.replace("&", "&"); //$NON-NLS-1$ //$NON-NLS-2$
 	}
 
 	/**

ua/org.eclipse.help.ui/src/org/eclipse/help/ui/internal/views/ContextHelpPart.java

@@ -702,8 +702,8 @@ private String decodeContextBoldTags(IContext context) {
 		if (styledText == null) {
 			return Messages.ContextHelpPart_noDescription;
 		}
-		String decodedString = styledText.replaceAll("<@#\\$b>", "<b>"); //$NON-NLS-1$ //$NON-NLS-2$
-		decodedString = decodedString.replaceAll("</@#\\$b>", "</b>"); //$NON-NLS-1$ //$NON-NLS-2$
+		String decodedString = styledText.replace("<@#$b>", "<b>"); //$NON-NLS-1$ //$NON-NLS-2$
+		decodedString = decodedString.replace("</@#$b>", "</b>"); //$NON-NLS-1$ //$NON-NLS-2$
 		decodedString = EscapeUtils.escapeSpecialCharsLeavinggBold(decodedString);
 		decodedString = decodedString.replaceAll("\r\n|\n|\r", "<br/>");  //$NON-NLS-1$ //$NON-NLS-2$
 		return decodedString;

ua/org.eclipse.help.webapp/src/org/eclipse/help/internal/webapp/servlet/EclipseConnector.java

@@ -342,8 +342,8 @@ private URLConnection openConnection(String url,
 				String jar = url.substring(0, excl);
 				String path = url.length() > excl + 2 ? url.substring(excl + 2)
 						: ""; //$NON-NLS-1$
-				url = jar.replaceAll("!", "%21") + "!/" //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$
-						+ path.replaceAll("!", "%21"); //$NON-NLS-1$ //$NON-NLS-2$
+				url = jar.replace("!", "%21") + "!/" //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$
+						+ path.replace("!", "%21"); //$NON-NLS-1$ //$NON-NLS-2$
 			}
 			helpURL = new URL(url);
 		}

ua/org.eclipse.ua.tests/base/org/eclipse/ua/tests/util/FileUtil.java

@@ -62,7 +62,7 @@ public static String readString(InputStream in) throws IOException {
 			String result = new String(out.toByteArray(), StandardCharsets.UTF_8);
 			if (result.length() > 0) {
 				// filter windows-specific newline
-				result = result.replaceAll("\r", "");
+				result = result.replace("\r", "");
 			}
 			// ignore whitespace at start or end
 			return result.trim();

ua/org.eclipse.ua.tests/base/org/eclipse/ua/tests/util/XHTMLUtil.java

@@ -36,7 +36,7 @@ public static String removeEnvironmentSpecificContent(String xhtml) {
 		 * becomes:
 		 * <myElement myAttribute="myValue"/>
 		 */
-		xhtml = xhtml.replaceAll(" />", "/>");
+		xhtml = xhtml.replace(" />", "/>");
 
 		/*
 		 * The base tag is added before showing in browser. It contains an