Switch back to using select.select by default (#141)

* Switch to using select by default

* Updated readme

* Fixed PEP8 warning

* Fixed issue caught in code review

Author: eandersson

CHANGELOG.rst

@@ -1,6 +1,10 @@
 Changelog
 =========
 
+Version 2.11.1
+--------------
+- Switch back to using select.select by default [#140].
+
 Version 2.11.0
 --------------
 - Added Python 3.13 support.

README.rst

@@ -15,6 +15,10 @@ AMQPStorm is a library designed to be consistent, stable and thread-safe.
 Changelog
 =========
 
+Version 2.11.1
+--------------
+- Switch back to using select.select by default [#140].
+
 Version 2.11.0
 --------------
 - Added Python 3.13 support.

amqpstorm/__init__.py

@@ -1,5 +1,5 @@
 """AMQPStorm."""
-__version__ = '2.11.0'  # noqa
+__version__ = '2.11.1'  # noqa
 __author__ = 'eandersson'  # noqa
 
 import logging

amqpstorm/compatibility.py

@@ -1,6 +1,5 @@
 """Python 2/3 Compatibility layer."""
 
-import select
 import sys
 
 try:
@@ -40,14 +39,6 @@ class DummyException(Exception):
     """
 
 
-def get_default_poller():
-    if hasattr(select, 'poll'):
-        return 'poll'
-    return 'select'
-
-
-DEFAULT_POLLER = get_default_poller()
-
 SSL_CERT_MAP = {}
 SSL_VERSIONS = {}
 SSL_OPTIONS = [

amqpstorm/connection.py

@@ -63,7 +63,7 @@ class Connection(Stateful):
     :param bool ssl: Enable SSL
     :param dict ssl_options: SSL kwargs
     :param dict client_properties: None or dict of client properties
-    :param str poller: select or poll
+    :param str poller: Either "select" or "poll". If you encounter file descriptor errors, consider switching to "poll".
     :param bool lazy: Lazy initialize the connection
 
     :raises AMQPConnectionError: Raises if the connection
@@ -87,7 +87,7 @@ def __init__(self, hostname, username, password, port=5672, **kwargs):
             'ssl': kwargs.get('ssl', False),
             'ssl_options': kwargs.get('ssl_options', {}),
             'client_properties': kwargs.get('client_properties', {}),
-            'poller': kwargs.get('poller', compatibility.DEFAULT_POLLER),
+            'poller': kwargs.get('poller', 'select'),
         }
         self._validate_parameters()
         self._io = IO(self.parameters, exceptions=self._exceptions,

amqpstorm/uri_connection.py

@@ -85,7 +85,7 @@ def _parse_uri_options(self, parsed_uri, use_ssl=False, ssl_options=None):
             'heartbeat': int(kwargs.pop('heartbeat',
                                         [DEFAULT_HEARTBEAT_TIMEOUT])[0]),
             'poller': kwargs.pop('poller',
-                                 [compatibility.DEFAULT_POLLER])[0],
+                                 ['select'])[0],
             'timeout': int(kwargs.pop('timeout',
                                       [DEFAULT_SOCKET_TIMEOUT])[0])
         }