Doctrine decimal type getters and setters now always use string values

Author: hlecorche

UPGRADE-4.0.md

@@ -1,5 +1,9 @@
 # UPGRADE FROM 3.x to 4.0
 
+## Main
+
+* Doctrine decimal type getters and setters now always use string values
+
 ## Template
 
 * When generating getters/setters for a field, the `types` variable passed to the Twig template no longer exists.

templates/Theme/base.php.twig

@@ -65,13 +65,6 @@
     {% endif %}
 {% endblock %}
 
-{% block field_hint_decimal %}
-{# Decimal Doctrine type is a PHP string but user can give a double value - Remove hint unless hint equals "string" on the property PHP hint #}
-{% if phpType and (phpType.__toString() == '?string' or phpType.__toString() == 'string') %}
-    ?string
-{% endif %}
-{% endblock %}
-
 {% block field_set %}
     public function {{ methodName }}({{ (block('field_hint')|spaceless) ? block('field_hint')|spaceless ~ ' ' : '' }}${{ variableName }}): self
     {

tests/App/Entity/SubClass.php

@@ -57,9 +57,6 @@ class SubClass extends MainClass
     #[ORM\Column(type: 'decimal', precision: 5, scale: 2)]
     protected ?string $decimalField;
 
-    #[ORM\Column(type: 'decimal', precision: 5, scale: 2)]
-    protected $decimalFieldWithoutHint;
-
     #[ORM\Column(type: 'datetime')]
     protected ?\DateTime $dateField = null;
 

tests/App/GeneratedEntity/SubClass.php

@@ -58,9 +58,6 @@ class SubClass extends MainClass
     #[ORM\Column(type: 'decimal', precision: 5, scale: 2)]
     protected ?string $decimalField;
 
-    #[ORM\Column(type: 'decimal', precision: 5, scale: 2)]
-    protected $decimalFieldWithoutHint;
-
     #[ORM\Column(type: 'datetime')]
     protected ?\DateTime $dateField = null;
 
@@ -132,18 +129,6 @@ public function getDecimalField(): ?string
         return $this->decimalField;
     }
 
-    public function setDecimalFieldWithoutHint($decimalFieldWithoutHint): self
-    {
-        $this->decimalFieldWithoutHint = $decimalFieldWithoutHint;
-
-        return $this;
-    }
-
-    public function getDecimalFieldWithoutHint()
-    {
-        return $this->decimalFieldWithoutHint;
-    }
-
     public function setDateField(?\DateTime $dateField): self
     {
         $this->dateField = $dateField;

tests/GeneratedEntityTest.php

@@ -116,17 +116,6 @@ public function testDecimalField(): void
         $this->assertSame('0.55', $subClass->getDecimalField());
     }
 
-    public function testDecimalFieldWithoutHint(): void
-    {
-        $subClass = $this->createSubClass(2);
-        $this->assertSame(0.65, $subClass->getDecimalFieldWithoutHint());
-        $this->em->flush();
-        $this->em->clear();
-
-        $subClass = $this->em->getRepository(SubClass::class)->find(2);
-        $this->assertSame('0.65', $subClass->getDecimalFieldWithoutHint());
-    }
-
     public function testDateField(): void
     {
         $subClass = $this->createSubClass(2);
@@ -178,7 +167,6 @@ public static function getTestSetNullFieldProvider(): array
             ['setName', 'getName'],
             ['setNameWithoutHint', 'getNameWithoutHint'],
             ['setDecimalField', 'getDecimalField'],
-            ['setDecimalFieldWithoutHint', 'getDecimalFieldWithoutHint'],
             ['setDateField', 'getDateField'],
             ['setBooleanField', 'getBooleanField'],
             ['setTextField', 'getTextField'],
@@ -564,7 +552,6 @@ protected function createSubClass(int $id, ?Initializer1 $firstInitializer = nul
             ->setFirstInitializer($firstInitializer)
             ->setSecondInitializer($secondInitializer)
             ->setDecimalField('0.55')
-            ->setDecimalFieldWithoutHint(0.65) // Give a double - Doctrine will return string
             ->setDateField(new \DateTime('2020-01-01 00:00:00'))
             ->setBooleanField(true)
             ->setTextField('Text '.$id)