fix: lint error

Author: dxphilo

biome.json

@@ -17,10 +17,10 @@
     "rules": {
       "recommended": true,
       "suspicious": {
-        "noGlobalIsNan": "off"
+        "noGlobalIsNan": "warn"
       },
       "correctness": {
-        "noUnusedFunctionParameters": "off"
+        "noUnusedFunctionParameters": "warn"
       }
     }
   },

src/controllers/banks.ts

@@ -1,4 +1,4 @@
-import { Request, Response, Router, RequestHandler } from "express";
+import { type Request, type Response, Router, type RequestHandler } from "express";
 import {
     commercialBanks,
     mortgageFinanceInstitutions,

src/controllers/counties.ts

@@ -13,7 +13,7 @@ const counties_data = (req: Request, res: Response): void => {
     return;
   }
 
-  if (isNaN(county_code)) {
+  if (Number.isNaN(county_code)) {
     const error_message = "Invalid County code";
     res.status(400).json(createErrorResponse(error_message));
     return;

src/controllers/country.ts

@@ -4,7 +4,7 @@ import { createSuccessResponse } from "../utilities/error";
 
 const router = Router();
 
-const country_data = (req: Request, res: Response): void => {
+const country_data = (_req: Request, res: Response): void => {
   res.status(200).json(createSuccessResponse(countryInfo));
 };
 

src/controllers/health_check.ts

@@ -46,7 +46,7 @@ export async function pingHealthEndpoint() {
     }
   }
 }
-const health_check = (req: Request, res: Response): void => {
+const health_check = (_req: Request, res: Response): void => {
   res.json({
     Status: "OK 👍",
     Name: "Kenya API",

src/controllers/postal_codes.ts

@@ -13,7 +13,7 @@ const postal_data = (req: Request, res: Response): void => {
     return;
   }
 
-  if (!isNaN(postal_code)) {
+  if (!Number.isNaN(postal_code)) {
     const found_post: PostalCode | undefined = postal_stations.find(
       (post) => post.code === postal_code
     );

src/controllers/towns.ts

@@ -4,7 +4,7 @@ import { createSuccessResponse } from "../utilities/error";
 
 const router = Router();
 
-const towns_data = (req: Request, res: Response): void => {
+const towns_data = (_req: Request, res: Response): void => {
   res.status(200).json(createSuccessResponse(towns));
   return;
 };

src/middlewares/loggingMiddleware.ts

@@ -3,7 +3,7 @@ import { debug } from '../utilities/debug';
 
 export function loggingMiddleware(
     req: Request,
-    res: Response,
+    _res: Response,
     next: NextFunction
 ) {
     debug(`${req.method}: ${req.originalUrl}`);

tests/api_tests/banks.test.ts

@@ -6,48 +6,48 @@ describe('GET => /api/v1/banks', () => {
         console.log('Server setup complete for banks tests');
     });
 
-    it('Should return 200 and all banks when no query is passed', async function () {
+    it('Should return 200 and all banks when no query is passed', async () => {
         await supertest(app)
             .get('/api/v1/banks')
             .expect(200);
     });
 
-    it('Should return 200 and only commercial banks', async function () {
+    it('Should return 200 and only commercial banks', async () => {
         await supertest(app)
             .get('/api/v1/banks')
             .query({ bank_type: 'commercial' })
             .expect(200);
     });
 
-    it('Should return 400 for invalid bank type', async function () {
+    it('Should return 400 for invalid bank type', async () => {
         await supertest(app)
             .get('/api/v1/banks')
             .query({ bank_type: 'invalid-type' })
             .expect(400);
     });
 
-    it('Should filter by bank_name', async function () {
+    it('Should filter by bank_name', async () => {
         await supertest(app)
             .get('/api/v1/banks')
             .query({ bank_name: 'equity' })
             .expect(200);
     });
 
-    it('Should filter by ussd only in commercial banks', async function () {
+    it('Should filter by ussd only in commercial banks', async () => {
         await supertest(app)
             .get('/api/v1/banks')
             .query({ ussd: "*224#" })
             .expect(200);
     });
 
-    it('Should filter by paybill', async function () {
+    it('Should filter by paybill', async () => {
         await supertest(app)
             .get('/api/v1/banks')
             .query({ paybill: '111777' })
             .expect(200);
     });
 
-    it('Should return 404 when no bank matches the query', async function () {
+    it('Should return 404 when no bank matches the query', async () => {
         await supertest(app)
             .get('/api/v1/banks')
             .query({ bank_name: 'nonexistent-bank' })