add osgi metadata to the jar

[zspitzer]

The current MANIFEST.MF doesn't include OSGI metadata

Manifest-Version: 1.0
Created-By: 1.8.0_452 (Red Hat, Inc.)

I had a look into the source, but I'm not familiar with using the make approach

Ideally it would look something like this?

Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: DuckDB JDBC Driver
Bundle-SymbolicName: org.duckdb.duckdb_jdbc
Bundle-Version: 1.3.1.0
Bundle-Vendor: DuckDB Labs
Bundle-Description: A JDBC-Compliant driver for the DuckDB data management system
Bundle-License: https://raw.githubusercontent.com/duckdb/duckdb/main/LICENSE
Bundle-DocURL: https://www.duckdb.org
Bundle-ContactAddress: mark@duckdblabs.com
Bundle-Copyright: Copyright (c) DuckDB Labs
Export-Package: org.duckdb;version="1.3.1.0"
Import-Package: java.sql,javax.sql,org.osgi.framework;resolution:=optional

[staticlibs]

@zspitzer

Yes, I think it is a good idea to add more metadata there. Just I wonder are there any tools that consume this metadata that I can use for testing it? Can I do this from Eclipse UI somehow? Or should I setup a project with Equinox?

[zspitzer]

Here's a nifty single page docker compose to try the jar with Lucee

I'm the community manager for Lucee, one of our users was asking about how to use DuckDB JDBC with Lucee

https://dev.lucee.org/t/duck-db/15193

Just run it with docker compose up from a folder with the jar file and open http://localhost:7006/

Edit the version number 1.3.1.0 when trying your local build once you have added osgi metadata

https://gist.github.com/zspitzer/79a06651cf53cd26f53627072e2c3a6d

[staticlibs]

@zspitzer

I've added the input manifest file to the JAR build process in #290. When it is included, it is formatted this way:

Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: DuckDB JDBC Driver
Bundle-SymbolicName: org.duckdb.duckdb_jdbc
Bundle-Version: 1.4.0.0
Bundle-Vendor: DuckDB Labs
Bundle-Description: A JDBC-Compliant driver for the DuckDB data manageme
 nt system
Bundle-License: https://raw.githubusercontent.com/duckdb/duckdb/main/LIC
 ENSE
Bundle-DocURL: https://www.duckdb.org
Bundle-ContactAddress: mark@duckdblabs.com
Bundle-Copyright: Copyright (c) DuckDB Labs
Export-Package: org.duckdb;version="1.4.0.0"
Import-Package: java.sql,javax.sql,org.osgi.framework;resolution:=option
 al
Created-By: 17.0.15 (Amazon.com Inc.)

Its contents (including the continuation lines) looks correct to me, but I cannot get past the error message in the docker compose you provided. So please let me know if the input manifest will require corrections.

PS: the main branch in JDBC is not buildable right now due to breaking changes introduced in duckdb/duckdb#17772, it should become buildable after the next successful import of latest engine sources.

[zspitzer]

@staticlibs what's the docker compose error? It works for me on Almalinux and Windows?

[staticlibs]

@zspitzer

The build has run through on the updated main, I wonder if you can check the binaries at the bottom of this page (they use version 1.4.0.0)?

[zspitzer]

It seems the java.sql isn't need for Import-Package, my bad.

I edited that out and it's kinda working for me, but I am seeing something odd with the loading of the osgi bundle, I'll need some advice from @michaeloffner on this

[zspitzer]

Update: having success with the following!

Export-Package: org.duckdb,
 org.duckdb.io,
 org.duckdb.user

memory works great, with file dsn, I'm getting

     [java]    [script] Caused by: java.io.IOException: java.sql.SQLException: IO Error: Extension "C:\Users\zacsp\.duckdb\extensions\7b1a12cbc3\windows_amd64\file.duckdb_extension" not found.
     [java]    [script]
     [java]    [script] Candidate extensions: "inet", "sqlite", "sqlite3", "iceberg", "ui"
     [java]    [script]         ... 141 more
     [java]    [script] Caused by: java.sql.SQLException: IO Error: Extension "C:\Users\zacsp\.duckdb\extensions\7b1a12cbc3\windows_amd64\file.duckdb_extension" not found.
     [java]    [script]
     [java]    [script] Candidate extensions: "inet", "sqlite", "sqlite3", "iceberg", "ui"
     [java]    [script]         at org.duckdb.DuckDBNative.duckdb_jdbc_startup(Native Method)
     [java]    [script]         at org.duckdb.DuckDBConnection.newConnection(DuckDBConnection.java:62)
     [java]    [script]         at org.duckdb.DuckDBDriver.connect(DuckDBDriver.java:114)
     [java]    [script]         at lucee.runtime.db.DataSourceSupport._getConnection(DataSourceSupport.java:150)
     [java]    [script]         at lucee.runtime.db.DataSourceSupport.getConnection(DataSourceSupport.java:111)
     [java]    [script]         at lucee.runtime.db.DatasourceConnectionFactory.create(DatasourceConnectionFactory.java:58)
     [java]    [script]         ... 140 more

this is the DSN I'm using? same error without the test.sqlite filename, was just playing

jdbc:duckdb:file:d:\work\script-runner\temp\lucee\lucee-server\context\temp\D8DE6FBA-5944-496A-93F063374CB16219\test.sqlite

same problem with using // instead of \

[staticlibs]

@zspitzer

I've updated Export-Package (binaries should be ready in half an hour), please let me know if I need to update Import-Package too.

jdbc:duckdb:file:d:\work...

This URL is incorrect, it should be either:

jdbc:duckdb:d:\work...

for DuckDB file database, or:

jdbc:duckdb:sqlite:d:\work...

for SQLite database.

[zspitzer]

Thanks for the pointers about the connection string, I didn't wrap my head around the fact the example from the docs didn't have a file extension https://duckdb.org/docs/stable/clients/java#configuring-connections, seems any random file extension works.

Please go ahead and remove the java.sql from the Import-packages

With the that edited out of the linux jar, all my tests are passing

https://github.com/lucee/extension-jdbc-duckdb/actions/runs/15877077423/job/44767219304#step:9:232

[staticlibs]

@zspitzer

Updated #290 PR removing java.sql.

[zspitzer]

@staticlibs LGTM! Thanks