Remove PathFeatures.cs and all references

Copilot · jkotas · Copilot · commit 42c6c672abe6 · 2025-10-21T03:51:56.000Z
Co-authored-by: jkotas &lt;6668460+jkotas@users.noreply.github.com&gt;
diff --git a/src/libraries/Common/tests/System/IO/PathFeatures.cs b/src/libraries/Common/tests/System/IO/PathFeatures.cs
diff --git a/src/libraries/System.Diagnostics.Process/tests/ProcessModuleTests.Windows.cs b/src/libraries/System.Diagnostics.Process/tests/ProcessModuleTests.Windows.cs
@@ -10,7 +10,7 @@ namespace System.Diagnostics.Tests
 {
     public partial class ProcessModuleTests : ProcessTestBase
     {
-        [ConditionalFact(typeof(PathFeatures), nameof(PathFeatures.AreAllLongPathsAvailable))]
+        [Fact]
         public void LongModuleFileNamesAreSupported()
         {
             // To be able to test Long Path support for ProcessModule.FileName we need a .dll that has a path > 260 chars.
diff --git a/src/libraries/System.Diagnostics.Process/tests/System.Diagnostics.Process.Tests.csproj b/src/libraries/System.Diagnostics.Process/tests/System.Diagnostics.Process.Tests.csproj
@@ -20,8 +20,6 @@
              Link="Common\Microsoft\Win32\TempRegistryKey.cs" />
     <Compile Include="$(CommonPath)System\Text\ValueStringBuilder.cs"
              Link="Common\System\Text\ValueStringBuilder.cs" />
-    <Compile Include="$(CommonTestPath)System\IO\PathFeatures.cs"
-             Link="Common\System\IO\PathFeatures.cs" />
     <Compile Include="DelegateSynchronizeInvoke.cs" />
     <Compile Include="FileAssociations.cs" />
     <Compile Include="Helpers.cs" />
diff --git a/src/libraries/System.IO.Compression/tests/System.IO.Compression.Tests.csproj b/src/libraries/System.IO.Compression/tests/System.IO.Compression.Tests.csproj
@@ -29,7 +29,6 @@
     <Compile Include="ZipArchive\zip_ReadTests.cs" />
     <Compile Include="ZipArchive\zip_UpdateTests.cs" />
     <Compile Include="ZipArchive\zip_UpdateTests.Comments.cs" />
-    <Compile Include="$(CommonTestPath)System\IO\PathFeatures.cs" Link="Common\System\IO\PathFeatures.cs" />
     <Compile Include="$(CommonTestPath)System\IO\CallTrackingStream.cs" Link="Common\System\IO\CallTrackingStream.cs" />
     <Compile Include="$(CommonTestPath)System\IO\Compression\CRC.cs" Link="Common\System\IO\Compression\CRC.cs" />
     <Compile Include="$(CommonTestPath)System\IO\Compression\CompressionStreamTestBase.cs" Link="Common\System\IO\Compression\CompressionStreamTestBase.cs" />
diff --git a/src/libraries/System.IO.Compression/tests/ZipArchive/zip_ManualAndCompatibilityTests.cs b/src/libraries/System.IO.Compression/tests/ZipArchive/zip_ManualAndCompatibilityTests.cs
@@ -10,7 +10,7 @@ namespace System.IO.Compression.Tests
 {
     public class zip_ManualAndCompatibilityTests : ZipFileTestBase
     {
-        public static bool IsUsingNewPathNormalization => !PathFeatures.IsUsingLegacyPathNormalization();
+        public static bool IsUsingNewPathNormalization => true;
 
         public static IEnumerable<object[]> Get_CompatibilityTests_Data()
         {
diff --git a/src/libraries/System.Runtime/tests/System.IO.FileSystem.Tests/DisabledFileLockingTests/System.IO.FileSystem.DisabledFileLocking.Tests.csproj b/src/libraries/System.Runtime/tests/System.IO.FileSystem.Tests/DisabledFileLockingTests/System.IO.FileSystem.DisabledFileLocking.Tests.csproj
@@ -23,7 +23,6 @@
     <Compile Include="..\PortedCommon\IOServices.cs" />
     <Compile Include="$(CommonPath)DisableRuntimeMarshalling.cs"
              Link="Common\DisableRuntimeMarshalling.cs" />
-    <Compile Include="$(CommonTestPath)System\IO\PathFeatures.cs" Link="Common\System\IO\PathFeatures.cs" />
     <Compile Include="$(CommonTestPath)Tests\TheoryDataExtensions.cs" Link="Common\Tests\TheoryDataExtensions.cs" />
     <Compile Include="$(CommonTestPath)TestUtilities\System\DisableParallelization.cs" Link="Common\TestUtilities\System\DisableParallelization.cs" />
   </ItemGroup>
diff --git a/src/libraries/System.Runtime/tests/System.IO.FileSystem.Tests/FileSystemTest.cs b/src/libraries/System.Runtime/tests/System.IO.FileSystem.Tests/FileSystemTest.cs
@@ -11,11 +11,11 @@ public abstract partial class FileSystemTest : FileCleanupTestBase
     {
         public static readonly byte[] TestBuffer = { 0xBA, 0x5E, 0xBA, 0x11, 0xF0, 0x07, 0xBA, 0x11 };
 
-        public static bool AreAllLongPathsAvailable => PathFeatures.AreAllLongPathsAvailable();
+        public static bool AreAllLongPathsAvailable => true;
 
-        public static bool LongPathsAreNotBlocked => !PathFeatures.AreLongPathsBlocked();
+        public static bool LongPathsAreNotBlocked => true;
 
-        public static bool UsingNewNormalization => !PathFeatures.IsUsingLegacyPathNormalization();
+        public static bool UsingNewNormalization => true;
 
         public static bool ReservedDeviceNamesAreBlocked => PlatformDetection.IsWindows && !PlatformDetection.IsWindows10OrLater;
 
diff --git a/src/libraries/System.Runtime/tests/System.IO.FileSystem.Tests/System.IO.FileSystem.Tests.csproj b/src/libraries/System.Runtime/tests/System.IO.FileSystem.Tests/System.IO.FileSystem.Tests.csproj
@@ -240,7 +240,6 @@
     <Compile Include="$(CommonPath)Interop\Windows\Kernel32\Interop.GenericOperations.cs" Link="Interop\Windows\Interop.GenericOperations.cs" />
     <Compile Include="$(CommonTestPath)System\Buffers\NativeMemoryManager.cs" Link="Common\System\Buffers\NativeMemoryManager.cs" />
     <Compile Include="$(CommonTestPath)System\IO\TempFile.cs" Link="Common\System\IO\TempFile.cs" />
-    <Compile Include="$(CommonTestPath)System\IO\PathFeatures.cs" Link="Common\System\IO\PathFeatures.cs" />
     <Content Include="DirectoryInfo\test-dir\dummy.txt" Link="test-dir\dummy.txt" />
     <Compile Include="$(CommonPath)System\IO\PathInternal.CaseSensitivity.cs" Link="Common\System\IO\PathInternal.CaseSensitivity.cs" />
     <Compile Include="$(CommonTestPath)System\IO\ReparsePointUtilities.cs" Link="Common\System\IO\ReparsePointUtilities.cs" />
diff --git a/src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System.Runtime.Extensions.Tests.csproj b/src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System.Runtime.Extensions.Tests.csproj
@@ -87,7 +87,6 @@
     <Compile Include="$(CommonPath)Interop\Unix\Interop.Libraries.cs" Link="Common\Interop\Unix\Interop.Libraries.cs" />
     <Compile Include="$(CommonTestPath)System\Diagnostics\DebuggerAttributes.cs" Link="Common\System\Diagnostics\DebuggerAttributes.cs" />
     <Compile Include="$(CommonTestPath)System\GenericMathTestMemberData.cs" Link="Common\System\GenericMathTestMemberData.cs" />
-    <Compile Include="$(CommonTestPath)System\IO\PathFeatures.cs" Link="Common\System\IO\PathFeatures.cs" />
     <Compile Include="$(CommonTestPath)System\ShouldNotBeInvokedException.cs" Link="Common\System\ShouldNotBeInvokedException.cs" />
     <Compile Include="$(CommonTestPath)System\Security\Cryptography\ByteUtils.cs" Link="Common\System\Security\Cryptography\ByteUtils.cs" />
   </ItemGroup>
diff --git a/src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/IO/PathTestsBase.cs b/src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/IO/PathTestsBase.cs
@@ -187,11 +187,11 @@ public class PathTestsBase
         // TODO: Include \\.\ as well
         public static TheoryData<string, string> TestData_GetPathRoot_DevicePaths => new TheoryData<string, string>
         {
-            { @"\\?\UNC\test\unc\path\to\something", PathFeatures.IsUsingLegacyPathNormalization() ? @"\\?\UNC" : @"\\?\UNC\test\unc" },
-            { @"\\?\UNC\test\unc", PathFeatures.IsUsingLegacyPathNormalization() ? @"\\?\UNC" : @"\\?\UNC\test\unc" },
-            { @"\\?\UNC\a\b1", PathFeatures.IsUsingLegacyPathNormalization() ? @"\\?\UNC" : @"\\?\UNC\a\b1" },
-            { @"\\?\UNC\a\b2\", PathFeatures.IsUsingLegacyPathNormalization() ? @"\\?\UNC" : @"\\?\UNC\a\b2" },
-            { @"\\?\C:\foo\bar.txt", PathFeatures.IsUsingLegacyPathNormalization() ? @"\\?\C:" : @"\\?\C:\" }
+            { @"\\?\UNC\test\unc\path\to\something", @"\\?\UNC\test\unc" },
+            { @"\\?\UNC\test\unc", @"\\?\UNC\test\unc" },
+            { @"\\?\UNC\a\b1", @"\\?\UNC\a\b1" },
+            { @"\\?\UNC\a\b2\", @"\\?\UNC\a\b2" },
+            { @"\\?\C:\foo\bar.txt", @"\\?\C:\" }
         };
 
         public static TheoryData<string, string> TestData_GetPathRoot_Windows => new TheoryData<string, string>
diff --git a/src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/IO/PathTests_Windows.cs b/src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/IO/PathTests_Windows.cs
@@ -16,14 +16,7 @@ public class PathTests_Windows : PathTestsBase
         [Fact]
         public void GetDirectoryName_DevicePath()
         {
-            if (PathFeatures.IsUsingLegacyPathNormalization())
-            {
-                Assert.Equal(@"\\?\C:", Path.GetDirectoryName(@"\\?\C:\foo"));
-            }
-            else
-            {
-                Assert.Equal(@"\\?\C:\", Path.GetDirectoryName(@"\\?\C:\foo"));
-            }
+            Assert.Equal(@"\\?\C:\", Path.GetDirectoryName(@"\\?\C:\foo"));
         }
 
         [Theory, MemberData(nameof(TestData_GetDirectoryName_Windows))]
@@ -101,15 +94,8 @@ public void GetFullPath_NormalizedLongPathTooLong()
                 longPath.Append(Path.DirectorySeparatorChar).Append('a').Append(Path.DirectorySeparatorChar).Append('.');
             }
 
-            if (PathFeatures.AreAllLongPathsAvailable())
-            {
-                // Now no longer throws unless over ~32K
-                Assert.NotNull(Path.GetFullPath(longPath.ToString()));
-            }
-            else
-            {
-                Assert.Throws<PathTooLongException>(() => Path.GetFullPath(longPath.ToString()));
-            }
+            // Now no longer throws unless over ~32K
+            Assert.NotNull(Path.GetFullPath(longPath.ToString()));
         }
 
         [Theory,
@@ -120,32 +106,17 @@ public void GetFullPath_NormalizedLongPathTooLong()
             InlineData(@"\ .\")]
         public void GetFullPath_LegacyArgumentExceptionPaths(string path)
         {
-            if (PathFeatures.IsUsingLegacyPathNormalization())
-            {
-                // We didn't allow these paths on < 4.6.2
-                AssertExtensions.Throws<ArgumentException>(null, () => Path.GetFullPath(path));
-            }
-            else
-            {
-                // These paths are legitimate Windows paths that can be created without extended syntax.
-                // We now allow them through.
-                Path.GetFullPath(path);
-            }
+            // These paths are legitimate Windows paths that can be created without extended syntax.
+            // We now allow them through.
+            Path.GetFullPath(path);
         }
 
         [Fact]
         public void GetFullPath_MaxPathNotTooLong()
         {
             string value = @"C:\" + new string('a', 255) + @"\";
-            if (PathFeatures.AreAllLongPathsAvailable())
-            {
-                // Shouldn't throw anymore
-                Path.GetFullPath(value);
-            }
-            else
-            {
-                Assert.Throws<PathTooLongException>(() => Path.GetFullPath(value));
-            }
+            // Shouldn't throw anymore
+            Path.GetFullPath(value);
         }
 
         [Fact]
@@ -173,31 +144,15 @@ public void GetFullPath_StrangeButLegalPaths()
             // (such as "md ...\"). We used to filter these out, but now allow them to prevent apps from
             // being blocked when they hit these paths.
             string curDir = Directory.GetCurrentDirectory();
-            if (PathFeatures.IsUsingLegacyPathNormalization())
-            {
-                // Legacy path Path.GetFullePath() ignores . when there is less or more that two, when there is .. in the path it returns one directory up.
-                Assert.Equal(
-                    Path.GetFullPath(curDir + Path.DirectorySeparatorChar),
-                    Path.GetFullPath(curDir + Path.DirectorySeparatorChar + ". " + Path.DirectorySeparatorChar));
-                Assert.Equal(
-                    Path.GetFullPath(Path.GetDirectoryName(curDir) + Path.DirectorySeparatorChar),
-                    Path.GetFullPath(curDir + Path.DirectorySeparatorChar + "..." + Path.DirectorySeparatorChar));
-                Assert.Equal(
-                    Path.GetFullPath(Path.GetDirectoryName(curDir) + Path.DirectorySeparatorChar),
-                    Path.GetFullPath(curDir + Path.DirectorySeparatorChar + ".. " + Path.DirectorySeparatorChar));
-            }
-            else
-            {
-                Assert.NotEqual(
-                    Path.GetFullPath(curDir + Path.DirectorySeparatorChar),
-                    Path.GetFullPath(curDir + Path.DirectorySeparatorChar + ". " + Path.DirectorySeparatorChar));
-                Assert.NotEqual(
-                    Path.GetFullPath(Path.GetDirectoryName(curDir) + Path.DirectorySeparatorChar),
-                    Path.GetFullPath(curDir + Path.DirectorySeparatorChar + "..." + Path.DirectorySeparatorChar));
-                Assert.NotEqual(
-                    Path.GetFullPath(Path.GetDirectoryName(curDir) + Path.DirectorySeparatorChar),
-                    Path.GetFullPath(curDir + Path.DirectorySeparatorChar + ".. " + Path.DirectorySeparatorChar));
-            }
+            Assert.NotEqual(
+                Path.GetFullPath(curDir + Path.DirectorySeparatorChar),
+                Path.GetFullPath(curDir + Path.DirectorySeparatorChar + ". " + Path.DirectorySeparatorChar));
+            Assert.NotEqual(
+                Path.GetFullPath(Path.GetDirectoryName(curDir) + Path.DirectorySeparatorChar),
+                Path.GetFullPath(curDir + Path.DirectorySeparatorChar + "..." + Path.DirectorySeparatorChar));
+            Assert.NotEqual(
+                Path.GetFullPath(Path.GetDirectoryName(curDir) + Path.DirectorySeparatorChar),
+                Path.GetFullPath(curDir + Path.DirectorySeparatorChar + ".. " + Path.DirectorySeparatorChar));
         }
 
         [Theory,
@@ -237,13 +192,6 @@ public void GetFullPath_StrangeButLegalPaths()
             InlineData(@"\\.\C:\Foo2\..")]
         public void GetFullPath_ValidExtendedPaths(string path)
         {
-            if (PathFeatures.IsUsingLegacyPathNormalization())
-            {
-                // Legacy Path doesn't support any of these paths.
-                AssertExtensions.ThrowsAny<ArgumentException, NotSupportedException>(() => Path.GetFullPath(path));
-                return;
-            }
-
             // None of these should throw
             if (path.StartsWith(@"\\?\"))
             {
@@ -293,22 +241,14 @@ public static void GetFullPath_ValidLegacy_ValidExtendedPaths(string path)
             InlineData(@"\\.\UNC\LOCALHOST\  shareL\", @"\\.\UNC\LOCALHOST\  shareL\")]
         public void GetFullPath_UNC_Valid(string path, string expected)
         {
-            if (path.StartsWith(@"\\?\") && PathFeatures.IsUsingLegacyPathNormalization())
-            {
-                AssertExtensions.Throws<ArgumentException>(null, () => Path.GetFullPath(path));
-            }
-            else
-            {
-                Assert.Equal(expected, Path.GetFullPath(path));
-            }
+            Assert.Equal(expected, Path.GetFullPath(path));
         }
 
         [Theory,
-            InlineData(@"\\.\UNC\LOCALHOST\shareI\. ", @"\\.\UNC\LOCALHOST\shareI\", @"\\.\UNC\LOCALHOST\shareI"),
-            InlineData(@"\\.\UNC\LOCALHOST\shareJ\.. ", @"\\.\UNC\LOCALHOST\shareJ\", @"\\.\UNC\LOCALHOST")]
-        public static void GetFullPath_Windows_UNC_Valid_LegacyPathSupport(string path, string normalExpected, string legacyExpected)
+            InlineData(@"\\.\UNC\LOCALHOST\shareI\. ", @"\\.\UNC\LOCALHOST\shareI\"),
+            InlineData(@"\\.\UNC\LOCALHOST\shareJ\.. ", @"\\.\UNC\LOCALHOST\shareJ\")]
+        public static void GetFullPath_Windows_UNC_Valid_LegacyPathSupport(string path, string expected)
         {
-            string expected = PathFeatures.IsUsingLegacyPathNormalization() ? legacyExpected : normalExpected;
             Assert.Equal(expected, Path.GetFullPath(path));
         }
 
@@ -333,14 +273,11 @@ public static void GetFullPath_Windows_83Paths()
                     Assert.Equal(tempFilePath, shortName);
 
                     // Should work with device paths that aren't well-formed extended syntax
-                    if (!PathFeatures.IsUsingLegacyPathNormalization())
-                    {
-                        Assert.Equal(@"\\.\" + tempFilePath, Path.GetFullPath(@"\\.\" + shortName));
-                        Assert.Equal(@"\\?\" + tempFilePath, Path.GetFullPath(@"//?/" + shortName));
+                    Assert.Equal(@"\\.\" + tempFilePath, Path.GetFullPath(@"\\.\" + shortName));
+                    Assert.Equal(@"\\?\" + tempFilePath, Path.GetFullPath(@"//?/" + shortName));
 
-                        // Shouldn't mess with well-formed extended syntax
-                        Assert.Equal(@"\\?\" + shortName, Path.GetFullPath(@"\\?\" + shortName));
-                    }
+                    // Shouldn't mess with well-formed extended syntax
+                    Assert.Equal(@"\\?\" + shortName, Path.GetFullPath(@"\\?\" + shortName));
 
                     // Validate case where short name doesn't expand to a real file
                     string invalidShortName = @"S:\DOESNT~1\USERNA~1.RED\LOCALS~1\Temp\bg3ylpzp";

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ namespace System.Diagnostics.Tests`
`10`	`10`	`{`
`11`	`11`	`public partial class ProcessModuleTests : ProcessTestBase`
`12`	`12`	`{`
`13`		`- [ConditionalFact(typeof(PathFeatures), nameof(PathFeatures.AreAllLongPathsAvailable))]`
	`13`	`+ [Fact]`
`14`	`14`	`public void LongModuleFileNamesAreSupported()`
`15`	`15`	`{`
`16`	`16`	`// To be able to test Long Path support for ProcessModule.FileName we need a .dll that has a path > 260 chars.`
Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ namespace System.IO.Compression.Tests`
`10`	`10`	`{`
`11`	`11`	`public class zip_ManualAndCompatibilityTests : ZipFileTestBase`
`12`	`12`	`{`
`13`		`- public static bool IsUsingNewPathNormalization => !PathFeatures.IsUsingLegacyPathNormalization();`
	`13`	`+ public static bool IsUsingNewPathNormalization => true;`
`14`	`14`
`15`	`15`	`public static IEnumerable<object[]> Get_CompatibilityTests_Data()`
`16`	`16`	`{`