…ion (#4219) This small change consists of a few commits which refactor janus_messages::Time and ::Duration to be in janus_messages::TimePrecision units. After the change to the janus_messages module, the first series of commits were done with regexes to get everything to compile. Then I progressively fixed tests, until they all passed. Then I've been performing cleanup, resolving issues from self-review and otherwise. I have filed follow-on issues for things that seemed bigger but not intrinsic to this change: - Key Rotator: Use chrono types #4216 - BatchIdentifiers need to be interconnected with TimePrecisions for proper garbage collection #4217 - CLI binaries need updates for Times and Durations unit changes #4218 I did include two other notable fixes/refactors in this PR which arguably could have gone into separate ones, and still could: - Fix Interval::EMPTY round-trip asymmetry, which came up while I was fixing tests but seems like a non-issue in production - Use IntervalExt::merged_with instead of manual interval construction, which is mostly that we had a slick way to make client_timestamp_interval one place using fold and IntervalExt::merged_with which didn't produce zero-width intervals, and then we had the other way that needed explicit add_duration(Duration::from_seconds(1), &time_precision). This seemed worthwhile to take here. Resolves #4019 Co-authored-by: Tim Geoghegan <timg@divviup.org> Co-authored-by: David Cook <dcook@divviup.org>

CLI binaries need updates for Times and Durations unit changes #4218

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions