Skip to content

Commit 4c5003c

Browse files
authored
Merge pull request #480 from direct-framework/feat/ui-design-nav
General UI and Nav
2 parents 4ad2d7d + fe35c88 commit 4c5003c

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

49 files changed

+1606
-1475
lines changed

data/events.csv

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
Title,Start Date,End Date,Description,Contributors,Image
2+
SSI CW23 Hack Day 2023,2023-05-04,2023-05-04,"Slides; Notes; Teams: HackMD, Miro, Github","Aleksandra Nenadic, Aman Goel, Dave Horsfall, Diego Alonso Álvarez, Eli Chadwick, Iain Barrass, Hannah Williams, Lieke de Boer, Paul K Korir, Martin O’Reilly, Matthew Bluteau, Nadine Spychala, Sean Marshallsay",assets/img/blog/single/image.jpg
3+
UKHSA internal presentation,2023-05-12,2023-05-12,Slides,Hannah Williams,assets/img/blog/single/image.jpg
4+
RSE South workshop,2023-05-16,2023-05-16,Slides,Hannah Williams,assets/img/blog/single/image.jpg
5+
UK Carpentries Community Call,2023-06-26,2023-06-26,Slides,"Aleksandra Nenadic, Matthew Bluteau, Dave Horsfall",assets/img/blog/single/image.jpg
6+
RS London South-East,2023-07-17,2023-07-17,Abstract,"Hannah Williams, Diego Alonso Álvarez",assets/img/blog/single/image.jpg
7+
RSE Conference 2023,2023-09-05,2023-09-08,Meeting notes,"Dave Horsfall, Hannah Williams, Matthew Bluteau",assets/img/blog/single/image.jpg
8+
Professionalising data science roles workshop,2023-10-02,2023-10-02,,Dave Horsfall,assets/img/blog/single/image.jpg
9+
DRI retreat,2024-03-18,2024-03-22,Emma & Sam attending; Emma involved in panels; Promote project via panels and poster,,assets/img/blog/single/image.jpg
10+
Dagstuhl Seminar 24161 Research Software Engineering: Bridging Knowledge Gaps,2024-04-14,2024-04-19,Toby attending and will try to promote project,,assets/img/blog/single/image.jpg
11+
Collaborations Workshop 2024,2024-04-30,2024-05-02,"Lightning talk/workshop; Target discussions, invite people to short interviews",,assets/img/blog/single/image.jpg
12+
N8CIR In person RSE Meetup Summer 2024,2024-06-01,2024-08-31,No website/dates available?,,assets/img/blog/single/image.jpg
13+
RSECon24,2024-09-03,2024-09-05,Submit panel in collaboration with Met Office via Emma; Submit workshop focused on defining & categorising skills,,assets/img/blog/single/image.jpg
14+
CarpentryConnect Heidelberg,2024-11-12,2024-11-14,"Aleks, Toby, Matt B working on submissions",,assets/img/blog/single/image.jpg
15+
CW25,2025-05-13,2025-05-15,"Proposal; Workshop notes & blogpost & Hack Day notes; Workshop slides, Hack Day slides",,assets/img/blog/single/image.jpg

direct_webapp/settings/settings.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@
130130
MIDDLEWARE.insert(1, "whitenoise.middleware.WhiteNoiseMiddleware")
131131
STATIC_ROOT = BASE_DIR / "staticfiles"
132132
AUTH_USER_MODEL = "main.User"
133-
LOGIN_REDIRECT_URL = "/profile"
133+
LOGIN_REDIRECT_URL = "/account/overview"
134134
EMAIL_BACKEND = "django.core.mail.backends.console.EmailBackend"
135135
SITE_TITLE = "DIRECT Framework"
136136

main/forms.py

Lines changed: 54 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
from typing import TYPE_CHECKING, Any
44

55
from crispy_forms.helper import FormHelper
6-
from crispy_forms.layout import HTML, Div, Field, Layout, Submit
6+
from crispy_forms.layout import HTML, Div, Layout, Submit
77
from django import forms
88
from django.forms import ModelForm
99

@@ -83,6 +83,7 @@ def __init__(self, *args: Any, user: "UserType", **kwargs: Any) -> None:
8383
required=False,
8484
initial=initial_value,
8585
label="Skill Level",
86+
widget=forms.Select(attrs={"class": "form-select form-select-sm"}),
8687
)
8788

8889
# Set up crispy forms helper
@@ -95,39 +96,71 @@ def __init__(self, *args: Any, user: "UserType", **kwargs: Any) -> None:
9596
for parent_category, subcategories in skill_organization.items():
9697
# Add parent category heading
9798
parent_heading = (
98-
f'<h3 class="h3 text-primary border-bottom">{parent_category}</h3>'
99+
f'<h2 class="card-title text-primary mt-5">{parent_category}</h2>'
99100
)
100101
parent_div = Div(HTML(parent_heading), css_class="mb-5")
101102

102103
subcategory_elements = []
103104
for subcategory, skills_list in subcategories.items():
104105
# Add subcategory heading
105106
subcategory_heading = f"<h4>{subcategory}</h4>"
106-
subcategory_div = Div(HTML(subcategory_heading), css_class="ms-3 mb-4")
107-
108-
# Create skills grid
109-
grid_classes = "row row-cols-1 row-cols-md-2 row-cols-lg-3 g-3 ms-3"
110-
skills_grid = Div(css_class=grid_classes)
111107

108+
# Outer card div
109+
subcategory_div = Div(css_class="mt-5 card rounded-1")
110+
111+
# Card body div with heading and table
112+
card_body_div = Div(css_class="card-body")
113+
114+
# Add subcategory heading inside card body
115+
card_body_div.append(HTML(subcategory_heading))
116+
117+
# Build the table for skills
118+
table_html = """
119+
<table class="table mt-2">
120+
<thead>
121+
<tr>
122+
<th scope="col">Skill</th>
123+
<th scope="col">Description</th>
124+
<th scope="col">Your Level</th>
125+
</tr>
126+
</thead>
127+
<tbody>
128+
"""
112129
for skill in skills_list:
113-
skill_card = Div(
114-
Div(
115-
HTML(f'<h6 class="card-title">{skill.name}</h6>'),
116-
HTML(f'<p class="card-text">{skill.description}</p>'),
117-
css_class="card-body",
118-
),
119-
Div(
120-
Field(f"skill_{skill.id}"),
121-
css_class="card-footer",
122-
),
123-
css_class="card h-100 bg-light border-1",
124-
)
125-
skills_grid.append(Div(skill_card, css_class="col"))
130+
table_html += f"""
131+
<tr>
132+
<td class="fw-semibold">{skill.name}</td>
133+
<td>{skill.description}</td>
134+
<td>{{{{ form.skill_{skill.id} }}}}</td>
135+
</tr>
136+
"""
137+
table_html += """
138+
</tbody>
139+
</table>
140+
"""
141+
142+
# Append table to card body
143+
card_body_div.append(HTML(table_html))
144+
145+
# Add a submit button for this subcategory
146+
subcategory_submit = Div(
147+
Submit(
148+
f"submit_{subcategory.replace(' ', '_')}",
149+
"Save",
150+
css_class="btn btn-primary mt-3",
151+
),
152+
css_class="mt-3",
153+
)
154+
card_body_div.append(subcategory_submit)
126155

127-
subcategory_div.append(skills_grid)
156+
# Append card body to the card
157+
subcategory_div.append(card_body_div)
158+
159+
# Add the subcategory div to elements
128160
subcategory_elements.append(subcategory_div)
129161

130162
parent_div.extend(subcategory_elements)
163+
131164
layout_elements.append(parent_div)
132165

133166
# Add submit button

main/static/assets/css/theme.css

Lines changed: 19 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

main/static/assets/css/theme.css.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

main/static/assets/css/theme.min.css

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

main/static/assets/css/theme.min.css.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

main/templates/django_registration/registration_closed.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
{% extends "main/base_auth.html" %}
1+
{% extends "main/base.auth.html" %}
22
{% block content %}
33
<h2>Oops!</h2>
44
<p>User Registration is not currently enabled</p>

main/templates/django_registration/registration_complete.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
{% extends "main/base_auth.html" %}
1+
{% extends "main/base.auth.html" %}
22
{% block content %}
33
{% if user.is_authenticated %}
44
<h2>Success!</h2>

main/templates/django_registration/registration_form.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
{% extends "main/base_auth.html" %}
1+
{% extends "main/base.auth.html" %}
22
{% load crispy_forms_tags %}
33
{% block content %}
44
<h2>Register your account</h2>

0 commit comments

Comments
 (0)