Skip to content

Using namespace app in module development #1

@c8y3

Description

@c8y3

We can see in the implementation of iris-check-module (https://github.com/dfir-iris/iris-check-module/blob/master/iris_check_module/IrisCheckModule.py#L24) that it imports method module_list_available_hooks from the namespace app.datamgmt.iris_engine.modules_db.
I believe, modules should limit themselves and use only methods provided by the iris_interface namespace. Otherwise this creates a coupling of the modules' code with potentially the whole codebase of iris-web. It's a potential recipe for frequent module breaks, as the iris-web application evolves. I thus find it preferable for the contract between modules and iris to be limited to the API of the iris_interface package only.
In this particular case, my suggestion would be to provide a method to list all available hooks trough the iris_interface package. What do you think?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions