fix(transactions): propagate memo field to service layer (#7413)

# Motivation

#7407 activated the memo field for the ICP transaction modal. But the
value was not being propagated from the component to the service layer.
This PR fixes the issue.

# Changes

- Propagate the `memo` to the submit event.

# Tests

- Updated test.

# Todos

- [x] Accessibility (a11y) – any impact?
- [x] Changelog – is it needed?

Author: yhabib

frontend/src/lib/components/transaction/TransactionReview.svelte

@@ -18,7 +18,6 @@
     destinationInfo: Snippet;
     disableSubmit: boolean;
     handleGoBack: () => void;
-    memo?: string;
     receivedAmount: Snippet;
     selectedNetwork?: TransactionNetwork;
     showLedgerFee?: boolean;
@@ -34,7 +33,6 @@
     destinationInfo,
     disableSubmit,
     handleGoBack,
-    memo,
     receivedAmount,
     selectedNetwork = undefined,
     showLedgerFee = true,
@@ -44,7 +42,8 @@
     withMemo,
   }: Props = $props();
 
-  const { sourceAccount, amount, destinationAddress } = $derived(transaction);
+  const { sourceAccount, amount, destinationAddress, memo } =
+    $derived(transaction);
 
   const dispatcher = createEventDispatcher();
   const submit = () => {

frontend/src/lib/modals/transaction/TransactionModal.svelte

@@ -175,6 +175,7 @@
         destinationAddress: selectedDestinationAddress,
         sourceAccount,
         amount,
+        memo,
       }}
       handleGoBack={goBack}
       {transactionFee}
@@ -185,7 +186,6 @@
       on:nnsSubmit
       on:nnsClose
       {withMemo}
-      {memo}
     >
       {#snippet additionalInfo()}
         <slot name="additional-info-review" />

frontend/src/tests/lib/modals/accounts/IcpTransactionModal.spec.ts

@@ -141,7 +141,7 @@ describe("IcpTransactionModal", () => {
         amount: parseInt(icpAmount),
         destinationAddress:
           "d0654c53339c85e0e5fff46a2d800101bc3d896caef34e1a0597426792ff9f32",
-        memo: undefined,
+        memo: "1234",
         sourceAccount: mockMainAccount,
       })
     );