isospec: process all destinations in design cells

It is possible that valid destinations for devices are more
than one level deep in the design cells. Instead of only
processing immediate children, we process all subnodes of
the design instead.

Note: this could be restricted to specific types of cells
in the future (i.e. "ps") or triggered on cells that
indicate they have subnodes. But for now, this approach
ensures that we don't miss collecting any possible devices.

Signed-off-by: Bruce Ashfield <bruce.ashfield@amd.com>

Author: Bruce Ashfield

lopper/assists/isospec.py

@@ -625,10 +625,8 @@ def device_collect( self ):
             return device_dict
 
         cell_list = [ design ]
-        cell_list.extend( design_cells.children() )
-        #cell_list = [ design_cells.children() ]
+        cell_list.extend( design_cells.subnodes() )
         for cell in cell_list:
-        #for cell in design_cells.children():
             try:
                 dests = cell["destinations"]
                 _debug( f"processing cell: {cell.name}" )
@@ -676,7 +674,6 @@ def device_collect( self ):
                                     "dest": dest
                                 }
                             _debug( f"                   ** destination '{dest}' device has no nodeid, adding to 'other'" )
-                            # os._exit(1)
 
                 dests = cell["SMIDs"]
                 _debug( f"           SMIDs {dests.abs_path} [{len(dests)}]" )
@@ -696,7 +693,6 @@ def device_collect( self ):
             except:
                     continue
 
-
         return device_dict, smid_dict, other_dict
 
     def access_type( self, access_entry ):
@@ -1036,11 +1032,9 @@ def isodomain_convert( self, spec_node, domains_tree ):
                             pass
                     else:
                         _info( f"non-device SMID any detected ... {access}" )
-                        # os._exit(1)
 
             except Exception as e:
-                _info( f"Exception during base protectiong checking: {e}" )
-                os._exit(1)
+                _info( f"Exception during base protection checking: {e}" )
 
         # The node indexed dictionary will be device names and a
         # True/False if it is referenced.
@@ -1144,13 +1138,12 @@ def isodomain_convert( self, spec_node, domains_tree ):
                         except:
                             pass
                     elif access_type == "cpu_list":
-                        _info( f"processing cpu list" )
                         try:
                             dests = self.dests( access )
-                            # _info( f"                     cpus dests: {dests}" )
+                            _info( f"                     cpus dests: {dests}" )
                             cpus = self.cpus( dests )
                             # _info( f"                     cpus: {cpus}" )
-
+                            _info( f"processing cpu list: {cpus}" )
                             for c in cpus:
                                 # add the cpus to the node
                                 domains_tree.cpu_add( yaml_node, c )