Add minimal .globalconfig for code analysis and enhance agent documentation (#34)

* Initial plan

* Add comprehensive project improvements: .globalconfig, global.json, and enhanced agent documentation

Co-authored-by: Malcolmnixon <[email protected]>

* Simplify improvements based on feedback: minimal .globalconfig, remove verbose examples

Co-authored-by: Malcolmnixon <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: Malcolmnixon <[email protected]>

Author: Copilot

.cspell.json

@@ -31,7 +31,18 @@
     "USERPROFILE",
     "LOCALAPPDATA",
     "mytool",
-    "Triaging"
+    "Triaging",
+    "globalconfig",
+    "vbproj",
+    "vcxproj",
+    "shproj",
+    "ruleset",
+    "resx",
+    "vsixmanifest",
+    "vsct",
+    "MSBuild",
+    "cyclomatic",
+    "frontmatter"
   ],
   "ignorePaths": [
     "node_modules",

.github/agents/software-quality-enforcer.md

@@ -43,6 +43,16 @@ The project uses two analyzer packages:
    - Bug detection and code smell identification
    - Must be same version in src/ and test/ projects
 
+### Analyzer Configuration
+
+The project uses `.globalconfig` to configure analyzer rules:
+
+- **Responsibility**: The Software Quality Enforcer agent is responsible for maintaining `.globalconfig`
+- **Philosophy**: Only explicitly configure rules that need to be disabled or have severity adjusted from defaults
+- **Documentation**: Each configured rule should have a comment explaining why it's set to its value
+- **Review**: Periodically review configured rules to ensure they're still necessary
+- **Quality Metrics**: Monitor code quality through analyzer warnings and build output
+
 ### Code Standards
 
 Follow these C# coding standards:

.globalconfig

@@ -0,0 +1,25 @@
+is_global = true
+
+# CA1014: Mark assemblies with CLSCompliant
+# Disabled: This project does not require CLS compliance
+dotnet_diagnostic.CA1014.severity = none
+
+# CA1017: Mark assemblies with ComVisible
+# Disabled: This project does not use COM interop
+dotnet_diagnostic.CA1017.severity = none
+
+# CA1303: Do not pass literals as localized parameters
+# Disabled: This project does not support localization
+dotnet_diagnostic.CA1303.severity = none
+
+# CA1707: Identifiers should not contain underscores
+# Disabled: Test methods use underscores for readability
+dotnet_diagnostic.CA1707.severity = none
+
+# CA1848: Use the LoggerMessage delegates
+# Disabled: This project does not use Microsoft.Extensions.Logging
+dotnet_diagnostic.CA1848.severity = none
+
+# CA2007: Consider calling ConfigureAwait on the awaited task
+# Disabled: Not applicable for console applications
+dotnet_diagnostic.CA2007.severity = none

AGENTS.md

@@ -148,6 +148,9 @@ Quality checks are automated through GitHub Actions:
 
 - **Spelling**: Checked using `cspell` against `.cspell.json` configuration
 - **Markdown Linting**: Validated using `markdownlint-cli` against `.markdownlint.json` configuration
+- **Code Analysis**: Microsoft.CodeAnalysis.NetAnalyzers and SonarAnalyzer.CSharp
+- **Analyzer Configuration**: `.globalconfig` file contains explicitly configured rules with explanations
+- **Build Validation**: Zero-warning builds enforced via `TreatWarningsAsErrors`
 
 ## Agent Instructions