apply-deepsource-advice

Author: deeplook

sparklines/__main__.py

@@ -10,20 +10,16 @@
 import sys
 from importlib.metadata import version
 
-if importlib.util.find_spec("termcolor"):
-    HAVE_TERMCOLOR = True
-else:
-    HAVE_TERMCOLOR = False
-
 if sys.version_info.major >= 3:
     from sparklines.sparklines import sparklines, demo
 else:
     from sparklines import sparklines, demo
 
+HAVE_TERMCOLOR = bool(importlib.util.find_spec("termcolor"))
+
 
 def _float_or_none(num_str):
     """Convert a string to a float if possible or None."""
-
     try:
         res = float(num_str)
     except ValueError:
@@ -52,15 +48,15 @@ def test_valid_number(arg):
 
 def test_valid_emphasis(arg):
     """Argparse validator for color filter expressions."""
-
     pat = r"\w+\:(eq|gt|ge|lt|le)\:.+"
     if re.match(pat, arg):
         return arg
-    else:
-        raise ValueError()
+
+    raise ValueError()
 
 
 def main(argv=None):
+    """Main entry point for the CLI."""
     desc = """Sparklines on the command-line, e.g. ▃▁▄▁▄█▂▅ for
         3 1 4 1 5 9 2 6. Please add bug reports and suggestions to
         https://github.com/deeplook/sparklines/issues."""
@@ -93,11 +89,11 @@ def main(argv=None):
         "-M", "--max", type=float, help="Use this value as the maximum for scaling."
     )
 
-    help_emph = """Emphasize input values below or above a certain
+    help_emph = f"""Emphasize input values below or above a certain
         threshold (e.g. "green:gt:5.0"). This option takes one argument
         value, but can be given repeatedly. Works only when optional
-        dependancy "termcolor" is met (which is {0!s} here). Otherwise
-        has no effect.""".format(HAVE_TERMCOLOR)
+        dependancy "termcolor" is met (which is {HAVE_TERMCOLOR} here). Otherwise
+        has no effect."""
     p.add_argument(
         "-e",
         "--emphasize",

tests/test_sparkline.py

@@ -29,7 +29,6 @@ def strip_ansi(text):
 
 def test_parse_float():
     """Test parsing input numbers."""
-
     t = is_valid_number
 
     assert t("4.5") == "4.5"
@@ -61,15 +60,13 @@ def test_parse_float():
 
 def test_scale0():
     """Test scale..."""
-
     res = scale_values([1, 2, 3])
     exp = [1.0, 4.0, 8.0]
     assert res == exp
 
 
 def test_scale1():
     """Test scale..."""
-
     res = scale_values([1, 2, 3], num_lines=2)
     exp = [1.0, 8.0, 16.0]
     assert res == exp
@@ -85,31 +82,27 @@ def test_batch():
 
 def test_scale_pi():
     """Test scale Pi."""
-
     res = scale_values([3, 1, 4, 1, 5, 9, 2, 6])
     exp = [3, 1, 4, 1, 4, 8, 2, 5]
     assert res == exp
 
 
 def test_pi():
     """Test first eight digits of Pi."""
-
     res = sparklines([3, 1, 4, 1, 5, 9, 2, 6])
     exp = ["▃▁▄▁▄█▂▅"]
     assert res == exp
 
 
 def test_minmax():
     """Test two values, min and max."""
-
     res = sparklines([1, 8])
     exp = ["▁█"]  # 1, 8
     assert res == exp
 
 
 def test_rounding0():
     """Test two values, min and max."""
-
     res = sparklines([1, 5, 8])
     exp = ["▁▅█"]  # 1, 5, 8
     assert res == exp
@@ -141,7 +134,6 @@ def test_minimum_internal_consistency():
 
 def test1():
     """Test single values all have the same four pixel high output character."""
-
     for i in range(10):
         res = sparklines([i])
         exp = ["▄"]
@@ -150,7 +142,6 @@ def test1():
 
 def test_empty():
     """Make sure degenerate cases don't fail."""
-
     res = sparklines([])
     exp = [""]
     # Produces an empty line from the command line