diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index e2c3e6f..b0ff362 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -23,7 +23,7 @@ jobs: - name: Set up node uses: actions/setup-node@master with: - node-version: '16' + node-version: '20' check-latest: true - name: Build vue components run: | @@ -44,7 +44,7 @@ jobs: - name: Set up node uses: actions/setup-node@master with: - node-version: '16' + node-version: '20' check-latest: true - name: Run unit tests run: | diff --git a/.nvmrc b/.nvmrc index bcee2c1..67e145b 100644 --- a/.nvmrc +++ b/.nvmrc @@ -1 +1 @@ -v16.18 +v20.18.0 diff --git a/Dockerfile b/Dockerfile index 9a07315..d928e53 100644 --- a/Dockerfile +++ b/Dockerfile @@ -1,4 +1,4 @@ -FROM node:16 AS ui-build +FROM node:20.18.0 AS ui-build WORKDIR /build @@ -14,7 +14,7 @@ RUN chmod -R g=u /build/dist # # build node app in the next stage # -FROM node:16.18-alpine +FROM node:20.18.0-alpine LABEL maintainer="ming luo" diff --git a/README.md b/README.md index b80ac63..b1cc03b 100644 --- a/README.md +++ b/README.md @@ -8,7 +8,7 @@ The admin console is a VueJS application that runs in a browser. It also include To install the Pulsar Admin Console: -1. Ensure [node](https://nodejs.org/en/download/) version 16.15 or higher is installed. +1. Ensure [node](https://nodejs.org/en/download/) version 20.18 or higher is installed. 2. Download the latest release tarball from the [release page](https://github.com/datastax/pulsar-admin-console/releases). @@ -145,9 +145,9 @@ The [DataStax Pulsar Helm Chart](https://github.com/datastax/pulsar-helm-chart) Use these versions of node and npm: ``` $ npm -v -6.14.15 +10.8.0 $ node -v -v14.18.3 +v20.18.0 ``` In order to easily manage your node and npm versions across developer machines, we use [nvm](https://github.com/nvm-sh/nvm). We set the node version in the [.nvmrc](./.nvmrc) file. In order to set up your environment, open a shell, change to the project directory, and run the following: @@ -163,10 +163,10 @@ When upgrading versions of node, we should make sure to use LTS versions. You ca nvm list ``` -Then, pick which `lts/` version to use. Currently, we use `fermium`, so you can run the following: +Then, pick which `lts/` version to use. Currently, we use `iron`, so you can run the following: ```shell -nvm install lts/fermium +nvm install lts/iron ``` When upgrading node versions, make sure to update the [Dockerfile](./Dockerfile), the [.nvmrc](./.nvmrc) file, and the CI scripts (i.e. [.github/](./github/)). diff --git a/dashboard/package.json b/dashboard/package.json index d0fb830..e479ffd 100644 --- a/dashboard/package.json +++ b/dashboard/package.json @@ -97,8 +97,8 @@ "moment": "^2.29.4" }, "engines": { - "node": "^16.15.1", - "npm": "^8.11.0" + "node": "^20.18.0", + "npm": "^10.8.0" }, "gitHooks": { "pre-commit": "lint-staged" diff --git a/server/package.json b/server/package.json index d1d5e77..96a690e 100644 --- a/server/package.json +++ b/server/package.json @@ -4,8 +4,8 @@ "description": "backend of dashboard", "main": "server.js", "engines": { - "node": "^16.15.1", - "npm": "^8.11.0" + "node": "^20.18.0", + "npm": "^10.8.0" }, "scripts": { "serve": "node server.js",