Skip to content

Commit fbc056b

Browse files
authored
[build] upgrade node version to 20.18 (#113)
1 parent f6c61b6 commit fbc056b

File tree

6 files changed

+14
-14
lines changed

6 files changed

+14
-14
lines changed

.github/workflows/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ jobs:
2323
- name: Set up node
2424
uses: actions/setup-node@master
2525
with:
26-
node-version: '16'
26+
node-version: '20'
2727
check-latest: true
2828
- name: Build vue components
2929
run: |
@@ -44,7 +44,7 @@ jobs:
4444
- name: Set up node
4545
uses: actions/setup-node@master
4646
with:
47-
node-version: '16'
47+
node-version: '20'
4848
check-latest: true
4949
- name: Run unit tests
5050
run: |

.nvmrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
v16.18
1+
v20.18.0

Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM node:16 AS ui-build
1+
FROM node:20.18.0 AS ui-build
22

33
WORKDIR /build
44

@@ -14,7 +14,7 @@ RUN chmod -R g=u /build/dist
1414
#
1515
# build node app in the next stage
1616
#
17-
FROM node:16.18-alpine
17+
FROM node:20.18.0-alpine
1818

1919
LABEL maintainer="ming luo"
2020

README.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ The admin console is a VueJS application that runs in a browser. It also include
88

99
To install the Pulsar Admin Console:
1010

11-
1. Ensure [node](https://nodejs.org/en/download/) version 16.15 or higher is installed.
11+
1. Ensure [node](https://nodejs.org/en/download/) version 20.18 or higher is installed.
1212

1313
2. Download the latest release tarball from the [release page](https://github.com/datastax/pulsar-admin-console/releases).
1414

@@ -145,9 +145,9 @@ The [DataStax Pulsar Helm Chart](https://github.com/datastax/pulsar-helm-chart)
145145
Use these versions of node and npm:
146146
```
147147
$ npm -v
148-
6.14.15
148+
10.8.0
149149
$ node -v
150-
v14.18.3
150+
v20.18.0
151151
```
152152

153153
In order to easily manage your node and npm versions across developer machines, we use [nvm](https://github.com/nvm-sh/nvm). We set the node version in the [.nvmrc](./.nvmrc) file. In order to set up your environment, open a shell, change to the project directory, and run the following:
@@ -163,10 +163,10 @@ When upgrading versions of node, we should make sure to use LTS versions. You ca
163163
nvm list
164164
```
165165

166-
Then, pick which `lts/` version to use. Currently, we use `fermium`, so you can run the following:
166+
Then, pick which `lts/` version to use. Currently, we use `iron`, so you can run the following:
167167

168168
```shell
169-
nvm install lts/fermium
169+
nvm install lts/iron
170170
```
171171

172172
When upgrading node versions, make sure to update the [Dockerfile](./Dockerfile), the [.nvmrc](./.nvmrc) file, and the CI scripts (i.e. [.github/](./github/)).

dashboard/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,8 +97,8 @@
9797
"moment": "^2.29.4"
9898
},
9999
"engines": {
100-
"node": "^16.15.1",
101-
"npm": "^8.11.0"
100+
"node": "^20.18.0",
101+
"npm": "^10.8.0"
102102
},
103103
"gitHooks": {
104104
"pre-commit": "lint-staged"

server/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
"description": "backend of dashboard",
55
"main": "server.js",
66
"engines": {
7-
"node": "^16.15.1",
8-
"npm": "^8.11.0"
7+
"node": "^20.18.0",
8+
"npm": "^10.8.0"
99
},
1010
"scripts": {
1111
"serve": "node server.js",

0 commit comments

Comments
 (0)