test: try to fix flaky tests (#869)

Not sure if it's the problem…

Author: ThibaudDauce

tests/dataservices/[did].spec.ts

@@ -27,6 +27,8 @@ test('sidebar displays correct metadata values', async ({ page }) => {
 
 test('discussions tab is accessible', async ({ page }) => {
   await page.goto(`/dataservices/${DATASERVICE_SLUG}`)
+  // Wait for Vue hydration before clicking NuxtLink (fix flaky test on Firefox)
+  await page.waitForLoadState('networkidle')
 
   const discussionsTab = page.getByRole('link', { name: /Discussions/ })
   await expect(discussionsTab).toBeVisible()

tests/dataservices/search.spec.ts

@@ -26,6 +26,8 @@ test('search filters results', async ({ page }) => {
 
 test('clicking dataservice navigates to detail', async ({ page }) => {
   await page.goto('/dataservices/search')
+  // Wait for Vue hydration before clicking NuxtLink (fix flaky test on Firefox)
+  await page.waitForLoadState('networkidle')
 
   const dataserviceLink = page.getByRole('link', { name: /Explore API/i })
   await expect(dataserviceLink).toBeVisible()

tests/datasets/[did].spec.ts

@@ -49,6 +49,8 @@ test('clicking dataset label navigates to filtered search', async ({
   await page.goto(
     '/datasets/base-sirene-des-entreprises-et-de-leurs-etablissements-siren-siret/',
   )
+  // Wait for Vue hydration before clicking NuxtLink (fix flaky test on Firefox)
+  await page.waitForLoadState('networkidle')
 
   // Check if dataset has labels
   const labelsList = page.getByTestId('label-list')
@@ -100,6 +102,8 @@ test('discussions tab navigates to discussions page', async ({ page }) => {
   await page.goto(
     '/datasets/base-sirene-des-entreprises-et-de-leurs-etablissements-siren-siret/',
   )
+  // Wait for Vue hydration before clicking NuxtLink (fix flaky test on Firefox)
+  await page.waitForLoadState('networkidle')
 
   const discussionsTab = page.getByRole('link', { name: /Discussions/ })
   await discussionsTab.click()

tests/datasets/search.spec.ts

@@ -131,6 +131,8 @@ test('badge filter persists on page reload', async ({ page }) => {
 
 test('clicking dataset navigates to detail', async ({ page }) => {
   await page.goto('/datasets/search/')
+  // Wait for Vue hydration before clicking NuxtLink (fix flaky test on Firefox)
+  await page.waitForLoadState('networkidle')
 
   const datasetLink = page.getByRole('link', { name: /SIRENE/i }).first()
   await expect(datasetLink).toBeVisible()

tests/discussions/discussions.normal-user.spec.ts

@@ -17,6 +17,8 @@ test.describe('Discussions as normal user', () => {
     const dataset = await response.json()
 
     await page.goto(`/datasets/${dataset.id}/`)
+    // Wait for Vue hydration before clicking NuxtLink (fix flaky test on Firefox)
+    await page.waitForLoadState('networkidle')
 
     // Navigate to discussions tab
     await page.getByRole('link', { name: 'Discussions' }).click()

tests/reuses/[rid].spec.ts

@@ -32,6 +32,8 @@ test('external link button is visible', async ({ page }) => {
 
 test('discussions tab is accessible', async ({ page }) => {
   await page.goto(`/reuses/${REUSE_SLUG}`)
+  // Wait for Vue hydration before clicking NuxtLink (fix flaky test on Firefox)
+  await page.waitForLoadState('networkidle')
 
   const discussionsTab = page.getByRole('link', { name: /Discussions/ })
   await expect(discussionsTab).toBeVisible()

tests/reuses/search.spec.ts

@@ -35,6 +35,8 @@ test('topic filter works', async ({ page }) => {
 
 test('clicking reuse navigates to detail', async ({ page }) => {
   await page.goto('/reuses/search')
+  // Wait for Vue hydration before clicking NuxtLink (fix flaky test on Firefox)
+  await page.waitForLoadState('networkidle')
 
   const reuseLink = page.getByRole('link', { name: /itineriz/i })
   await expect(reuseLink).toBeVisible()