fix #14315: FP knownConditionTrueFalse with constant in assert() (#8064)

Author: ludviggunne

lib/checkother.cpp

@@ -2948,7 +2948,9 @@ void CheckOther::checkDuplicateExpression()
                                     while (parent && parent->astParent()) {
                                         parent = parent->astParent();
                                     }
-                                    if (parent && parent->previous() && isStaticAssert(*mSettings, parent->previous())) {
+                                    if (parent && parent->previous() &&
+                                        (isStaticAssert(*mSettings, parent->previous()) ||
+                                         Token::simpleMatch(parent->previous(), "assert"))) {
                                         continue;
                                     }
                                 }

test/testother.cpp

@@ -195,6 +195,7 @@ class TestOther : public TestFixture {
         TEST_CASE(duplicateExpression16); // #10569
         TEST_CASE(duplicateExpression17); // #12036
         TEST_CASE(duplicateExpression18);
+        TEST_CASE(duplicateExpression19);
         TEST_CASE(duplicateExpressionLoop);
         TEST_CASE(duplicateValueTernary);
         TEST_CASE(duplicateValueTernarySizeof); // #13773
@@ -7988,6 +7989,14 @@ class TestOther : public TestFixture {
         ASSERT_EQUALS("", errout_str());
     }
 
+    void duplicateExpression19() {
+        checkP("const int i = 0;\n"
+               "void f() {\n"
+               "    assert(i == 0);\n"
+               "}\n");
+        ASSERT_EQUALS("", errout_str());
+    }
+
     void duplicateExpressionLoop() {
         check("void f() {\n"
               "    int a = 1;\n"